all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Dario Gjorgjevski <dario.gjorgjevski@gmail.com>
Cc: Stefan Kangas <stefan@marxist.se>, 38294@debbugs.gnu.org
Subject: bug#38294: [PATCH] Handle killing of virtual buffers in Ido
Date: Fri, 14 Aug 2020 13:00:56 +0200	[thread overview]
Message-ID: <87r1s9a3vb.fsf@gnus.org> (raw)
In-Reply-To: <fv2zojlfih37j4.fsf@gmail.com> (Dario Gjorgjevski's message of "Fri, 14 Aug 2020 11:23:43 +0200")

Dario Gjorgjevski <dario.gjorgjevski@gmail.com> writes:

> Hi Stefan,
>
>> Killing it isn't a no-op though.  When you kill it, you get prompted to
>> save changes, it runs hooks in the background, presumably removes it
>> from active memory, other functions will no longer be able to just
>> switch to it, etc., etc.

Yeah, but these "virtual buffers" don't really exist, so none of that
will happen, I'd have thought?

> Point taken.  In that case, my only complaint would be that
> ‘ido-kill-buffer-at-head’ does treat killing a virtual buffer as
> removing it from ‘recentf-list’ (just as suggested here), so there is
> some inconsistency.  However, I can live with it.

Yeah, that is inconsistent:

;;; KILL CURRENT BUFFER
(defun ido-kill-buffer-at-head ()
  "Kill the buffer at the head of `ido-matches'.
If cursor is not at the end of the user input, delete to end of input."
[...]
       ;; Handle virtual buffers
       ((assoc buf ido-virtual-buffers)
	(setq recentf-list
	      (delete (cdr (assoc buf ido-virtual-buffers)) recentf-list))

So now I'm kinda thinking that your original patch is correct.  :-)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2020-08-14 11:00 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-20  8:56 bug#38294: [PATCH] Handle killing of virtual buffers in Ido Dario Gjorgjevski
2020-01-20 18:40 ` Stefan Kangas
2020-01-22  8:21   ` Dario Gjorgjevski
2020-01-22  9:00     ` Stefan Kangas
2020-08-09 13:20       ` Lars Ingebrigtsen
2020-08-12 22:01         ` Stefan Kangas
2020-08-13  8:16           ` Lars Ingebrigtsen
2020-08-13  8:37             ` Stefan Kangas
2020-08-13  8:39               ` Lars Ingebrigtsen
2020-08-13  9:50           ` Dario Gjorgjevski
2020-08-13 11:04             ` Stefan Kangas
2020-08-14  9:23               ` Dario Gjorgjevski
2020-08-14 11:00                 ` Lars Ingebrigtsen [this message]
2020-08-14 16:14                   ` Stefan Kangas
2020-08-14 21:58                     ` Dario Gjorgjevski
2020-08-14 22:56                       ` Stefan Kangas
2020-08-15  8:03                         ` Dario Gjorgjevski
2020-08-15 10:29                           ` Lars Ingebrigtsen
2020-08-15 14:03                             ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r1s9a3vb.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=38294@debbugs.gnu.org \
    --cc=dario.gjorgjevski@gmail.com \
    --cc=stefan@marxist.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.