From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#42870: [PATCH] Change eshell-output-filter to match the behavior of comint-output-filter Date: Sun, 16 Aug 2020 14:32:38 +0200 Message-ID: <87r1s6vkih.fsf@gnus.org> References: <20200814212038.44371-1-steven@stebalien.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18043"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 42870@debbugs.gnu.org To: Steven Allen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 16 14:33:14 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k7Hqb-0004Zw-NC for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 16 Aug 2020 14:33:13 +0200 Original-Received: from localhost ([::1]:43678 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k7Hqa-0002lU-QG for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 16 Aug 2020 08:33:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58442) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k7HqQ-0002kr-Sy for bug-gnu-emacs@gnu.org; Sun, 16 Aug 2020 08:33:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45480) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k7HqQ-0000jj-J9 for bug-gnu-emacs@gnu.org; Sun, 16 Aug 2020 08:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k7HqQ-0000uD-H6 for bug-gnu-emacs@gnu.org; Sun, 16 Aug 2020 08:33:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Aug 2020 12:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42870 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 42870-submit@debbugs.gnu.org id=B42870.15975811803458 (code B ref 42870); Sun, 16 Aug 2020 12:33:02 +0000 Original-Received: (at 42870) by debbugs.gnu.org; 16 Aug 2020 12:33:00 +0000 Original-Received: from localhost ([127.0.0.1]:57023 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k7HqN-0000ti-Qr for submit@debbugs.gnu.org; Sun, 16 Aug 2020 08:33:00 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:36016) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k7HqI-0000tL-AW for 42870@debbugs.gnu.org; Sun, 16 Aug 2020 08:32:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=c9xCfWKq/lXXMwCEGyjzZ3jI/DlJoaQDi4wv5xQuj1w=; b=We0atpUXa040qer7CbNNsQRydR C02TCrVCsbF6/Lufa8zq5OykvqmF34P7Ep36uEmPYQCHPi4vPRpEOXkipoAIiueVsdNjr3B/97WCx 9JFvDI8fmjdj6Q++4AMUxUwaNWKBzuhmTLUgfvCA7YZ9bpFiv5sJdsOEFzbgQPFSJhck=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k7Hq3-0000e4-67; Sun, 16 Aug 2020 14:32:48 +0200 X-Now-Playing: Kate Bush's _Never For Ever_: "Egypt" In-Reply-To: <20200814212038.44371-1-steven@stebalien.com> (Steven Allen's message of "Fri, 14 Aug 2020 14:20:38 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:185274 Archived-At: Steven Allen writes: > This change (a) sets the current buffer to the process-buffer when > invoking preoutput filter functions and (b) only invokes them when the > process-buffer is live. Otherwise, the preoutput filter functions be > invoked in whatever buffer happens to be focused, breaking hooks that > read buffer-local variables. > > * lisp/eshell/esh-mode.el: (eshell-output-filter): Match > current-buffer behavior of comint-output-filter. There we a lot of unavoidable whitespace changes in the patch, so but if I read it correctly, this sounds like the correct fix, so I've applied your patch to Emacs 28. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no