all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Steven Allen <steven@stebalien.com>
Cc: 42870@debbugs.gnu.org
Subject: bug#42870: [PATCH] Change eshell-output-filter to match the behavior of comint-output-filter
Date: Sun, 16 Aug 2020 14:32:38 +0200	[thread overview]
Message-ID: <87r1s6vkih.fsf@gnus.org> (raw)
In-Reply-To: <20200814212038.44371-1-steven@stebalien.com> (Steven Allen's message of "Fri, 14 Aug 2020 14:20:38 -0700")

Steven Allen <steven@stebalien.com> writes:

> This change (a) sets the current buffer to the process-buffer when
> invoking preoutput filter functions and (b) only invokes them when the
> process-buffer is live. Otherwise, the preoutput filter functions be
> invoked in whatever buffer happens to be focused, breaking hooks that
> read buffer-local variables.
>
> * lisp/eshell/esh-mode.el: (eshell-output-filter): Match
> current-buffer behavior of comint-output-filter.

There we a lot of unavoidable whitespace changes in the patch, so but if
I read it correctly, this sounds like the correct fix, so I've applied
your patch to Emacs 28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2020-08-16 12:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87pn7qvki4.fsf@gnus.org>
2020-08-14 21:20 ` bug#42870: [PATCH] Change eshell-output-filter to match the behavior of comint-output-filter Steven Allen
2020-08-16 12:32   ` Lars Ingebrigtsen [this message]
     [not found]   ` <handler.42870.C.15975811823483.notifdonectrl.0@debbugs.gnu.org>
2020-08-16 19:43     ` bug#42870: acknowledged by developer (control message for bug #42870) Steven Allen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r1s6vkih.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=42870@debbugs.gnu.org \
    --cc=steven@stebalien.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.