From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Caio Henrique Newsgroups: gmane.emacs.devel Subject: Re: Changes for emacs 28 Date: Fri, 11 Sep 2020 11:02:54 -0300 Message-ID: <87r1r8if75.fsf@gmail.com> References: <20200910231420.kvqg6ohvxetpup5c.ref@Ergus> <20200910231420.kvqg6ohvxetpup5c@Ergus> <83zh5whl5p.fsf@gnu.org> <20200911101509.v2b7dfiq6kuqlysp@Ergus> <83lfhgha8m.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29236"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Ergus , caiohcs0@gmail.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Sep 11 16:05:28 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kGjg7-0007TB-8R for ged-emacs-devel@m.gmane-mx.org; Fri, 11 Sep 2020 16:05:27 +0200 Original-Received: from localhost ([::1]:38772 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kGjg6-0007Tg-6g for ged-emacs-devel@m.gmane-mx.org; Fri, 11 Sep 2020 10:05:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42334) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kGje3-0005L9-IX for emacs-devel@gnu.org; Fri, 11 Sep 2020 10:03:19 -0400 Original-Received: from mail-qt1-x841.google.com ([2607:f8b0:4864:20::841]:46579) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kGje2-0007w0-23; Fri, 11 Sep 2020 10:03:19 -0400 Original-Received: by mail-qt1-x841.google.com with SMTP id r8so7848077qtp.13; Fri, 11 Sep 2020 07:03:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=cR21fNhjtcHHx5K0fJF8LA0lKBLOMhNPLZhp939EtpI=; b=mMKyRRwcDVVfU6bcwDKifEqpE8yt057OczHBztz0b2Zg55TelBExEvKTNQzcMyG6mN Q1V2PRyIEVUibYEFzTsVxCUGQfjoD9ntHs38Wa0QFB+CgJRP/UeC5bSqkYv3Dk7mrsex DFV1R4hRcvnUflhZqzsrmnDvrvvwt+nw5G4fRAUETcl8ZeSbqei183Qy3irrERCIFjUl zVYtRUsakGGfIGJSsHmYsvZTe0BSwkLEhsN9Pdw9JTHI8hm+nlwitfUaU7BxinzvUu7i ePvm/jpKFSVMvMM3GeSp8IhYYYzA4i0DGhpnCfg0+pIRH6SwV5R3zVaowmY7pd+F7E44 hj4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=cR21fNhjtcHHx5K0fJF8LA0lKBLOMhNPLZhp939EtpI=; b=h993dvCFWFrKkickMrKI0CYZxgLLyfkuM47C9aJuy5HFk9o2ltL2fjZjgfHkbQpn0v +zokVKcg6zc1gnSErWavqU3iqeBJRsHV0/3SqgKCbdMlwH7fbYGWJFkxn+JihDF67IVV y6JaI4MX4b/I2DOiJvMhvCTtBaywz+TH9aF9LJzlvtgQ+3y2qzzah+pDY/BGacIPN2pc 2XuBGQsqRB1Sij6e/PPMokkVe5iMjVcmYytqTjGTIuwA/PAxhmKj0BKo/Q7/0Y/FeH5a zUjSATSwHOY+jgzaMmLykJ2o+/0zReMOfcAc8LpSFjy1Z3UaeJFA/OFfnWchi4/6tg51 lnwA== X-Gm-Message-State: AOAM533dchZsE1lmi03UCtehRhJcztEkELqpcL2T54dYhDvVxFqJWDYt 8dnhV0HY2CG6NJIdvU8xI2kIGb/CxZk= X-Google-Smtp-Source: ABdhPJzZojBCW0MFcpCjmtxvkB3tuJsA1uJ87FEFwW8O6GeJ0hP3LGw7zpv+u7GgJmYhLDrZvOJ5Sg== X-Received: by 2002:ac8:75d2:: with SMTP id z18mr2033753qtq.346.1599832996276; Fri, 11 Sep 2020 07:03:16 -0700 (PDT) Original-Received: from localhost.localdomain ([181.223.151.236]) by smtp.gmail.com with ESMTPSA id p20sm2898113qtk.21.2020.09.11.07.03.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Sep 2020 07:03:15 -0700 (PDT) X-Google-Original-From: Caio Henrique In-Reply-To: <83lfhgha8m.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 11 Sep 2020 13:35:21 +0300") Received-SPF: pass client-ip=2607:f8b0:4864:20::841; envelope-from=caiohcs0@gmail.com; helo=mail-qt1-x841.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:255176 Archived-At: Eli Zaretskii writes: >> Date: Fri, 11 Sep 2020 12:15:09 +0200 >> From: Ergus >> Cc: caiohcs0@gmail.com, emacs-devel@gnu.org >> >> I tried it but there is a problem enabling disabling the icon. It >> doesn't enable automatically when I do an undo until I click with the >> mouse somewhere. >> >> Maybe it is a redisplay problem? > > No, because the Cut and Paste button have no such problems. I tried that code again and I experienced the same thing as Ergus, but only in some cases. If I: 1. launch emacs -Q 2. type only the letter "a" 3. click on the "Undo" button on the toolbar Then the "Redo" button on the toolbar activates and all works well. But if I try: 1. launch emacs -Q 2. type the letter "a" 3. press RET to insert newline 4. type the letter "b" 5. click on the "Undo" button on the toolbar In this case the "Redo" toolbar button doesn't activate (but the "Redo" button on the menu bar works fine). Then if I click with the mouse anywhere inside the buffer, then the toolbar menu activates. I don't know what the problem is, any ideas? > Thanks, but please add a help-echo text for that button. The menu > item perhaps could do without it, but not the tool-bar button. Isn't the help-echo text the one that appears when I place my mouse over the toolbar button? Isn't this text the same one used for the menu bar buttons? When I place my mouse over "Redo" on the toolbar, it says "Undo last undo".