Bug: org-priority face has extra space at the end starting from version 9.4 [9.4 (9.4-elpaplus @ /home/rrudakov/.emacs.d/elpa/org-plus-contrib-20200914/)]

[Roman Rudakov <rrudakov@pm.me>]

[-- Attachment #1: Type: text/plain, Size: 1789 bytes --]

Remember to cover the basics, that is, what you expected to happen and
what in fact did happen. You don't know how to make a good report? See

https://orgmode.org/manual/Feedback.html#Feedback

Your bug report will be posted to the Org mailing list.
------------------------------------------------------------------------

Hello,

I use theme which draw boxes around priority cookie. Before updating to
version 9.4 box was rendered just around square brackets, but since
version 9.4 it has additional space at the end.

I think it's related to the fact that org-priority face definition used
to use separate regex which didn't include space, and now it uses
variable org-priority-regexp which does include additional space
character.

;; Old
(defun org-font-lock-add-priority-faces (limit)
"Add the special priority faces."
(while (re-search-forward "^\\*+ .*?\\(\\[#\\(.\\)\\]\\)" limit t)
(add-text-properties
(match-beginning 1) (match-end 1)
(list 'face (org-get-priority-face (string-to-char (match-string 2)))
'font-lock-fontified t))))

;; New
(defun org-font-lock-add-priority-faces (limit)
"Add the special priority faces."
(while (re-search-forward org-priority-regexp limit t)
(add-text-properties
(match-beginning 1) (match-end 1)
(list 'face (org-get-priority-face (string-to-char (match-string 2)))
'font-lock-fontified t))))

(defvar org-priority-regexp ".*?\\(\\[#\\([A-Z0-9]+\\)\\] ?\\)"

Removing space before last question mark fixes my problem, but I'm not
sure it won't affect something.[org-mode-priority-9.3.8.png][org-mode-priority-9.4.png]

Emacs : GNU Emacs 27.1 (build 2, x86_64-pc-linux-gnu, X toolkit, cairo version 1.16.0, Xaw3d scroll bars)
of 2020-08-11
Package: Org mode version 9.4 (9.4-elpaplus @ /home/rrudakov/.emacs.d/elpa/org-plus-contrib-20200914/)

[-- Attachment #2.1: Type: text/html, Size: 2371 bytes --]

[-- Attachment #2.2: org-mode-priority-9.4.png --]
[-- Type: image/png, Size: 5121 bytes --]

[-- Attachment #2.3: org-mode-priority-9.3.8.png --]
[-- Type: image/png, Size: 5315 bytes --]