all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Fejfighter <fejfighter@gmail.com>
Cc: 43989@debbugs.gnu.org
Subject: bug#43989:
Date: Thu, 15 Oct 2020 09:56:43 +0200	[thread overview]
Message-ID: <87r1pzylac.fsf@gnus.org> (raw)
In-Reply-To: <CALohuRBPrQJQ=gRYhZXPD_KsFwsqRbCWq7Pt7vt9mVLS9GgTTg@mail.gmail.com> (fejfighter@gmail.com's message of "Thu, 15 Oct 2020 07:38:18 +1100")

Fejfighter <fejfighter@gmail.com> writes:

> * src/xwidget.c (Fxwidget_webkit_title): pass emptry string when no
> title is returned

Thanks, applied to Emacs 28 with one change:

>    WebKitWebView *wkwv = WEBKIT_WEB_VIEW (xw->widget_osr);
> -  return build_string (webkit_web_view_get_title (wkwv));
> +  const gchar *title = webkit_web_view_get_title (wkwv);
> +
> +  return build_string (title?: "");

The "Elvis operator" is a gcc-only extension to C, I think?  So I
rewrote it to use a traditional ternary instead.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





      reply	other threads:[~2020-10-15  7:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-14 11:42 bug#43989: 28.0.50; X-Widget crashes on opening file Maximiliano Sandoval via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-10-14 20:38 ` bug#43989: Fejfighter
2020-10-15  7:56   ` Lars Ingebrigtsen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r1pzylac.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=43989@debbugs.gnu.org \
    --cc=fejfighter@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.