bug#44594: tabulated-list-mode: column header needlessly truncated

bug#44594: tabulated-list-mode: column header needlessly truncated

[Stefan Kangas]

Severity: minor

The column header in tabulated-list-mode is needlessly truncated.

Steps to reproduce:

0. emacs -Q
1. M-x list-buffers RET
2. C-x o
3. C-4 C-f
4. C-1 C-4 {

Result: The header is truncated to "Buff..." even though there is enough
space to show it all.

Expected result: The header is not truncated.

---

Here is a list of commands where this could be tested:

list-buffers, list-bookmarks, list-packages, list-processes,
list-dynamic-libraries, org-lint and flymake-diagnostics-buffer-mode

bug#44594: [PATCH v4] doc: add a note about relabling after upgrades to the

[Daniel Brooks]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: [PATCH v4] doc: add a note about relabling after upgrades to the --]
[-- Type: text/x-patch, Size: 1155 bytes --]

From b29749885c93811f901d0ec4e13de38f70f8c100 Mon Sep 17 00:00:00 2001
From: Daniel Brooks <db48x@db48x.net>
Date: Sat, 14 Nov 2020 08:04:30 -0800
Subject: [PATCH v4] doc: add a note about relabling after upgrades to the
 SELinux Support section of the manual

* doc/guix.texi (SELinux Support): add note about upgrades
---
 doc/guix.texi | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/doc/guix.texi b/doc/guix.texi
index 8440ffffc7..67f5155b9f 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -1398,6 +1398,11 @@ install and run it, which lifts it into the @code{guix_daemon_t} domain.
 At that point SELinux could not prevent it from accessing files that are
 allowed for processes in that domain.
 
+You will need to relabel the @file{/gnu} directory after all upgrades to
+@file{guix-daemon}, such as with @code{guix pull}. You can do this with
+@code{restorecon -vR /gnu}, or by other means provided by your operating
+system.
+
 We could generate a much more restrictive policy at installation time,
 so that only the @emph{exact} file name of the currently installed
 @code{guix-daemon} executable would be labelled with
-- 
2.26.2

bug#44594: [PATCH v4] doc: add a note about relabling after upgrades to the

[Lars Ingebrigtsen]

Daniel Brooks <db48x@db48x.net> writes:

>>From b29749885c93811f901d0ec4e13de38f70f8c100 Mon Sep 17 00:00:00 2001
> From: Daniel Brooks <db48x@db48x.net>
> Date: Sat, 14 Nov 2020 08:04:30 -0800
> Subject: [PATCH v4] doc: add a note about relabling after upgrades to the
>  SELinux Support section of the manual
>
> * doc/guix.texi (SELinux Support): add note about upgrades

This mail ended up in the Emacs bug tracker, so it sounds like it was
sent to the wrong bug number?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#44594: [PATCH v4] doc: add a note about relabling after upgrades to the

[Daniel Brooks]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Daniel Brooks <db48x@db48x.net> writes:
>
>>>From b29749885c93811f901d0ec4e13de38f70f8c100 Mon Sep 17 00:00:00 2001
>> From: Daniel Brooks <db48x@db48x.net>
>> Date: Sat, 14 Nov 2020 08:04:30 -0800
>> Subject: [PATCH v4] doc: add a note about relabling after upgrades to the
>>  SELinux Support section of the manual
>>
>> * doc/guix.texi (SELinux Support): add note about upgrades
>
> This mail ended up in the Emacs bug tracker, so it sounds like it was
> sent to the wrong bug number?

Oops, I transposed two digits in the bug number. Sorry about the noise!

db48x

bug#44594: tabulated-list-mode: column header needlessly truncated

[Lars Ingebrigtsen]

[-- Attachment #1: Type: text/plain, Size: 953 bytes --]

Stefan Kangas <stefan@marxist.se> writes:

> The column header in tabulated-list-mode is needlessly truncated.
>
> Steps to reproduce:
>
> 0. emacs -Q
> 1. M-x list-buffers RET
> 2. C-x o
> 3. C-4 C-f
> 4. C-1 C-4 {
>
> Result: The header is truncated to "Buff..." even though there is enough
> space to show it all.
>
> Expected result: The header is not truncated.

The issue is basically this:

(truncate-string-to-width "Buffer" 5 nil nil t)
=> "Buff…"

Or...  Uhm...  Oh!  I've never noticed that the mode lets column overlap:

    ;; Truncate labels if necessary (except last column).
    ;; Don't truncate to `width' if the next column is align-right
    ;; and has some space left, truncate to `available-space' instead.
    (when (and not-last-col
	       (> label-width available-space))
      (setq label (truncate-string-to-width
		   label available-space nil nil t t)
	    label-width available-space))


[-- Attachment #2: Type: image/png, Size: 11110 bytes --]

[-- Attachment #3: Type: text/plain, Size: 284 bytes --]


So we allow column data to extend into the next column (if the next
column is right-aligned).  But we don't do the same computation in the
header?  Right.

Now fixed in Emacs 28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no