From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: Redisplay slower in Emacs 28 than Emacs 27 Date: Tue, 08 Dec 2020 00:02:06 +0100 Message-ID: <87r1o15ifl.fsf@gnus.org> References: <877dptiro7.fsf@gnus.org> <87pn3lhcdd.fsf@gnus.org> <878sa9hbe2.fsf@gnus.org> <877dptfvae.fsf@gnus.org> <83czzl8qwu.fsf@gnu.org> <87sg8h78s8.fsf@gnus.org> <87h7ox71xc.fsf@gnus.org> <874kkx6zwj.fsf@gnus.org> <87zh2p5ksl.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32030"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Gregory Heytings Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Dec 08 00:03:28 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kmPXU-0008Er-Hf for ged-emacs-devel@m.gmane-mx.org; Tue, 08 Dec 2020 00:03:28 +0100 Original-Received: from localhost ([::1]:44610 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmPXT-0006Us-Hb for ged-emacs-devel@m.gmane-mx.org; Mon, 07 Dec 2020 18:03:27 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43524) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmPWP-000643-Dg for emacs-devel@gnu.org; Mon, 07 Dec 2020 18:02:23 -0500 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:32876) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmPWH-0002Nb-JX; Mon, 07 Dec 2020 18:02:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=zaeGKCui97Pnkjez8nA731IHdU7sKyrxapr+TPY3LMw=; b=BcOkPXmy0evWVI08SxtgjzEuiF PZVfq7psASYpZf3HRNN0QmJtHVOdsiUIVsrBkgtQ6IjIKD1a9u227F4DuuAveFrIddR8Ra2EinOgt TeCZJEdlblAstHHimr2TPPnV8xm751vpDmsHJQDmLu6vXWDZI4FooqftDCxAiIRO5KpM=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kmPWB-0002n3-VO; Tue, 08 Dec 2020 00:02:10 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEX7bDxOZ1OdqVDV c0b/////GX2jAAAAAWJLR0QEj2jZUQAAAAd0SU1FB+QMBxcBHXpSzuEAAAGVSURBVDjLdZOJsYUg DEUjNGBIA4INgPTf279Z0Lf9zDg6OWS7QSLixjRK3Tc2K3POTrAsdFGlxMnBiUddlKS1dozO2YG+ JDHRaGaFCY7KZRNN/AB8Vt4Ty7bDpeAyt4MDhwEq+ggAQ2u8Uy4ZJ4aCdIOKbpKgw1EVtFq8CABG QmnS5gDCcJBtBHu9gfofGFx/g9yHgjoWKKUWDALdDFjM8Q2yAiGdQ0EzsKl+mJw7PQMOXQFm3KCL gah+KkAyjQjgId3BJlDLU3lIFQfptDkdaAyzAzK5F5g0xwLTTTuxyKSzko+iV0WBXhel2uxJcSVW XvQ/repxa+jVPRsuR6EUwOrotm0sPDkAzl7NiqmimXfflwFLDZ+1GIvSz2YLxcWxLoS2AEUB0jsY UR0N7ewgyQcQA4f+Dib7Armw3xorriCKX7zE0Tq0RifiMDhk4nfqn0BcPgnPA9gV7yFvN3AMP3uV vhZiB6KRw5XmB/RXcC2QNMcD4me3iAXEr+I3KFja4BtcD7i90e4N6hsoLxHtNtPtt/0BL0RR8q+q zVgAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjAtMTItMDdUMjM6MDE6MjkrMDA6MDCEbSLDAAAAJXRF WHRkYXRlOm1vZGlmeQAyMDIwLTEyLTA3VDIzOjAxOjI5KzAwOjAw9TCafwAAAABJRU5ErkJggg== X-Now-Playing: Sacred Paws's _Run Around The Sun_: "Brush Your Hair" In-Reply-To: (Gregory Heytings's message of "Mon, 07 Dec 2020 22:56:27 +0000") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:260533 Archived-At: Gregory Heytings writes: > Hmmm... this fails with: > > Loading /home/ghe/local/src/emacs/lisp/indent.el (source)... > Loading /home/ghe/local/src/emacs/lisp/emacs-lisp/cl-generic.el (source).= .. > Eager macro-expansion failure: (void-variable image-load-path) > Eager macro-expansion failure: (void-variable image-load-path) > Eager macro-expansion failure: (void-variable image-load-path) > Eager macro-expansion failure: (void-variable image-load-path) > Eager macro-expansion failure: (void-variable image-load-path) > Eager macro-expansion failure: (void-variable image-load-path) > Eager macro-expansion failure: (void-variable image-load-path) > Eager macro-expansion failure: (void-variable image-load-path) > Symbol=E2=80=99s value as variable is void: image-load-path Hm. Does adding a (require 'image) help? Like this: diff --git a/lisp/tool-bar.el b/lisp/tool-bar.el index 8456216430..2d929214d5 100644 --- a/lisp/tool-bar.el +++ b/lisp/tool-bar.el @@ -141,6 +141,8 @@ tool-bar-add-item To define items in any other map, use `tool-bar-local-item'." (apply #'tool-bar-local-item icon def key tool-bar-map props)) =20 +(require 'image) + (defun tool-bar--image-expression (icon) "Return an expression that evaluates to an image spec for ICON." (let* ((fg (face-attribute 'tool-bar :foreground)) @@ -154,12 +156,12 @@ tool-bar--image-expression (concat icon ".pbm")) colors)) (xbm-spec (append (list :type 'xbm :file (concat icon ".xbm")) colors))) - `(find-image (cond ((not (display-color-p)) - ',(list pbm-spec xbm-spec xpm-lo-spec xpm-spec)) - ((< (display-color-cells) 256) - ',(list xpm-lo-spec xpm-spec pbm-spec xbm-spec)) - (t - ',(list xpm-spec pbm-spec xbm-spec)))))) + `(cond ((not (display-color-p)) + ',(find-image (list pbm-spec xbm-spec xpm-lo-spec xpm-spec))) + ((< (display-color-cells) 256) + ',(find-image (list xpm-lo-spec xpm-spec pbm-spec xbm-spec))) + (t + ',(find-image (list xpm-spec pbm-spec xbm-spec)))))) =20 ;;;###autoload (defun tool-bar-local-item (icon def key map &rest props) --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no