From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#40109: 27.0.90; simple-delete-trailing-whitespace--bug-21766 fails if Git isn't installed Date: Thu, 28 Jan 2021 09:45:55 +0100 Message-ID: <87r1m5zby4.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34147"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 40109@debbugs.gnu.org To: Philipp Stephani Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 28 09:47:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l52xN-0008jM-BY for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 28 Jan 2021 09:47:13 +0100 Original-Received: from localhost ([::1]:56920 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l52xM-0004Gm-Ag for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 28 Jan 2021 03:47:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58072) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l52xC-0004Fk-GS for bug-gnu-emacs@gnu.org; Thu, 28 Jan 2021 03:47:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35632) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l52xC-0004dI-9G for bug-gnu-emacs@gnu.org; Thu, 28 Jan 2021 03:47:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l52xC-0007md-7z for bug-gnu-emacs@gnu.org; Thu, 28 Jan 2021 03:47:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 28 Jan 2021 08:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40109 X-GNU-PR-Package: emacs Original-Received: via spool by 40109-submit@debbugs.gnu.org id=B40109.161182356827124 (code B ref 40109); Thu, 28 Jan 2021 08:47:02 +0000 Original-Received: (at 40109) by debbugs.gnu.org; 28 Jan 2021 08:46:08 +0000 Original-Received: from localhost ([127.0.0.1]:47170 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l52wK-00072y-7W for submit@debbugs.gnu.org; Thu, 28 Jan 2021 03:46:08 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:59894) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l52wH-0006v3-Rv for 40109@debbugs.gnu.org; Thu, 28 Jan 2021 03:46:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=WhMbx5vG5T14n8FbVldSaOiOvXawIz+U25ERe77utZ4=; b=dmNro8HA4GNZzSmu2T86tdgmr1 SMC/x4J2NziPGhFhdjWjzUegXFzmQ+oxNok8tVc91VgKl5xnuq+JIeo2szbqVfvy034HYxi+7LlBS BAyoYjx2k7WyHCKzX4SThMWLhWTMfgoZ6vAQaaWv3M9i90b3DZ9ZELRVje8+Ac9tsvrI=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l52w9-0006Br-2K; Thu, 28 Jan 2021 09:45:59 +0100 X-Now-Playing: The Raincoats's _Odyshape_: "Shouting Out Loud" In-Reply-To: (Philipp Stephani's message of "Tue, 17 Mar 2020 18:14:14 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:198770 Archived-At: Philipp Stephani writes: > Make sure that git isn't installed, e.g. by running 'apt remove git' on > a Debian system. Then, in the Emacs source test directory: > > $ make lisp/simple-tests SELECTOR=3Dsimple-delete-trailing-whitespace--bu= g-21766 > make[1]: Entering directory '/emacs/test' > GEN lisp/simple-tests.log > Running 1 tests (2020-03-17 18:07:31+0100, selector `simple-delete-traili= ng-whitespace--bug-21766') > Test simple-delete-trailing-whitespace--bug-21766 backtrace: > call-process("git" nil (t nil) nil "rev-parse" "--abbrev-ref" "HEAD" I'm unable to reproduce the error with the current emacs-27 branch (or on the trunk). I "apt remove git" first, and then: larsi@xo:~/src/emacs/emacs-27/test$ make lisp/simple-tests SELECTOR=3Dsimpl= e-delete-trailing-whitespace--bug-21766 make[1]: Entering directory '/home/larsi/src/emacs/emacs-27/test' ELC lisp/simple-tests.elc GEN lisp/simple-tests.log Running 1 tests (2021-01-28 09:43:24+0100, selector `simple-delete-trailing= -whitespace--bug-21766') passed 1/1 simple-delete-trailing-whitespace--bug-21766 (0.089470 sec) Ran 1 tests, 1 results as expected, 0 unexpected (2021-01-28 09:43:24+0100,= 0.089821 sec) make[1]: Leaving directory '/home/larsi/src/emacs/emacs-27/test' [...] > Ah, the problem is that with-demoted-errors uses > condition-case-unless-debug. More minimal example: > > $ emacs -Q -batch -eval '(let ((debug-on-error t)) (ignore-errors > (with-demoted-errors "%S" (error "foo"))))' > Debugger entered--Lisp error: (error "foo") > [=E2=80=A6] > > I think this behavior is very confusing. Both version.el and > trampver.el try to do the right thing, but that breaks in such a > situation. It is somewhat confusing, yes, but it's also pretty convenient in some circumstances. In any case, are you still seeing the reported test problem? --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no