bug#46783: Catch mistaken (query-replace "a" "a")

bug#46783: Catch mistaken (query-replace "a" "a")

[積丹尼 Dan Jacobson]

(query-replace "a" "a") should ask "Are you sure?"
Better yet: "Are you nuts?"...

So how could it happen?

Well, e.g.,
the user needs to replace some character with a similar character, all
through the document. So similar in fact that it is hard to tell the
difference.

Therefore emacs should be a good Samaritan and please "Refuse loudly to
do one big no-op that will make the user furious once he discovers he
meticulously did... *nothing at all*."

Imagine answering
ynnyynnnnnnyynynnnynyyyyynynyyyyyynnnnynnnynynynyny only to find out it was just a big
nnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnn !

So emacs should simply double check the strings before starting.

No the user can't always tell, no matter how hard he looks, if they are
the same or not.

One might say "well there are still some uses for replacing the same
thing with itself." No, wrong.

bug#46783: Catch mistaken (query-replace "a" "a")

[Lars Ingebrigtsen]

積丹尼 Dan Jacobson <jidanni@jidanni.org> writes:

> One might say "well there are still some uses for replacing the same
> thing with itself." No, wrong.

There is -- to remove text properties.

I'm not sure that's a compelling use case, though.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#46783: Catch mistaken (query-replace "a" "a")

[Robert Pluim]

>>>>> On Fri, 26 Feb 2021 09:57:09 +0100, Lars Ingebrigtsen <larsi@gnus.org> said:

    Lars> 積丹尼 Dan Jacobson <jidanni@jidanni.org> writes:
    >> One might say "well there are still some uses for replacing the same
    >> thing with itself." No, wrong.

    Lars> There is -- to remove text properties.

    Lars> I'm not sure that's a compelling use case, though.

I find the following quite useful:

(require 'char-fold)
(setq replace-char-fold t)
C-x 8 RET e1 RET
(goto-char (point-min)
M-x query-replace RET a RET a

Robert
-- 

bug#46783: Catch mistaken (query-replace "a" "a")

[Lars Ingebrigtsen]

Robert Pluim <rpluim@gmail.com> writes:

> I find the following quite useful:
>
> (require 'char-fold)
> (setq replace-char-fold t)
> C-x 8 RET e1 RET
> (goto-char (point-min)
> M-x query-replace RET a RET a

Right.  So there are at least two use cases for doing
(query-replace "a" "a"), so having `query-replace' query the user here
seems like it would be annoying.

So I'm closing this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#46783: [External] : bug#46783: Catch mistaken (query-replace "a" "a")

[Drew Adams]

> > One might say "well there are still some uses for
> > replacing the same thing with itself." No, wrong.
> 
> There is -- to remove text properties.

This.

It's also possible that someone wants to use
the query-replace dialog as a means of either
navigating or checking something at each
occurrence (e.g. looking at the context),
e.g., as an alternative to using Isearch or
`occur'.

Yes, there are other ways to accomplish such
aims, but each way to accomplish something
can have advantages and disadvantages.

bug#46783: Catch mistaken (query-replace "a" "a")

[Richard Stallman]

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

  > (query-replace "a" "a") should ask "Are you sure?"
  > Better yet: "Are you nuts?"...

Emacs should not say such mean things to users.
It should follow the Kind Communication Guidelines.

It could say, "Are you serious?"

But that has a flaw: it fails to say what the concrete issue is.  We
can't assume the user will figure this out from a vague expression of
doubt, whether kind or not.  Emavs must inform per.

So it could say, "FROM-STRING and TO-STRING are identical -- are you serious?"

-- 
Dr Richard Stallman
Chief GNUisance of the GNU Project (https://gnu.org)
Founder, Free Software Foundation (https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)

bug#46783: Catch mistaken (query-replace "a" "a")

[積丹尼 Dan Jacobson]

>>>>> "RMS" == Richard Stallman <rms@gnu.org> writes:

RMS> So it could say, "FROM-STRING and TO-STRING are identical -- are you serious?"

Excellent points.

And for those power users who really are always serious, there could be
a query-replace-skip-mental-health-check . Oops, I meant
query-replace-skip-identical-string-check,
or a dialog:

You have used identical strings for both FROM-STRING and TO-STRING.

Press:

b to blunder on ahead ("Don't question my logic. I have my reasons.")
! to blunder on ahead and remember this for the remainder of your days.
q to "quit while you are ahead."
x to always bomb out forever. No more late night cocktails.
d to launch the Emacs Eliza doctor program.
9 to call in a real doctor.
7 to show the Seven Signs of Senility checklist.

bug#46783: Catch mistaken (query-replace "a" "a")

[Richard Stallman]

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

  > Press:

  > b to blunder on ahead ("Don't question my logic. I have my reasons.")
  > ! to blunder on ahead and remember this for the remainder of your days.
  > q to "quit while you are ahead."
  > x to always bomb out forever. No more late night cocktails.
  > d to launch the Emacs Eliza doctor program.
  > 9 to call in a real doctor.
  > 7 to show the Seven Signs of Senility checklist.

Could you have this ready for release by April 1 -- with documentation?

-- 
Dr Richard Stallman
Chief GNUisance of the GNU Project (https://gnu.org)
Founder, Free Software Foundation (https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)

bug#46783: Catch mistaken (query-replace "a" "a")

[積丹尼 Dan Jacobson]

>>>>> "RMS" == Richard Stallman <rms@gnu.org> writes:
RMS> Could you have this ready for release by April 1 -- with documentation?

Wait, don't forget EmacsCare™!
EmacsCare™, on by default, monitors the user's keystrokes 24 hours a day for
signs of OldTimersDisease. Holding down keys too long, saliva dribbling
on the keyboard, etc. will all notify caretakers to check on the
grandperson.

Keyboard navigation errors, and bad cognitive choices, like "trading
apples for apples" also calculate in one's final score. Sent to
caretakers every month.

Though there is no cure yet for OldTimersDisease, EmacsCare™ is ready
for the Baby Boomers now reaching their golden years and worse.