From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Protesilaos Stavrou Newsgroups: gmane.emacs.bugs Subject: bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible) Date: Tue, 02 Mar 2021 07:47:58 +0200 Message-ID: <87r1kyrtrl.fsf@protesilaos.com> References: <87im9fgm27.fsf@protesilaos.com> <83mtyk1hq3.fsf@gnu.org> <87czzgbapt.fsf@protesilaos.com> <83lfe4192f.fsf@gnu.org> <83im9814oh.fsf@gnu.org> <87sg6po0yd.fsf_-_@protesilaos.com> <83czxt2fpd.fsf@gnu.org> <87h7m0n0em.fsf@protesilaos.com> <83v9agryuz.fsf@gnu.org> <87tupyw83e.fsf@protesilaos.com> <83zgzqncxx.fsf@gnu.org> <874khwn1qf.fsf@protesilaos.com> <603b8171.1c69fb81.aa664.7f40@mx.google.com> <87mtvoxsvs.fsf@protesilaos.com> <603b9b9d.1c69fb81.f37aa.cb7c@mx.google.com> <83eegz7xcx.fsf@gnu.org> <87o8g3exjv.fsf@protesilaos.com> <603d053a.1c69fb81.f4cb8.fb14@mx.google.com> <87h7luga3p.fsf@protesilaos.com> <87o8g2bg89.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29526"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Mauro Aranda , 45068@debbugs.gnu.org To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Mar 02 06:49:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lGxuB-0007XS-O2 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 Mar 2021 06:49:11 +0100 Original-Received: from localhost ([::1]:42416 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lGxuA-00016a-Jp for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 Mar 2021 00:49:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38352) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lGxu2-00016L-0a for bug-gnu-emacs@gnu.org; Tue, 02 Mar 2021 00:49:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39865) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lGxu1-00064f-Pk for bug-gnu-emacs@gnu.org; Tue, 02 Mar 2021 00:49:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lGxu1-0004zT-PJ for bug-gnu-emacs@gnu.org; Tue, 02 Mar 2021 00:49:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Protesilaos Stavrou Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Mar 2021 05:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45068 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 45068-submit@debbugs.gnu.org id=B45068.161466409119124 (code B ref 45068); Tue, 02 Mar 2021 05:49:01 +0000 Original-Received: (at 45068) by debbugs.gnu.org; 2 Mar 2021 05:48:11 +0000 Original-Received: from localhost ([127.0.0.1]:51411 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lGxtD-0004yO-B7 for submit@debbugs.gnu.org; Tue, 02 Mar 2021 00:48:11 -0500 Original-Received: from relay1-d.mail.gandi.net ([217.70.183.193]:26691) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lGxtA-0004xz-Lj for 45068@debbugs.gnu.org; Tue, 02 Mar 2021 00:48:09 -0500 X-Originating-IP: 94.46.225.161 Original-Received: from kronos (unknown [94.46.225.161]) (Authenticated sender: public@protesilaos.com) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 27CAC240002; Tue, 2 Mar 2021 05:48:00 +0000 (UTC) In-Reply-To: <87o8g2bg89.fsf@tcd.ie> (Basil L. Contovounesios's message of "Mon, 01 Mar 2021 23:34:46 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201184 Archived-At: On 2021-03-01, 23:34 +0000, "Basil L. Contovounesios" wrote: > Protesilaos Stavrou writes: > >> +--- > > I think this function deserves to be documented under > (info "(elisp) Custom Themes"), but... > >> +** New function 'require-theme'. >> +This function is used to load a theme or library stored in the >> +'custom-theme-load-path'. It is intended to work as a substitute for >> +'require' in those cases where that cannot be used. > > ...after trying for some time, I failed to do so coherently and am now > confused about the function's implementation and purpose (I'm sorry for > not raising these points sooner). No worries. I will try to asnwer and we can always amend things. > If require-theme is intended as an alternative to require that searches > custom-theme-load-path, then why does it sometimes delegate to > load-theme and prompt the user about unsafe themes? This mixes > lower-level library functionality with a higher-level user feature, and > the only deciding factor between the two is whether foo-theme.el or > foo.el exists on custom-theme-load-path, which seems a bit opaque. > > Wouldn't it be simpler/cleaner if load-theme was used only for the > foo-theme.el use case, and require-theme only for the foo.el use case? My idea was that there could be a future scenario where a derivative theme requires a basis and the two are both declared as 'deftheme'. So they would blend together. Otherwise yes, it would be simpler to keep things separate. > IOW, what is the use case for (require-theme 'modus-operandi)? Why not > just call (load-theme 'modus-operandi) instead, with the added > flexibility of specifying its optional arguments? I'm also curious > about the use case for require-theme's optional second argument. In my case (require-theme 'modus-operandi) would not be used. In the file modus-operandi-theme.el I now have (require 'modus-themes). The modus-themes.el is not a 'deftheme' in itself and 'require' cannot find it unless it is in the load-path. Emacs' directory etc/themes is not in the load-path, so (require-theme 'modus-themes) is meant to work around that constraint. > Do the Modus themes require the current dual behaviour of require-theme? > If not, then could require-theme be as simple as the following, or am I > being naive / missing something? > > (defun require-theme (feature &optional noerror) > (let ((load-path (custom-theme--load-path))) > (require feature nil noerror))) No the themes do not need that dual behaviour. And yes, your version works and I am happy with it: all I need is a 'require' that reads from etc/themes. Perhaps I should attach a preliminary patch with the themes so that you can inspect it? > BTW, do we need to warn anywhere that require-theme may unconditionally > load files from custom-theme-load-path, or somehow protect against this? That would be consistent with load-theme. > And does it matter if require-theme loads .elc files, given that its > purpose is to load supporting non-theme Lisp files? For this I am not sure. Whatever you think is appropriate. -- Protesilaos Stavrou protesilaos.com