From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#45474: Icomplete exhibiting in recursive minibuffer when it =?UTF-8?Q?shouldn=E2=80=99t?= Date: Fri, 16 Apr 2021 19:34:19 +0300 Organization: LINKOV.NET Message-ID: <87r1jatd34.fsf@mail.linkov.net> References: <3ed97a9c53e0a5d4fef8@heytings.org> <87fszrz21d.fsf@mail.linkov.net> <3ed97a9c530093aca93d@heytings.org> <7dee3f4235d331cab291@heytings.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1737"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: Dario Gjorgjevski , 45474@debbugs.gnu.org To: Gregory Heytings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Apr 16 19:43:21 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lXSUw-0000Jq-VF for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 16 Apr 2021 19:43:18 +0200 Original-Received: from localhost ([::1]:59174 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lXSUw-0008Ll-0c for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 16 Apr 2021 13:43:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48654) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lXRRq-0004YQ-B1 for bug-gnu-emacs@gnu.org; Fri, 16 Apr 2021 12:36:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58235) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lXRRq-0004dq-3m for bug-gnu-emacs@gnu.org; Fri, 16 Apr 2021 12:36:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lXRRq-0001zl-0C for bug-gnu-emacs@gnu.org; Fri, 16 Apr 2021 12:36:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 16 Apr 2021 16:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45474 X-GNU-PR-Package: emacs Original-Received: via spool by 45474-submit@debbugs.gnu.org id=B45474.16185909187621 (code B ref 45474); Fri, 16 Apr 2021 16:36:01 +0000 Original-Received: (at 45474) by debbugs.gnu.org; 16 Apr 2021 16:35:18 +0000 Original-Received: from localhost ([127.0.0.1]:41548 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXRR8-0001yq-3s for submit@debbugs.gnu.org; Fri, 16 Apr 2021 12:35:18 -0400 Original-Received: from relay1-d.mail.gandi.net ([217.70.183.193]:49307) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXRR5-0001yV-Fp for 45474@debbugs.gnu.org; Fri, 16 Apr 2021 12:35:16 -0400 X-Originating-IP: 91.129.111.204 Original-Received: from mail.gandi.net (m91-129-111-204.cust.tele2.ee [91.129.111.204]) (Authenticated sender: juri@linkov.net) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id AA8DB240007; Fri, 16 Apr 2021 16:35:07 +0000 (UTC) In-Reply-To: <7dee3f4235d331cab291@heytings.org> (Gregory Heytings's message of "Fri, 16 Apr 2021 00:03:18 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:204151 Archived-At: > @@ -2812,7 +2832,7 @@ read-number > - (let ((str (read-from-minibuffer > + (let ((str (read-from-minibuffer-simple Thanks for handling 'read-number', I use commands from the 'M-g' prefix map that read numbers in the completion minibuffer. > @@ -3052,8 +3072,8 @@ read-char-from-minibuffer > - (read-from-minibuffer prompt nil map nil > - (or history 'empty-history))) > + (read-from-minibuffer-simple prompt nil map nil > + (or history 'empty-history))) >… > @@ -3247,7 +3267,7 @@ y-or-n-p > - (str (read-from-minibuffer > + (str (read-from-minibuffer-simple I wonder do you really intend to replace all hundreds of read-from-minibuffer calls with read-from-minibuffer-simple? For example, I use 'query-replace' a lot in the completion minibuffer, but it's not fixed. To be able to narrow the fix to icomplete.el only, it's possible to check the value returned from (minibuffer-depth) before icomplete kicks in, and disable icomplete completions when the value is greater than it was when entered the first minibuffer initially, thus handling recursive minibuffers that don't provide completions. Or maybe simply disable previous icomplete when recursive minibuffer doesn't use completions.