From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "J.P." Newsgroups: gmane.emacs.bugs Subject: bug#47788: Add support for TLS client certificates to 'erc-tls' Date: Fri, 23 Apr 2021 05:31:46 -0700 Message-ID: <87r1j1chcd.fsf__28981.5146637679$1619181212$gmane$org@neverwas.me> References: <87fszsuqqh.fsf@gnu.org> <87zgxzn2ek.fsf@neverwas.me> <87h7k3mm6x.fsf@gnu.org> <87h7k1ysje.fsf@neverwas.me> <871rb1zv4m.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7199"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 47788-done@debbugs.gnu.org, emacs-erc@gnu.org To: Amin Bandali Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Apr 23 14:33:19 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lZuzm-0001fM-J4 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 23 Apr 2021 14:33:18 +0200 Original-Received: from localhost ([::1]:55322 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lZuzl-0004Pq-NA for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 23 Apr 2021 08:33:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51892) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lZuyY-0003zn-DM for bug-gnu-emacs@gnu.org; Fri, 23 Apr 2021 08:32:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53069) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lZuyY-0007en-5u for bug-gnu-emacs@gnu.org; Fri, 23 Apr 2021 08:32:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lZuyY-0002w5-1Z for bug-gnu-emacs@gnu.org; Fri, 23 Apr 2021 08:32:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "J.P." Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Apr 2021 12:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47788 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 47788-done@debbugs.gnu.org id=D47788.161918112011217 (code D ref 47788); Fri, 23 Apr 2021 12:32:01 +0000 Original-Received: (at 47788-done) by debbugs.gnu.org; 23 Apr 2021 12:32:00 +0000 Original-Received: from localhost ([127.0.0.1]:36382 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZuyW-0002uc-9U for submit@debbugs.gnu.org; Fri, 23 Apr 2021 08:32:00 -0400 Original-Received: from dal3relay28.mxroute.com ([64.40.27.28]:41285) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZuyV-0002pW-5x for 47788-done@debbugs.gnu.org; Fri, 23 Apr 2021 08:31:59 -0400 Original-Received: from filter004.mxroute.com ([149.28.56.236] filter004.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by dal3relay28.mxroute.com (ZoneMTA) with ESMTPSA id 178feb7060f000881b.001 for <47788-done@debbugs.gnu.org> (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Fri, 23 Apr 2021 12:31:50 +0000 X-Zone-Loop: 465987e0fc78569bfd330a23d12d0e98cb4945719b2b X-Originating-IP: [149.28.56.236] In-Reply-To: <871rb1zv4m.fsf@gnu.org> (Amin Bandali's message of "Thu, 22 Apr 2021 20:45:29 -0400") X-AuthUser: masked@neverwas.me X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:204735 Archived-At: Hey, guess we both missed this: @@ -505,18 +512,23 @@ erc-server-process-alive (memq (process-status erc-server-process) '(run open))))) ;;;; Connecting to a server -(defun erc-open-network-stream (name buffer host service) - "As `open-network-stream', but does non-blocking IO" - (make-network-process :name name :buffer buffer - :host host :service service :nowait t)) +(defun erc-open-network-stream (name buffer host service &rest parameters) + "Like `open-network-stream', but does non-blocking IO." + (let ((p (plist-put parameters :nowait t))) + (open-network-stream name buffer host service p))) ;; ^~~~~~~~ Need an apply #' here because ~~~~~~^ -(defun erc-server-connect (server port buffer) +(defun erc-server-connect (server port buffer &optional client-certificate) Turns out my silly tests for one of those unofficial #erc bugs (the azur12 one) caught it by failing (which means your patch magically fixed the issue!). Anyway, no rush; I doubt this really impacts anyone.