From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: Andrea Corallo via "Emacs development discussions."
<emacs-devel@gnu.org>
Cc: Richard Stallman <rms@gnu.org>,
Stefan Monnier <monnier@iro.umontreal.ca>,
Andrea Corallo <akrl@sdf.org>
Subject: Re: native-comp *Warnings* buffer
Date: Sun, 16 May 2021 14:25:28 -0700 [thread overview]
Message-ID: <87r1i6z7zr.fsf@ericabrahamsen.net> (raw)
In-Reply-To: <xjfwnryo37m.fsf@sdf.org> (Andrea Corallo via's message of "Sun, 16 May 2021 20:04:13 +0000")
Andrea Corallo via "Emacs development discussions."
<emacs-devel@gnu.org> writes:
> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>
>> Richard Stallman <rms@gnu.org> writes:
>>
>>> [[[ To any NSA and FBI agents reading my email: please consider ]]]
>>> [[[ whether defending the US Constitution against all enemies, ]]]
>>> [[[ foreign or domestic, requires you to follow Snowden's example. ]]]
>>>
>>> > I think "stealth" compilation performed opportunistically in the
>>> > background should indeed not display any warnings (by default).
>>>
>>> I understand the reason for saying that, but... would this mean that a
>>> compilation of that meaterial won't happen later? Is there a chance
>>> that you'll never see the warnings that compilation generates?
>>
>> This wouldn't affect the actual compilation at all. It could affect
>> whether the user sees the warnings or not, if we default to not popping
>> up the *Warnings* buffer. They might still go looking for the buffer, or
>> stumble upon it by accident, though.
>>
>> I've attached a patch that provides a 'silent option to
>> `native-comp-async-report-warnings-errors'. In this patch the default is
>> still t, though we could easily default to 'silent if that seems
>> desirable.
>
> Hi Eric,
>
> thanks for the patch, it sounds like a good idea.
>
> Just a small nit below otherwise LGTM.
>
>>>From 01516b21e71862f3496e3a1f75bb86d436afaa3b Mon Sep 17 00:00:00 2001
>> From: Eric Abrahamsen <eric@ericabrahamsen.net>
>> Date: Sat, 15 May 2021 09:36:05 -0700
>> Subject: [PATCH] Provide a 'silent option for
>> native-comp-asyncreport-warnings-errors
>>
>> * lisp/emacs-lisp/comp.el (native-comp-async-report-warnings-errors):
>> Set to 'silent to log warnings, but not pop up the *Warnings* buffer.
>> * lisp/emacs-lisp/comp.el (comp-accept-and-process-async-output):
>> Check value.
>> ---
>> lisp/emacs-lisp/comp.el | 29 +++++++++++++++++++----------
>> 1 file changed, 19 insertions(+), 10 deletions(-)
>>
>> diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el
>> index 3e7f17ef1c..8fa9dee1ed 100644
>> --- a/lisp/emacs-lisp/comp.el
>> +++ b/lisp/emacs-lisp/comp.el
>> @@ -148,8 +148,13 @@ native-comp-async-report-warnings-errors
>> environment, it is more sensitive to such omissions, and might be
>> unable to compile such Lisp source files correctly.
>>
>> -Set this variable to nil if these warnings annoy you."
>> - :type 'boolean
>> +Set this variable to nil to suppress warnings altogether, or to
>> +the symbol `quiet' to log warnings but not pop up the *Warnings*
> ^^^
> `silent'?
Whoops! I went back and forth on the symbol to use, and apparently
settled on "borth". Thanks.
I forgot to say, I only put this check on one of the three
`display-warning' call-sites in this file, because the others looked
like fairly specific situations that the user should be bothered about.
If they should all have it, I can do that, too.
Eric
next prev parent reply other threads:[~2021-05-16 21:25 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-13 19:59 native-comp *Warnings* buffer Eric Abrahamsen
2021-05-13 20:20 ` Eric Abrahamsen
2021-05-13 21:28 ` Andrea Corallo via Emacs development discussions.
2021-05-13 21:34 ` Eric Abrahamsen
2021-05-13 22:00 ` Eric Abrahamsen
2021-05-14 6:28 ` Eli Zaretskii
2021-05-14 2:30 ` T.V Raman
2021-05-14 6:42 ` Eli Zaretskii
2021-05-14 6:11 ` Eli Zaretskii
2021-05-14 15:44 ` Eric Abrahamsen
2021-05-14 16:23 ` Stefan Monnier
2021-05-14 16:46 ` Eric Abrahamsen
2021-05-14 16:54 ` Eric Abrahamsen
2021-05-15 5:33 ` Richard Stallman
2021-05-16 4:15 ` Eric Abrahamsen
2021-05-16 14:06 ` Jump to source of warning was " T.V Raman
2021-05-16 20:04 ` Andrea Corallo via Emacs development discussions.
2021-05-16 21:25 ` Eric Abrahamsen [this message]
2021-05-17 6:11 ` Andrea Corallo via Emacs development discussions.
2021-05-17 3:23 ` Richard Stallman
2021-05-17 6:16 ` Eli Zaretskii
2021-05-16 5:12 ` Stefan Monnier
2021-05-16 5:30 ` Eli Zaretskii
2021-05-16 6:03 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1i6z7zr.fsf@ericabrahamsen.net \
--to=eric@ericabrahamsen.net \
--cc=akrl@sdf.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.