From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Juri Linkov <juri@linkov.net>
Cc: 48456@debbugs.gnu.org
Subject: bug#48456: Revert Dired after copy/rename
Date: Fri, 21 May 2021 21:08:33 +0100 [thread overview]
Message-ID: <87r1hz3l4u.fsf@tcd.ie> (raw)
In-Reply-To: <87cztkuede.fsf@mail.linkov.net> (Juri Linkov's message of "Fri, 21 May 2021 21:32:29 +0300")
Juri Linkov <juri@linkov.net> writes:
>> It seems better to create a new option:
>>
>> diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el
>> index eb43ab187d..5df4d6b206 100644
>> --- a/lisp/dired-aux.el
>> +++ b/lisp/dired-aux.el
>> @@ -2065,6 +2065,24 @@ dired-create-files
>> +(defcustom dired-do-revert-buffer nil
>
> Now pushed to master and closed.
Thanks, but I now see:
Test dired-test-bug30624 condition:
(ert-test-failed
((should
(dired-do-create-files 'copy 'dired-copy-file "Copy" nil))
:form
(dired-do-create-files copy dired-copy-file "Copy" nil)
:value nil))
Should the 'should' be removed? AFAICT the return value of
dired-do-create-files is unspecified (and unused).
--
Basil
next prev parent reply other threads:[~2021-05-21 20:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-15 21:45 bug#48456: Revert Dired after copy/rename Juri Linkov
2021-05-19 16:18 ` Juri Linkov
2021-05-21 18:32 ` Juri Linkov
2021-05-21 20:08 ` Basil L. Contovounesios [this message]
2021-05-22 21:06 ` Juri Linkov
2021-05-24 11:04 ` Basil L. Contovounesios
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1hz3l4u.fsf@tcd.ie \
--to=contovob@tcd.ie \
--cc=48456@debbugs.gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.