From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#48824: 27.1; =?UTF-8?Q?Symbol=E2=80=99s?= function definition is void: gnus-info-set-read Date: Fri, 04 Jun 2021 11:55:46 +0200 Message-ID: <87r1hiymvx.fsf@gnus.org> References: <877djabgjf.fsf@bsb.me.uk> <8735typ895.fsf@ahungry.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37908"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 48824@debbugs.gnu.org, Ben Bacarisse To: Matthew Carter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jun 04 11:57:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lp6Zh-0009e0-BL for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 04 Jun 2021 11:57:09 +0200 Original-Received: from localhost ([::1]:41130 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lp6Zg-0007Qi-EA for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 04 Jun 2021 05:57:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48304) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lp6Za-0007QO-1H for bug-gnu-emacs@gnu.org; Fri, 04 Jun 2021 05:57:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33873) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lp6ZZ-0004Gx-Q5 for bug-gnu-emacs@gnu.org; Fri, 04 Jun 2021 05:57:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lp6ZZ-0001zu-O3; Fri, 04 Jun 2021 05:57:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Fri, 04 Jun 2021 09:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48824 X-GNU-PR-Package: emacs,gnus Original-Received: via spool by 48824-submit@debbugs.gnu.org id=B48824.16228005697589 (code B ref 48824); Fri, 04 Jun 2021 09:57:01 +0000 Original-Received: (at 48824) by debbugs.gnu.org; 4 Jun 2021 09:56:09 +0000 Original-Received: from localhost ([127.0.0.1]:45412 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lp6Yf-0001yG-9z for submit@debbugs.gnu.org; Fri, 04 Jun 2021 05:56:09 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:60894) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lp6YZ-0001xe-PL for 48824@debbugs.gnu.org; Fri, 04 Jun 2021 05:56:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=3SBEqCYdGvdDm1o8eVibWfjv0+lnlNtRFb1Hitc9c98=; b=i7yHQfhMS3BQxK19aEfIfE+GvC ticADXfFvmekME83bBLnxuc4CD2oshWf4/PQq6y6IUHVbu5oLNEsvECtnTubb5Y+BKP+0MRk6uc1H tpVevoORgf2H45d6y2ttpV+JJGbyP36DkVhM9LOTrPdN56JGtEGYJQHdDaBVTEPEhuNM=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lp6YP-00044R-0w; Fri, 04 Jun 2021 11:55:53 +0200 X-Now-Playing: Rhoda with The Special AKA's _Make More Noise (3)_: "The Boiler" In-Reply-To: <8735typ895.fsf@ahungry.com> (Matthew Carter's message of "Fri, 04 Jun 2021 00:24:22 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:207994 Archived-At: Matthew Carter writes: > Ben Bacarisse writes: > >> After upgrading to 27.1 my Gnus home-grown backend fails with >> >> Symbol=E2=80=99s function definition is void: gnus-info-set-read >> >> If I comment out the one use of this function I can start Gnus but, of >> course, the maintenance of the read messages no longer works. >> >> The associated "getter" function (gnus-info-read) works, as does the >> related "setter" function gnus-into-set-marks. > > Looks like this changed towards end of 2019 to swap from macros to > inlined functions, and you can now use setf directly, vs a setter: > > https://git.savannah.gnu.org/cgit/emacs.git/tree/ChangeLog.3#n9403 Yes, the accessor macros should have been retained for backwards compatibility (but marked as obsolete) to avoid breaking out-of-tree code. But that sail has shipped (since Emacs 27.1 was released without those macros), so unfortunately all external code has to be adjusted to use the new syntax. Fortunately, that shouldn't be difficult -- just rewrite calls like (gnus-info-set-read info range) to (setf (gnus-info-read info) range) There isn't going to be any further Emacs 27 releases, so we can't reintroduce the removed setter macros, either, so I'm closing this bug report. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no