From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#21440: 25.0.50; Manual: FEATURE-unload-hook in (info "(elisp) Coding Conventions") Date: Thu, 08 Jul 2021 15:55:01 +0200 Message-ID: <87r1g8syfe.fsf@gnus.org> References: <87k2rzakd3.fsf@web.de> <871rk5le0t.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16439"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Michael Heerdegen , 21440@debbugs.gnu.org, Stefan Kangas To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 08 15:56:26 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m1UVu-00043z-UM for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 08 Jul 2021 15:56:26 +0200 Original-Received: from localhost ([::1]:33980 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m1UVt-0007Yy-RK for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 08 Jul 2021 09:56:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58402) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1UVW-0007Yc-IV for bug-gnu-emacs@gnu.org; Thu, 08 Jul 2021 09:56:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45512) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m1UVW-0005f7-Ah for bug-gnu-emacs@gnu.org; Thu, 08 Jul 2021 09:56:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m1UVW-0006JY-B6 for bug-gnu-emacs@gnu.org; Thu, 08 Jul 2021 09:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 08 Jul 2021 13:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21440 X-GNU-PR-Package: emacs Original-Received: via spool by 21440-submit@debbugs.gnu.org id=B21440.162575252823600 (code B ref 21440); Thu, 08 Jul 2021 13:56:02 +0000 Original-Received: (at 21440) by debbugs.gnu.org; 8 Jul 2021 13:55:28 +0000 Original-Received: from localhost ([127.0.0.1]:56379 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m1UUy-00068C-Co for submit@debbugs.gnu.org; Thu, 08 Jul 2021 09:55:28 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:35260) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m1UUw-0005u7-4f for 21440@debbugs.gnu.org; Thu, 08 Jul 2021 09:55:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=MG3ulq6OHE1pfHGHHISnYbqo5zesJdMCOS9kwQ+Znpo=; b=JqIiq11wCcWj+ykTnXyrR5HGMt 5Bo9xEgtK+zH7W0loXmNquZWag4OiNXcVxGy6rUKSBWfH0mHhbqhKo7AHn96dwGjPvNmliQSz7PGQ gLVIsu4jE6c9qdUJHhvkgv1j3TMYDgyYPYReLbwV/COKb83q/DqEHUJuxIARCzEf8GNQ=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m1UUc-0003Ia-Jr; Thu, 08 Jul 2021 15:55:09 +0200 X-Now-Playing: Yorkston, Thorne, Khan's _Navarasa: Nine Emotions_: "Westlin Winds" In-Reply-To: <871rk5le0t.fsf@gmx.de> (Michael Albinus's message of "Mon, 17 Aug 2020 13:15:14 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:209683 Archived-At: Michael Albinus writes: >>> =E2=80=A2 If loading the file adds functions to hooks, define a func= tion >>> =E2=80=98FEATURE-unload-hook=E2=80=99, where FEATURE is the name o= f the feature the >>> package provides, and make it undo any such changes. Using >>> =E2=80=98unload-feature=E2=80=99 to unload the file will run this = function. *Note >>> Unloading. [...] > As a test, I've renamed `tramp-unload-hook' and all > `tramp-FEATURE-unload-hook' variables to `tramp-unload-function' and > `tramp-FEATURE-unload-function', respectively. The related test, > `tramp-test45-unload', fails now. I haven't debugged further, but > throwing a warning when `FEATURE-unload-hook' is used, looks premature > to me. The quoted text no longer exists in Emacs 28 -- it now refers to -unload-function. Because: commit 8da810f91b11a258a7ed0f5315292143072881d8 Author: Eli Zaretskii AuthorDate: Mon Nov 7 19:39:54 2016 +0200 Commit: Eli Zaretskii CommitDate: Mon Nov 7 19:39:54 2016 +0200 Don't refer to obsolete FEATURE-unload-hook =20=20=20=20 * doc/lispref/tips.texi (Coding Conventions): Refer to FEATURE-unload-function rather than its obsolete variant FEATURE-unload-hook. (Bug#24890) But I don't know whether -unload-function has the same problems that -unload-hook had? And I see that there's still a lot of things called -unload-hook in Emacs... --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no