From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Benjamin Riefenstahl Newsgroups: gmane.emacs.bugs Subject: bug#49782: 28.0.50; set-fontset-font crashes in init (server) Date: Fri, 30 Jul 2021 19:50:37 +0200 Message-ID: <87r1ffk7wy.fsf@turtle-trading.net> References: <87mtq4rmh0.fsf@arrian.i-did-not-set--mail-host-address--so-tickle-me> <83eebfrixt.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37509"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) Cc: 49782@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 30 19:51:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m9WfA-0009cs-0w for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 30 Jul 2021 19:51:12 +0200 Original-Received: from localhost ([::1]:50542 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m9Wf8-0007HF-DI for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 30 Jul 2021 13:51:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52664) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m9Wf0-0007E6-Iq for bug-gnu-emacs@gnu.org; Fri, 30 Jul 2021 13:51:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49295) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m9Wf0-0002fu-7n for bug-gnu-emacs@gnu.org; Fri, 30 Jul 2021 13:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m9Wf0-0002bl-2Z for bug-gnu-emacs@gnu.org; Fri, 30 Jul 2021 13:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Benjamin Riefenstahl Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 30 Jul 2021 17:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49782 X-GNU-PR-Package: emacs Original-Received: via spool by 49782-submit@debbugs.gnu.org id=B49782.162766744510000 (code B ref 49782); Fri, 30 Jul 2021 17:51:02 +0000 Original-Received: (at 49782) by debbugs.gnu.org; 30 Jul 2021 17:50:45 +0000 Original-Received: from localhost ([127.0.0.1]:60841 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m9Wej-0002bE-3t for submit@debbugs.gnu.org; Fri, 30 Jul 2021 13:50:45 -0400 Original-Received: from odoacer.turtle-trading.net ([93.241.193.16]:39199) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m9Wei-0002b2-1x for 49782@debbugs.gnu.org; Fri, 30 Jul 2021 13:50:44 -0400 Original-Received: from zenobia.turtle-trading.net ([192.168.2.109]) by odoacer.turtle-trading.net with esmtp (Exim 4.80) (envelope-from ) id 1m9Web-0004m5-SW; Fri, 30 Jul 2021 19:50:37 +0200 Original-Received: from benny by zenobia.turtle-trading.net with local (Exim 4.92) (envelope-from ) id 1m9Web-0004qS-R4; Fri, 30 Jul 2021 19:50:37 +0200 In-Reply-To: <83eebfrixt.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 30 Jul 2021 17:10:38 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:210922 Archived-At: Hi Eli, Eli Zaretskii writes: > Does the patch below prevent the crash? > > diff --git a/src/fontset.c b/src/fontset.c > index 332be6c..52c7e38 100644 > --- a/src/fontset.c > +++ b/src/fontset.c > @@ -1356,6 +1356,9 @@ check_fontset_name (Lisp_Object name, Lisp_Object *frame) > int id; > struct frame *f = decode_live_frame (*frame); > > + if (!FRAME_WINDOW_P (f)) > + error ("Can't use fontsets in non-GUI frames"); > + > XSETFRAME (*frame, f); This works. At least it tells what the problem is. The error could even be caught. But what I actually want is probably display-multi-font-p, right? Thanks, benny