From: "João Távora" <joaotavora@gmail.com>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: mail@daniel-mendler.de, 48545@debbugs.gnu.org
Subject: bug#48545: 28.0.50; `icomplete-vertical-mode` does not support the `group-function`
Date: Thu, 19 Aug 2021 20:41:38 +0100 [thread overview]
Message-ID: <87r1epp6h9.fsf@gmail.com> (raw)
In-Reply-To: <54e4e409-5525-b796-9e9c-582735995cc1@yandex.ru> (Dmitry Gutov's message of "Thu, 19 Aug 2021 18:02:57 +0300")
Dmitry Gutov <dgutov@yandex.ru> writes:
> On 19.08.2021 14:18, João Távora wrote:
>> completion-all-sorted-completions in minibuffer.el if a table supplies
>> `group-function`. A patch for this is after my sig.
>
> We discussed this problem when group-function was introduced. Another
> approach is to just change the method of grouping: first the
> completions are sorted, and then they are sorted into groups.
That's a possiblity. But it might be performing too much work, at least
at first sight. For the C-x 8 RET case and the xref table (the only
tables I know which use this) things seem to be naturally put into
groups already. So sorting them alphabetically, by length, by history,
and _then_ destroying most (but not all) with the grouping could be not
so interesting if the there's a big a price to pay.
I recommend whatever is done that some quantitative benchmarking is
performed to the before/after. Enabling fido-vertical-mode and pressing
C-u C-x C-e C-m after
(benchmark-run (call-interactively 'insert-char))
Seems to be a decent way to measure.
Currently, with the alpha/length/history sorting, it takes about 1
second in my machine. Without any sorting (and the natural grouping),
takes about 0.6 seconds. You should measure what the re-grouping
sorting does.
João
next prev parent reply other threads:[~2021-08-19 19:41 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-20 18:56 bug#48545: 28.0.50; `icomplete-vertical-mode` does not support the `group-function` Daniel Mendler
2021-08-17 12:17 ` João Távora
2021-08-18 9:38 ` Kévin Le Gouguec
2021-08-18 9:55 ` João Távora
2021-08-19 11:18 ` João Távora
2021-08-19 12:38 ` Kévin Le Gouguec
2021-08-19 13:29 ` João Távora
2021-08-19 19:36 ` Kévin Le Gouguec
2021-08-19 15:02 ` Dmitry Gutov
2021-08-19 19:41 ` João Távora [this message]
2021-08-19 22:37 ` Dmitry Gutov
2021-08-19 23:39 ` João Távora
2021-08-19 23:51 ` Dmitry Gutov
2021-08-20 10:35 ` João Távora
2021-08-21 2:09 ` Dmitry Gutov
2021-08-21 9:40 ` João Távora
2021-08-21 12:01 ` Dmitry Gutov
2021-08-21 12:42 ` João Távora
2021-08-22 13:52 ` Dmitry Gutov
2021-08-22 15:44 ` João Távora
2021-08-21 0:24 ` João Távora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1epp6h9.fsf@gmail.com \
--to=joaotavora@gmail.com \
--cc=48545@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=mail@daniel-mendler.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.