From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Newsgroups: gmane.emacs.bugs Subject: bug#50179: [PATCH] Add support for "bright" ANSI colors to ansi-color and term-mode Date: Wed, 25 Aug 2021 09:06:35 +0200 Message-ID: <87r1eic8as.fsf@gmail.com> References: <838s0rvyfu.fsf@gnu.org> <83zgt6vi43.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2334"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Jim Porter , 50179@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 25 09:08:48 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mIn1j-0000SD-Mu for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 25 Aug 2021 09:08:47 +0200 Original-Received: from localhost ([::1]:39968 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mIn1i-0001jh-MQ for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 25 Aug 2021 03:08:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55374) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mIn02-00067x-OO for bug-gnu-emacs@gnu.org; Wed, 25 Aug 2021 03:07:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34008) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mIn02-0004qV-GY for bug-gnu-emacs@gnu.org; Wed, 25 Aug 2021 03:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mIn02-0002jo-Bo for bug-gnu-emacs@gnu.org; Wed, 25 Aug 2021 03:07:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Aug 2021 07:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50179 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 50179-submit@debbugs.gnu.org id=B50179.162987520410498 (code B ref 50179); Wed, 25 Aug 2021 07:07:02 +0000 Original-Received: (at 50179) by debbugs.gnu.org; 25 Aug 2021 07:06:44 +0000 Original-Received: from localhost ([127.0.0.1]:45554 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mImzk-0002jF-9O for submit@debbugs.gnu.org; Wed, 25 Aug 2021 03:06:44 -0400 Original-Received: from mail-wr1-f53.google.com ([209.85.221.53]:47038) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mImzj-0002iz-5d for 50179@debbugs.gnu.org; Wed, 25 Aug 2021 03:06:43 -0400 Original-Received: by mail-wr1-f53.google.com with SMTP id f5so34757643wrm.13 for <50179@debbugs.gnu.org>; Wed, 25 Aug 2021 00:06:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=wpRiMrDQ7Vi4o5u2T1H6oE1NSjTz3HMTMDi95loYP18=; b=UYxR9z7owTYxd7plXxfcEyb7I26qFjbyzF5Cb4O2GhzRtNd4VDPpobqNqWO+MOok30 N1IfUXdyGZNOXO6Ht51TAs6asIkBp2MprqpseWuP+fr18BZavXqNBlxYSnJKK14O0P9n j4JdDoDF4lFOUBMhWaaPY2qNmNsRQUxNhVYREzjzVtPVDbAr0dHyaYXMoxuTqCT9tD7r t85VSAMkAg84c8zCNvdVYEK4vSHf3KVYVDfMib5IP9xm+XLVOVItp8LsOBq+3BKlrQ9R s8oWwe/vVEYv+myoxMYzBHevxAgMiPXIe9EJGlkGbmQI135m4TZu2kv+eldDK6RElUCF cujQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=wpRiMrDQ7Vi4o5u2T1H6oE1NSjTz3HMTMDi95loYP18=; b=qQO9iqmpDOhj07jTSEMhyqlMvKsRSiXSj04VQH+O3sZukSLxupk/E+FVBTGxX7o1aI jARzuyOWDda7EYh/5C7M+fxE8yB0hS1YM7Gbi1qepwLI7PfJ1wHN2QRejnKkhV3mgSJ2 vQbAa/oIzIEeOZShGe+/Toqz5oa6FY/qiYKAcHEc8ge3nxg4hD6vYuDw5gX6ztu7CW6Z BemLosC19CusrrSyyU/ysBY5o737zdy1NA3pGw4YWl9B4XA7+PPqH+985jlRWMDk2j7f 3vtMCccBMkiC+YZ7MSzBgqj0+Qg9GDHY4Jj39FR69tzkb5rSscaxR9HrephqhCSW2VG4 IJ1Q== X-Gm-Message-State: AOAM532BnCCZvn2XP/miA1ONuDHU0vpVBf/ArKGSSoABhl20qVGdXqz/ jvtbvvodEBQEtVTL9tjm9ILYtePKU8o= X-Google-Smtp-Source: ABdhPJxgtPG2MdgIb7CGetDiVP8gdrREtISuqBqkRfQ4pd2FDEoON4MUAxXFmEzluO3BEWlM9j5MEA== X-Received: by 2002:a5d:500d:: with SMTP id e13mr18496035wrt.413.1629875197028; Wed, 25 Aug 2021 00:06:37 -0700 (PDT) Original-Received: from amdahl30 ([2a01:e0a:20e:d340:2ef0:5dff:fed2:7b49]) by smtp.gmail.com with ESMTPSA id n8sm3959979wmq.18.2021.08.25.00.06.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Aug 2021 00:06:36 -0700 (PDT) In-Reply-To: <83zgt6vi43.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 24 Aug 2021 20:59:40 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:212584 Archived-At: Eli Zaretskii writes: >> > I wouldn't offer a customizable list for this: users have no >> > particular reason to redefine standard colors. >> >> I made this a defcustom because `ansi-color-faces-vector' and >> `ansi-color-names-vector' are defcustoms too. More practically >> speaking, I'd want to customize this new variable to make these colors >> match the Emacs theme I use. I chose colors in this patch to >> complement `ansi-color-names-vector', but they'd clash with my theme. > > How can named colors change with the theme? Faces can, but colors are > absolute. Bright-yellow is the same color whatever the theme. At > least IMO. I wonder if others think otherwise. FWIW, a couple of Emacs's built-in themes set these ansi-color options. See e.g. the Modus themes, which are designed to meet WCAG's highest standards for colour contrast. Maybe there's an analogy to make with terminal emulators? Most of those (e.g. Konsole, Terminator, Xfce's) allow the user to customize the 16-color palette. Digging into the history of this 4-bit palette[1], it almost seems like no two consoles ever used the exact same colors, so these color names might not be as absolute as say, HTML color names[2]. [1] https://en.wikipedia.org/wiki/ANSI_escape_code#Colors [2] https://en.wikipedia.org/wiki/Web_colors#HTML_color_names