From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#32496: 27.0.50; Strange indentation when ruby-align-chained-calls is t Date: Wed, 01 Sep 2021 11:53:16 +0200 Message-ID: <87r1e8ei5v.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30149"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 32496@debbugs.gnu.org, Artur Malabarba , Dmitry Gutov To: Bozhidar Batsov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 01 11:54:55 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mLMxJ-0007UN-WF for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 01 Sep 2021 11:54:54 +0200 Original-Received: from localhost ([::1]:46840 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mLMxI-00052u-Ho for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 01 Sep 2021 05:54:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35296) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mLMwT-0003bm-Tj for bug-gnu-emacs@gnu.org; Wed, 01 Sep 2021 05:54:01 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53055) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mLMwT-0002Ua-Lg for bug-gnu-emacs@gnu.org; Wed, 01 Sep 2021 05:54:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mLMwT-00074X-Jo for bug-gnu-emacs@gnu.org; Wed, 01 Sep 2021 05:54:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 01 Sep 2021 09:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32496 X-GNU-PR-Package: emacs Original-Received: via spool by 32496-submit@debbugs.gnu.org id=B32496.163049001127145 (code B ref 32496); Wed, 01 Sep 2021 09:54:01 +0000 Original-Received: (at 32496) by debbugs.gnu.org; 1 Sep 2021 09:53:31 +0000 Original-Received: from localhost ([127.0.0.1]:36368 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mLMvy-00073l-Le for submit@debbugs.gnu.org; Wed, 01 Sep 2021 05:53:30 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:58502) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mLMvw-00073W-6W for 32496@debbugs.gnu.org; Wed, 01 Sep 2021 05:53:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=XsxhOs3vghiRBym6sUyfhnxcHHOgNZxd3/lgE7rBsso=; b=bls/s+b5PKaDICM5zO3q2Zi2sV LoInUAfpp43EuethIfJbocFMTkuaT85ibT6e8bskADC9wS6TjqNxDQHN67utNf5M2vs9oueyowgmW K39cCJYNuGyRP8rJfU8V6X4HRwlK+QhfSHIJjA4ws81MWmqaEGM/T4gwzlF/AqcKKB48=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mLMvl-0002RU-DY; Wed, 01 Sep 2021 11:53:21 +0200 In-Reply-To: (Bozhidar Batsov's message of "Sun, 18 Nov 2018 09:36:17 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:213165 Archived-At: Bozhidar Batsov writes: > Sorry for the radio silence - I've been super busy lately. > > It's hard for me to understand the indentation in the examples in the email > (as it seems the same to me). Very simply put - the idea is to align multi-line > chained calls on the `.`, as opposed to just nest them under the root receiver > as we'd normally do. > > I think Dmitry implemented this great and it's behaving just as it's supposed > to be behaving. Perhaps you misunderstood how this was supposed to > behave? What's the indentation you expected? (I'm going through old bug reports that unfortunately weren't resolved at the time.) The examples were in HTML mail, so they were difficult to understand. Emacs (with (setq ruby-align-chained-calls t)) currently aligns like this: some_variable.where .not(x: nil) .where(y: 2) Which is correct. However, when there's a mixture of keeping things on one line and breaking, we get this: some_variable.where.not(x: nil) .where(y: 2) I think the bug reporter wants: some_variable.where.not(x: nil) .where(y: 2) I.e., align multiline chained calls on the first dot, not the last? (I don't know Ruby, so I have no opinion here.) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no