From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: Entering emojis Date: Wed, 27 Oct 2021 17:12:16 +0200 Message-ID: <87r1c6y01b.fsf@gmail.com> References: <87cznths5j.fsf@gnus.org> <83zgqxymd3.fsf@gnu.org> <878rygj4gt.fsf@gnus.org> <83wnm0zz0q.fsf@gnu.org> <874k94j3rn.fsf@gnus.org> <83v91kzydh.fsf@gnu.org> <87tuh4holf.fsf@gnus.org> <822aec9d01909cecfc6c@heytings.org> <87a6iwhltf.fsf@gnus.org> <83tuh4zfg5.fsf@gnu.org> <87y26gfobr.fsf@gnus.org> <87tuh4f1ie.fsf@gnus.org> <83tuh2wuwa.fsf@gnu.org> <87pmrqod9f.fsf@gmail.com> <87wnlymx96.fsf@gmail.com> <83ee86wpz1.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33543"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, emacs-devel@gnu.org, gregory@heytings.org, stefankangas@gmail.com To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Oct 27 17:53:26 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mflEz-0008VJ-Nf for ged-emacs-devel@m.gmane-mx.org; Wed, 27 Oct 2021 17:53:25 +0200 Original-Received: from localhost ([::1]:45944 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mflEy-00009n-If for ged-emacs-devel@m.gmane-mx.org; Wed, 27 Oct 2021 11:53:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58456) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mfkbG-00083a-EF for emacs-devel@gnu.org; Wed, 27 Oct 2021 11:12:23 -0400 Original-Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]:33540) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mfkbE-0007YX-D6; Wed, 27 Oct 2021 11:12:22 -0400 Original-Received: by mail-wr1-x433.google.com with SMTP id m22so4837612wrb.0; Wed, 27 Oct 2021 08:12:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version; bh=tcLSUzMglo6Q+pIeeofpQiKILGDRYliPRurc3ODLr9M=; b=BnhDltbQ9gq8T3SLK6DkWI7vLItqPRxeyZpOKooQH9WoHK3+aHRjjyBotOr6rd2K91 bZ4f0qRL/uTL7pC0p94MC+q856xXqopwapGiW4lh1UwaSwd6Z54zmyfLdsbd6LbuG2RQ zKjlCbPDRN+FsozhZVtoVyGI6yQF4Bo4517sVWWsuqT6IRelFSGXT8UsHHg3H2Pp1DV9 eg7qcGOM6l70gFH8sFgNP4hmTTNhQtHkAzENtdo0dvQ8Mr8ptRiytlOtEpuT24oMq59C 7/4IYOwf5+jJ1ZmSQZ4S3jpy9Gd71my+XnM9/jkWBm0KAeES5yfmHmD3+S0/dKJF5+Wp a+2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version; bh=tcLSUzMglo6Q+pIeeofpQiKILGDRYliPRurc3ODLr9M=; b=je3akT/aIn5tUke1YD2/xB0flhFUG6YtLZn/G6VjDh/2C0KZNOQC9yElInoB1NyGZR k3692kU6JbEps2xYsovN6r0srmR063UjTpIqkwDrMOfPaNTVkif/eVEFOxvcGhVVnuaG +aHIjtNBhjjxdCxe6Lm2PeSXoxJlraaV3NcWHqGne7NarMOP1LpICOZx7QwRXb9SyB5K 97x3Qtyc+BJygx3E0PAKB002DnmFSybSUEeQv+7m4XHS9VUOvGFQ8AlfCCjLjop928hH paEbC7ERHqDV/qrHNkQeCsXyrb3Dsdt/N7692RLmUDWkdsDXZl48rQt3XoFVzXM+G4/X 3kiw== X-Gm-Message-State: AOAM530zQLY52EbKQbQPD3GhkyWXNuzFf036xG8O5Q5uxLwKXyxnUyFX VEwW8XZbsYlA4o1REfIDXdNdd0e4uA8= X-Google-Smtp-Source: ABdhPJzdmP8fgrx98J8KJbJGryG0JF/A5WZHmMBSljMiiitGnXtcctVzG/tZIKz51Ln7yWym/kEtWw== X-Received: by 2002:adf:a2d7:: with SMTP id t23mr42415068wra.156.1635347537501; Wed, 27 Oct 2021 08:12:17 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id w10sm119590wrq.88.2021.10.27.08.12.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Oct 2021 08:12:17 -0700 (PDT) In-Reply-To: <83ee86wpz1.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 27 Oct 2021 16:34:58 +0300") Received-SPF: pass client-ip=2a00:1450:4864:20::433; envelope-from=rpluim@gmail.com; helo=mail-wr1-x433.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:277987 Archived-At: >>>>> On Wed, 27 Oct 2021 16:34:58 +0300, Eli Zaretskii said: >> Anyway, if I delete the above, Apple Color Emoji is used for emoji. Eli> Do we have the 'emoji' script in AREF (spec, FONT_EXTRA_INDEX) in that Eli> function, when Emacs is looking for a font to display Emoji? If so, Eli> we could refrain from the above condition only when a font for Emoji Eli> is being sought, and that could be safe enough for the release branch. Yes. This seems to work so far. diff --git a/src/macfont.m b/src/macfont.m index d86f09f485..78ed5d53f3 100644 --- a/src/macfont.m +++ b/src/macfont.m @@ -2415,8 +2415,12 @@ So we use CTFontDescriptorCreateMatchingFontDescriptor (no continue; /* Don't use a color bitmap font unless its family is - explicitly specified. */ - if ((sym_traits & kCTFontTraitColorGlyphs) && NILP (family)) + explicitly specified or we're looking for a font for + emoji. */ + if ((sym_traits & kCTFontTraitColorGlyphs) + && NILP (family) + && !EQ (CDR_SAFE (assq_no_quit (QCscript, AREF (spec, FONT_EXTRA_INDEX))), + Qemoji)) continue; if (j > 0 Robert --