all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Robert Pluim <rpluim@gmail.com>
To: emacs-devel@gnu.org
Cc: Stefan Kangas <stefan@marxist.se>
Subject: Re: master cff1702: Fix hanging wdired test
Date: Mon, 15 Nov 2021 12:14:08 +0100	[thread overview]
Message-ID: <87r1bhbri7.fsf@gmail.com> (raw)
In-Reply-To: <20211115084515.88275207D5@vcs0.savannah.gnu.org> (Stefan Kangas's message of "Mon, 15 Nov 2021 03:45:15 -0500 (EST)")

>>>>> On Mon, 15 Nov 2021 03:45:15 -0500 (EST), stefankangas@gmail.com (Stefan Kangas) said:
    Stefan> @@ -148,11 +145,12 @@ wdired-get-filename before and after editing."
    Stefan>                (set-file-modes "foo" (file-modes-symbolic-to-number "+x"))
    Stefan>                (make-symbolic-link "foo" "bar")
    Stefan>                (make-directory "foodir")
    Stefan> -              (require 'dired-x)
    Stefan>                (dired-smart-shell-command "mkfifo foopipe")
    Stefan> -              (server-force-delete)
    Stefan> -              ;; FIXME?  This seems a heavy-handed way of making a socket.
    Stefan> -              (server-start)             ; Add a socket file.
    Stefan> +              (setq proc (make-network-process
    Stefan> +                          :name "foo"
    Stefan> +                          :family 'local
    Stefan> +                          :server t
    Stefan> +                          :service (expand-file-name "foosocket" test-dir)))

Not every platform supports local sockets, so you might want to
condition the socket on

   (featurep 'make-network-process '(:family local)))

in there somewhere. (MS-Windows uses TCP sockets for `server-start',
so there will be no change on that platform anyway)

Robert
-- 



       reply	other threads:[~2021-11-15 11:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20211115084514.28560.821@vcs0.savannah.gnu.org>
     [not found] ` <20211115084515.88275207D5@vcs0.savannah.gnu.org>
2021-11-15 11:14   ` Robert Pluim [this message]
2021-11-15 13:14     ` master cff1702: Fix hanging wdired test Eli Zaretskii
2021-11-16  4:24       ` Stefan Kangas
2021-11-16 13:01         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r1bhbri7.fsf@gmail.com \
    --to=rpluim@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=stefan@marxist.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.