From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: The new keymap functions Date: Wed, 17 Nov 2021 08:36:23 +0100 Message-ID: <87r1bfp72g.fsf@gnus.org> References: <87zgq8sfw3.fsf@gnus.org> <86k0h8ts66.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21762"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Emacs developers To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Nov 17 08:37:39 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mnFVj-0005QT-Mz for ged-emacs-devel@m.gmane-mx.org; Wed, 17 Nov 2021 08:37:39 +0100 Original-Received: from localhost ([::1]:52678 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mnFVi-0002dk-Lh for ged-emacs-devel@m.gmane-mx.org; Wed, 17 Nov 2021 02:37:38 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:35616) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mnFUh-0001vM-A8 for emacs-devel@gnu.org; Wed, 17 Nov 2021 02:36:35 -0500 Original-Received: from [2a01:4f9:2b:f0f::2] (port=52444 helo=quimby.gnus.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mnFUf-000249-EL for emacs-devel@gnu.org; Wed, 17 Nov 2021 02:36:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=L6MhVfzaahAvyYncBegu8DrB2T21sItdPuJlNRMDtvc=; b=hJLnOKQeXZZnwJwjHSbmZn7Dkm I5cBXgFEruNQMJmc1k00gg4WiV/GUdwXxt+qIRc1VZHG5JIOCK+f+wKp+oqR0VjhFCFplVXur+sY7 HYBDL5UuO0F+sgeUuRL5y/QGZ8e3JiS94EB3ARRMlWDIOeYdPsuwEs2vuLb8qx5Zas3o=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mnFUX-0005f9-5Q; Wed, 17 Nov 2021 08:36:28 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEVHP0cmQI6MenXR ycn////P/ekvAAAAAWJLR0QEj2jZUQAAAAd0SU1FB+ULEQcVOXjXWeMAAAG6SURBVDjLhVSJkeMw DEOoBtapgCYb0JH993YgJTvJ7t6ck/FkBOMhJAeP4/cLb8BZt+f5HXia2SlqP4ADX8DxeEk9/+VB wM2tLvUIS/4IX0A+w1QAyQxPFc888bDj+FMEAFywnGKZc5mL2bRNCHA9cTQDrkOUhCUUOQv4KvPJ AUYJNSGAJaVIqLWzGY30AgxDRZrAexE2ICoh2g7Fs3kBoDGtJY0jVC6xLSXUGrqihlXus4Hg1IGK mu18AwmDV1RfzhK6pJI6nKJnJgGkLsZInWBJmwCWvVOVIz9MxJbVBb4YzMOqqiSrxhIYGxgcSosg BspxogXQLkZwgc4sYMxxAz5HVNs1gyblLoBdpWclGjFY9g208qQ1XIIjvYDR5ZWHVy8bmF0PV9mf T38BVQMJYNiRTXhJYdT56ZpqPc59fPi0F29MtJIuwBi0jCmIJsy9tR4Vp9Y3YWJvlM82kFjrmeMl BfabNXO+paIvhYo3OtINWDuQt2aoTu45CAy9HPID6LFrhA9A+luHdAe7ALrM2vTaE//simmNu65L 7w1Q5XtYFX8zF/QLjSvYvR88+fWi70ku4H//Ph/XX9FVbhYgJO4MAAAAJXRFWHRkYXRlOmNyZWF0 ZQAyMDIxLTExLTE3VDA3OjIxOjU3KzAwOjAwlPRuVwAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMS0x MS0xN1QwNzoyMTo1NyswMDowMOWp1usAAAAASUVORK5CYII= X-Now-Playing: The Beatles's _1967-1970 (1)_: "I Am the Walrus" In-Reply-To: <86k0h8ts66.fsf@mail.linkov.net> (Juri Linkov's message of "Tue, 16 Nov 2021 22:14:41 +0200") X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a01:4f9:2b:f0f::2 (failed) Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:279610 Archived-At: Juri Linkov writes: > Whereas the name `defvar-keymap' is nice since it's a top-level macro, > `define-keymap' looks out of place in the same group of functions. > And indeed, such mismatch looks odd: > > (define-keymap "C-c C-c" #'quit-buffer) > (keymap-set map "C-c C-c" #'quit-buffer) > > What about renaming it to `keymap-define'? Then: > > (keymap-define "C-c C-c" #'quit-buffer) > (keymap-set map "C-c C-c" #'quit-buffer) I like that all the `keymap-*' functions take a map as the first parameter (except the commands that have the map "in the name", like `keymap-global-set'). And using `define-*' for a form that defines something (and has a (potentially) long body) is a very long-standing tradition in Emacs, so I'd prefer to keep it as is. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no