browse-url-interactive-arg calls `mouse-set-point' too eagerly

browse-url-interactive-arg calls `mouse-set-point' too eagerly

[Po Lu]

Selecting "Browse URL" from the xwidget-webkit menu bar results in the
following error:

  signal(error ("Position not in text area of window"))
  error("Position not in text area of window")
  posn-set-point(nil)
  mouse-set-point((menu-bar))
  browse-url-interactive-arg("xwidget-webkit URL: ")
  byte-code("\300\301!\210\302\303!\207" [require browse-url browse-url-interactive-arg "xwidget-webkit URL: "] 2)
  call-interactively(xwidget-webkit-browse-url nil nil)
  command-execute(xwidget-webkit-browse-url)

The doc string of browse-url-interactive-arg says:

  If invoked with a mouse button, it moves point to the position clicked
  before acting.

But the code treats any event that is a list as a mouse event, which
fails horribly with menu bar events.

So why not replace the faulty code with something like:

  (let ((event (elt (this-command-keys) 0)))
    (when (mouse-event-p event)
      (mouse-set-point event)))

WDYT?

Re: browse-url-interactive-arg calls `mouse-set-point' too eagerly

[Eli Zaretskii]

> From: Po Lu <luangruo@yahoo.com>
> Date: Sat, 20 Nov 2021 14:29:49 +0800
> 
> The doc string of browse-url-interactive-arg says:
> 
>   If invoked with a mouse button, it moves point to the position clicked
>   before acting.
> 
> But the code treats any event that is a list as a mouse event, which
> fails horribly with menu bar events.
> 
> So why not replace the faulty code with something like:
> 
>   (let ((event (elt (this-command-keys) 0)))
>     (when (mouse-event-p event)
>       (mouse-set-point event)))
> 
> WDYT?

SGTM, thanks.  Please do this on the emacs-28 branch, as I believe the
same problem exists there.

Re: browse-url-interactive-arg calls `mouse-set-point' too eagerly

[Po Lu]

Eli Zaretskii <eliz@gnu.org> writes:

> SGTM, thanks.  Please do this on the emacs-28 branch, as I believe the
> same problem exists there.

Done.  I don't have to install it separately on master, as it'll arrive
there the next time someone merges emacs-28 to master, correct?

Thanks.

Re: browse-url-interactive-arg calls `mouse-set-point' too eagerly

[Eli Zaretskii]

> From: Po Lu <luangruo@yahoo.com>
> Cc: emacs-devel@gnu.org
> Date: Sat, 20 Nov 2021 15:59:10 +0800
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > SGTM, thanks.  Please do this on the emacs-28 branch, as I believe the
> > same problem exists there.
> 
> Done.  I don't have to install it separately on master, as it'll arrive
> there the next time someone merges emacs-28 to master, correct?

Yes, correct.