From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master f52dcfd03a: New command `gnus-summary-browse-all-urls' bound to "v" Date: Tue, 15 Mar 2022 16:30:06 +0100 Message-ID: <87r173utc1.fsf@gnus.org> References: <164727172121.17436.14797611985358127835@vcs2.savannah.gnu.org> <20220314152841.8DC85C06305@vcs2.savannah.gnu.org> <87ilsfwiln.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2772"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Sam Steingold Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Mar 15 16:33:04 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nU9AV-0000UB-SW for ged-emacs-devel@m.gmane-mx.org; Tue, 15 Mar 2022 16:33:03 +0100 Original-Received: from localhost ([::1]:38716 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nU9AU-0002Gd-Lc for ged-emacs-devel@m.gmane-mx.org; Tue, 15 Mar 2022 11:33:02 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:40588) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nU97l-0008Le-D5 for emacs-devel@gnu.org; Tue, 15 Mar 2022 11:30:13 -0400 Original-Received: from [2a01:4f9:2b:f0f::2] (port=44928 helo=quimby.gnus.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nU97j-00011k-SY; Tue, 15 Mar 2022 11:30:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=aIEG2BOuFxuB13i5Fs1N3Mn39w/SSOOmL3WQT5uNbVE=; b=DCkZUdaIaflpTX54NGz5PrqlnD hmuw2xVhyeUFkbJnaWftKXXBk6WLuj6HZcy+hwamU3UMmlsB+/icewVfEINPv/EBmA4sgn/9PLcKa TiVcF0HRWzougvY15yemN6xS3DaMez2xsDj0tQSA4x6HNTy3qPiTufDnViwSUriGKHLA=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nU97e-0004V3-VK; Tue, 15 Mar 2022 16:30:08 +0100 In-Reply-To: (Sam Steingold's message of "Tue, 15 Mar 2022 11:26:56 -0400") Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAG1BMVEUOCxAjIiVGNzho Tk+dX1y8hnVqi524vab///8jAL3IAAAAAWJLR0QIht6VegAAAAd0SU1FB+YDDw8bOe5lPBYAAAGa SURBVDjLjZTBbsIwDIbtlgdw0sOuTaVtVxAbO6+gPQBS6BnQwgNMNK8/Owltoe00C6SkH79jp78B uAWSGgYMA6dA3GqttEHzoEDRECocpRqm7Db5bhA1YgcW23UXb3vsFYtykGsSZAIAJwA/q0cgM/Jh hYqXcQPo3An06Ix8s7l4L1nuQebswdtGlPvYoCJFDJ6tPbTWLxNIl4mL8t1a99MEUPdgJeDgrrtD eQey86L8ZoW/fh0D0AL4SyqmctfWXT6h1lVQhD7Mi5VcDFYdkNry1cZxsoYB3INT5i7cRutdAqTC xeRLKLz31ntHAQAaw4DyEvDD+2vTngG2AYBKAJ5Y4ttTAgqQf6wKBq8C/CmeQUhYsi0ErIPiWIXO CVQm5hQABV97u8woAgrtF9IlFFq6pZrfBy8MpFSdXevworJSvFf0rhLDcUmq0sSvPRhW3KyqqjIM jBw/tq88ooGJels/gNsquT1tQ+Vx1Y9BGomZGWRQhRgDkiw8bPQIdKqdHgvVYT4nQFf1DJhVwMyc /wHwv4r490NyM7+w2VaZMVe3QgAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMi0wMy0xNVQxNToyNzo1 NyswMDowMMuy/7kAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjItMDMtMTVUMTU6Mjc6NTcrMDA6MDC6 70cFAAAAAElFTkSuQmCC X-Now-Playing: Chris & Cosey's _Songs of Love and Lust_: "Driving Blind" X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a01:4f9:2b:f0f::2 (failed) Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:287196 Archived-At: (Forgot the CCs; resending.) Sam Steingold writes: >> To reiterate -- I don't think this command sounds generally useful, and >> furthermore, if it is, it should not be bound to such a convenient key > > May I at least keep `gnus-collect-urls-from-article'? Sure, that seems generally useful. >> like `v', and moreover, the funky calling conventions of >> `browse-url-button-open-url' should be avoided. > > Well, I suppose you will add a deprecation decoration to the function. It's not a deprecated function -- it's a function meant to be used from the button machinery, which is why it's got an odd signature, if I remember correctly.