[PATCH] Fix bug in nnselect fetching new articles in a thread

[PATCH] Fix bug in nnselect fetching new articles in a thread

[Andrew Cohen]

Thanks to Eli and the GNU copyright staff, my copyright issues have now
been solved. Eli has instructed me to send all patches to the list prior
to pushing to the repository, so I have a fair number of small changes
in the pipeline. This is the first:


* lisp/gnus/nnselect.el (nnselect-request-thread): Ignore the
Retrieval Status Value in comparing whether articles are the same.
---
 lisp/gnus/nnselect.el | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/lisp/gnus/nnselect.el b/lisp/gnus/nnselect.el
index c880d79840..586dec65af 100644
--- a/lisp/gnus/nnselect.el
+++ b/lisp/gnus/nnselect.el
@@ -652,8 +652,15 @@ nnselect-request-thread
              (lambda (article)
                (if
                    (setq seq
-                         (cl-position article
-                                      gnus-newsgroup-selection :test 'equal))
+                         (cl-position
+                          article
+                          gnus-newsgroup-selection
+                          :test
+                          (lambda (x y)
+                            (and (equal (nnselect-artitem-group x)
+                                        (nnselect-artitem-group y))
+                                (eql (nnselect-artitem-number x)
+                                      (nnselect-artitem-number y))))))
                    (push (1+ seq) old-arts)
                  (setq gnus-newsgroup-selection
                        (vconcat gnus-newsgroup-selection (vector article)))
-- 
2.34.1.575.g55b058a8bb


-- 
Andrew Cohen

Re: [PATCH] Fix bug in nnselect fetching new articles in a thread

[Lars Ingebrigtsen]

Andrew Cohen <acohen@ust.hk> writes:

> * lisp/gnus/nnselect.el (nnselect-request-thread): Ignore the
> Retrieval Status Value in comparing whether articles are the same.

Looks good to me; go ahead and push.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no