From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jai Flack Newsgroups: gmane.emacs.devel Subject: Re: Overlay count for isearch Date: Fri, 18 Mar 2022 12:45:17 +1000 Message-ID: <87r170t1vm.fsf@disroot.org> References: <9631587bddf2ab3b07b60bd4195cc3e1@disroot.org> <87r17tmnzc.fsf@gmail.com> <8735k9jrr2.fsf@posteo.net> <87mtihmh8t.fsf@gmail.com> <87tucoblfh.fsf@disroot.org> <878rtxdh6a.fsf@gmail.com> <87czim3z8g.fsf_-_@disroot.org> <87zglqf6pp.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16153"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Monnier , Philip Kaludercic , emacs-devel@gnu.org To: Augusto Stoffel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Mar 18 07:18:04 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nV5w3-0003v9-8v for ged-emacs-devel@m.gmane-mx.org; Fri, 18 Mar 2022 07:18:03 +0100 Original-Received: from localhost ([::1]:59190 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nV5w2-0002ei-2X for ged-emacs-devel@m.gmane-mx.org; Fri, 18 Mar 2022 02:18:02 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:60010) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nV2cK-0002U1-82 for emacs-devel@gnu.org; Thu, 17 Mar 2022 22:45:28 -0400 Original-Received: from knopi.disroot.org ([178.21.23.139]:59748) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nV2cI-0005W0-2o for emacs-devel@gnu.org; Thu, 17 Mar 2022 22:45:27 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 1C853400AF; Fri, 18 Mar 2022 03:45:23 +0100 (CET) X-Virus-Scanned: SPAM Filter at disroot.org Original-Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id S6QVXaFNNXzw; Fri, 18 Mar 2022 03:45:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1647571522; bh=OzrEPLAD+qz6zLllshxpHdm7i4QE4PNs96iYVLKbNO0=; h=From:To:Cc:Subject:References:Date:In-Reply-To; b=QNjhgMyZPV1K9fLVj00AfuOj7X7LQistVscezLxz6diZyNwW438a94FdWNJUIUxvW 8H3h2BY2oxM5OD3ko3/2ON4ozX9a0b7qtt+cTET69oReLyVhoyMZ4qgjkFalv3MS54 LVvJWaqMsPkxKvfU84UOUOYvxYccwROnQ1bRmobi3yuu6bhhaB3fc4AfAIRpOnMbne ak/b7mCf6JxudpKb6GNIz4zmcs0XB7av/fdmQP/fltJQeEWB3/C1vYLVQlQENKWvBE otrEa1ePfSiJpGLHiYOC1bYkGNCmZCPqX8KptmmUIGho9ZS6MhmU6KdAtboDStcz1E 0zE5u4WgUH3oQ== In-Reply-To: <87zglqf6pp.fsf@gmail.com> (Augusto Stoffel's message of "Wed, 16 Mar 2022 13:00:02 +0100") Received-SPF: pass client-ip=178.21.23.139; envelope-from=jflack@disroot.org; helo=knopi.disroot.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Fri, 18 Mar 2022 02:15:23 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:287266 Archived-At: Augusto Stoffel writes: > when the patch proposed for bug#53126 is merged, a new > `lazy-count-update-hook' will be available. I think you can probably > simplify your implementation by using it. I would be much happier submitting it somewhere as a package or similar with that hook instead of requiring advice. Most of this patch is overlay management (and changing the other isearch count format function to support this addition) so it would only move a function call elsewhere. -- Thanks, Jai