From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Manuel Giraud Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix bookmark-bmenu-list sorting. Date: Mon, 21 Mar 2022 08:54:43 +0100 Message-ID: <87r16vhha4.fsf@elite.giraud> References: <875yovm1m6.fsf@elite.giraud> <87v8wvkk64.fsf@red-bean.com> <83v8wuj3v0.fsf@gnu.org> <87tucewgu7.fsf@red-bean.com> <83lexqi3z9.fsf@gnu.org> <87tuceuo4b.fsf@red-bean.com> <83czj2hrdv.fsf@gnu.org> <87a6e5lui6.fsf@elite.giraud> <837d99j10x.fsf@gnu.org> <874k4dlpeg.fsf@elite.giraud> <834k4divrt.fsf@gnu.org> <87wnh9k43g.fsf@elite.giraud> <83v8wth5lh.fsf@gnu.org> <87h78afndq.fsf@red-bean.com> <87zgm25d9o.fsf@elite.giraud> <87lex4ura5.fsf@red-bean.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30232"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (berkeley-unix) Cc: Eli Zaretskii , Manuel Giraud , emacs-devel@gnu.org To: Karl Fogel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Mar 21 08:55:57 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nWCtQ-0007a5-3i for ged-emacs-devel@m.gmane-mx.org; Mon, 21 Mar 2022 08:55:56 +0100 Original-Received: from localhost ([::1]:42252 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nWCtO-00032J-Do for ged-emacs-devel@m.gmane-mx.org; Mon, 21 Mar 2022 03:55:54 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:34012) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nWCsO-0002II-DW for emacs-devel@gnu.org; Mon, 21 Mar 2022 03:54:52 -0400 Original-Received: from ledu-giraud.fr ([51.159.28.247]:1971) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nWCsM-00069q-Gz; Mon, 21 Mar 2022 03:54:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=73/y4asENeqBQGmi Weecm8cF8K0q8UzWtoHqadWh85w=; h=in-reply-to:date:references:subject: cc:to:from; d=ledu-giraud.fr; b=j1zx8G2PAH2/y1OFPunIWrVIeGxJwcIRkxsDMP S2QIXqqLT3AFoBrsmFeYK+6qR8oX52hWwbrPnynVPp+DioAHoWFKj/C4iz50vpsSsWW9i7 XdwJ5uwzvVx+p3QVHErokDiqZuKbQWgnZL9GSWKPF/3EXM3+6Um8u7fA6D9/XUvzJbG9lP WKxPut5Bmp9AneVVELkeSFhKcB/EZkjoxjJHEDhwmJxrfSMTOo7PjpdIxBa6EQhXVIwtcO XGQiF9UGdzi7zOn0n5vxm+Cnln8Svl3JwugmpKySe5/sz2WLiRWzEL4uVW0D9mxVIGPRk7 /DJgVv69Pn9Zat1p8l4kYylw== Original-Received: from elite.giraud ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 6ea3d6ac (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Mon, 21 Mar 2022 08:54:45 +0100 (CET) In-Reply-To: <87lex4ura5.fsf@red-bean.com> (Karl Fogel's message of "Sun, 20 Mar 2022 18:40:18 -0500") Received-SPF: pass client-ip=51.159.28.247; envelope-from=manuel@ledu-giraud.fr; helo=ledu-giraud.fr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:287331 Archived-At: Karl Fogel writes: > Manuel, could you please give me a more verbose reproduction recipe > for that last paragraph above? Maybe even include a screenshot? > > I've attached an updated patch here (please use this version), and > when I test it, I don't see anything that says "sorted by bookmark > name". I don't know what the tabulated-list bar you're referring to > is, but I don't see anything that would obviously be it. > > (I have tried things like turning `menu-bar-mode' on and off. I've > also tried looking in the code of "lisp/emacs-lisp/tabulated-list.el", > but I don't see any place where a message "sorted by bookmark name" > would be set up.) Hi Karl, I'm sorry I was not clear at all. The =C2=ABsorted by bookmark name=C2=BB I= was refering to is the information about the "Bookmark" column entry being bold and with a down-triangle next to it (ie. what you are describing later in your message). > Now, there is another related UI issue: > > In the tabulated-list header line at the top of the buffer, we have > the expected three columns: "Bookmark", "Type", and "File". The first > column, "Bookmark", has a down-triangle / up-triangle toggle for > switching between descending and ascending sort by bookmark name. But > if `bookmark-sort-flag' is nil, then when the buffer is regenerated > the bookmarks will be listed in creation-date order -- and the > triangular toggle will just keep whichever value the triangle had > already. So yes that was what I was talking about (only better described =F0=9F=98= =85). > Maybe the right fix for that is for the buffer to somehow indicate > *which* property the bookmarks are sorted by -- name or creation-date > -- and make sure that the triangle always reflects the sorting > direction of whichever thing is currently being sorted on. However, > before I go down that road, I'd like to fully understand your initial > "one minor thing" bug report above first. Or maybe you can =C2=ABreset the state=C2=BB of the tabulated-list (as it i= s on first bookmark-bmenu-list call)? But I don't really know how tabulated-list works. Best regards, --=20 Manuel Giraud