From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#23264: 25.0.90; `C-h f' (`describe-function'): "This function has a compiler macro" Date: Fri, 13 May 2022 17:59:13 +0200 Message-ID: <87r14x1l0u.fsf@gnus.org> References: <877d6pvb7b.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26375"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 23264@debbugs.gnu.org, Eli Zaretskii , Drew Adams To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 13 18:06:16 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1npXo0-0006YL-9s for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 13 May 2022 18:06:16 +0200 Original-Received: from localhost ([::1]:59072 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1npXny-0001Na-SR for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 13 May 2022 12:06:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50690) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1npXhy-0007Eh-W5 for bug-gnu-emacs@gnu.org; Fri, 13 May 2022 12:00:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50907) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1npXhy-0002Wu-Ik for bug-gnu-emacs@gnu.org; Fri, 13 May 2022 12:00:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1npXhy-0006Lj-GI for bug-gnu-emacs@gnu.org; Fri, 13 May 2022 12:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 13 May 2022 16:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23264 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 23264-submit@debbugs.gnu.org id=B23264.165245756924314 (code B ref 23264); Fri, 13 May 2022 16:00:02 +0000 Original-Received: (at 23264) by debbugs.gnu.org; 13 May 2022 15:59:29 +0000 Original-Received: from localhost ([127.0.0.1]:44804 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1npXhQ-0006K5-T4 for submit@debbugs.gnu.org; Fri, 13 May 2022 11:59:29 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:39114) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1npXhO-0006Jo-SX for 23264@debbugs.gnu.org; Fri, 13 May 2022 11:59:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=q4TqX/+MLXHK1ZJzntXc15h89vXxcLBCZwz9nKvVFO0=; b=gqlT/CmToJTryHJvKqP9DIMeX2 fZePcB194854cPvYIeS8SYjmk1LnTJXHKq/9TZkw4WZmQobAjlHvCjb3vdDZvH0WE3hBoUjoiAk92 Pus4fE6H1k7lm4J1t6j1cT5D5DdolHR8jYST7EbFPRoX0pdzyRmvjyXXXuplRIr2QJxM=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1npXhC-0002FY-Im; Fri, 13 May 2022 17:59:16 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAGFBMVEUFBAUnHRkyKylR RDpGNzGVg25hVEv///945FKsAAAAAWJLR0QHFmGI6wAAAAd0SU1FB+YFDQ8eE23gPK4AAAGqSURB VDjLjVRNk4IwDG1x9WwqeoZSOCMwnBU7nld39OzCbv//T9ikfFk7O2NmUNqXvCQvLYxxsMYA1swx 2a/B2SzwSXQDoHTzvB980a84d3UXuzTZgzEMQFBVDrB8TK/cAba5v2dtETHWyFN1OpXaA/P+b7V+ BQqhVdlVNbzso6Pt3Av438JT3SaFjjzgCLD7jmNlF0rOlI3UaSdhRzuZaUmjAeQglZSS3m4d7Qmv p23be2a2t0CKCMulCDM4rK59cr5phSR123Ecd2I8YFV9rfw6AjfiAkyMD06Q78dkvw8n9yx/+kli YWY+6TYAF6LSZYVsOPRgAnaXmecDlxOwIirIjKmrCk9SOgNu8vQwVeVOZ3Ucy7tZdZUxplVIFRSj x53QvF8sMPo8cC1tUWWhuqpJaqpyEGuX9+OAGECQXNxQCOehP/89gzicFZiFCqPsZ7wQygoCyegQ j/5SWiBmb5uI7RH1InhhuaR3ZIJo6NyjSqpSN9oeuMkiv8We/hhaBXygIElrs6evQPGMCHVg/MBt q84d3JiccfwsSKm0ccnQjYs1p3v4riB/wnw3K2tbAgAAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjIt MDUtMTNUMTU6MzA6MTkrMDA6MDDy2CxQAAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIyLTA1LTEzVDE1 OjMwOjE5KzAwOjAwg4WU7AAAAABJRU5ErkJggg== X-Now-Playing: Colourbox's _Colourbox (PolyGram)_: "Justice" In-Reply-To: (Stefan Monnier's message of "Fri, 13 May 2022 10:20:17 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:232169 Archived-At: Stefan Monnier writes: > 1- If it includes a link to the compiler macro. Admittedly, compiler > macros are supposed to be placed directly inside the `declare` of the > function, so you can get there via the usual link to the function's > definition, which makes this link's usefulness rather marginal. > (except in theory for those rare exceptions where the compiler macro > is not provided via `declare`, but to be honest, I can't think of any > and `grep` couldn't find any either). There's this: (put 'featurep 'compiler-macro (lambda (form feature &rest _ignore) ;; Emacs-21's byte-code doesn't run under XEmacs or SXEmacs anyway, = so ;; we can safely optimize away this test. (if (member feature '('xemacs 'sxemacs 'emacs)) (eval form) form))) But that's not a symbol, so Emacs won't offer up a button for it. But it is indeed extremely rare. > 2- It warns that advice and (more generally) redefinitions of this > function may not be obeys at all call sites. Hm, yes, that can be handy to know. > Point 1 is quite weak. > Point 2 is a bit more interesting but then we should say so more > explicitly and (more importantly) we should also say so for those > functions which have the same property but for other reasons (e.g. they > have their own byte-code, or they have a `byte-compile` or > `byte-optimizer` property). > > IOW, I agree but maybe it would be a good idea to replace it with > a better message that covers this and similar cases warning about > applicability of `advice`. Do you have any suggested text? =F0=9F=99=83 --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no