all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: TEC <tec@tecosaur.com>,  emacs-devel@gnu.org
Subject: Re: [elpa] externals/org 6de5431acc: org: Refactor rx to concat + regexp-opt
Date: Wed, 27 Jul 2022 11:01:46 +0800	[thread overview]
Message-ID: <87r127b6n9.fsf@localhost> (raw)
In-Reply-To: <jwv5yjmzeex.fsf-monnier+emacs@gnu.org>

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>>               'org-safe-remote-resources
>> -             (list (rx string-start
>> -                       (literal
>> -                        (if (and (= char ?f) current-file)
>> -                            (concat "file://" current-file) uri))
>> -                       string-end))))
>> +             (list (concat "\\`"
>> +                           (regexp-opt
>> +                            (if (and (= char ?f) current-file)
>> +                                (concat "file://" current-file) uri))
>> +                           "\\'"))))
>
> Did you mean to use `regexp-quote` instead of `regexp-opt`, maybe?

Timothy has fixed the regexp in
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=6ad53fa22eab5830f85a401960dc1e7d00154a27

Note that this email address (tec@tecosaur.com) may be dysfunctional.
See https://list.orgmode.org/dd8a140cd218951f77c279a252b03f66@tecosaur.com/T/#u

Best,
Ihor



      reply	other threads:[~2022-07-27  3:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <165867467321.24615.13379333890500235410@vcs2.savannah.gnu.org>
     [not found] ` <20220724145753.7E671C00602@vcs2.savannah.gnu.org>
2022-07-24 16:03   ` [elpa] externals/org 6de5431acc: org: Refactor rx to concat + regexp-opt Stefan Monnier
2022-07-27  3:01     ` Ihor Radchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r127b6n9.fsf@localhost \
    --to=yantar92@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=tec@tecosaur.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.