all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stephen Berman <stephen.berman@gmx.net>
To: Juri Linkov <juri@linkov.net>
Cc: Lars Ingebrigtsen <larsi@gnus.org>, 57082@debbugs.gnu.org
Subject: bug#57082: 29.0.50; emacs-news-view-mode breakage
Date: Wed, 10 Aug 2022 10:19:19 +0200	[thread overview]
Message-ID: <87r11owlx4.fsf@gmx.net> (raw)
In-Reply-To: <86bkssedll.fsf@mail.linkov.net> (Juri Linkov's message of "Wed,  10 Aug 2022 10:36:22 +0300")

On Wed, 10 Aug 2022 10:36:22 +0300 Juri Linkov <juri@linkov.net> wrote:

>>> Also don't understand why is this change:
>>>
>>>          (when outline-minor-mode-highlight
>>> -          (if (and global-font-lock-mode (font-lock-specified-p major-mode))
>>> -              (progn
>>> -                (font-lock-add-keywords nil outline-font-lock-keywords t)
>>> -                (font-lock-flush))
>>> -            (outline-minor-mode-highlight-buffer)))
>>> +          (when (and global-font-lock-mode (font-lock-specified-p major-mode))
>>> +            (font-lock-add-keywords nil outline-font-lock-keywords t)
>>> +            (font-lock-flush))
>>> +          (outline-minor-mode-highlight-buffer))
>>>
>>> `outline-minor-mode-highlight-buffer' is intended only for buffers
>>> that don't support font-lock highlighting.
>>
>> Yes, but with that change, arrows are displayed on first visiting the
>> NEWS buffer; without it, they only appear when typing TAB on an outline
>> heading.
>
> This change broke fontification e.g. in diff buffers that now
> add outline faces on diff hunks.  So we need another solution.

Oh, dear (as I noted in my OP, I only checked NEWS and *Help* with
describe-binding).  But do you have a recipe to see this?  When I create
a diff with vc-diff I don't see outline faces on the hunks.

Steve Berman





  reply	other threads:[~2022-08-10  8:19 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-09 16:18 bug#57082: 29.0.50; emacs-news-view-mode breakage Stephen Berman
2022-08-09 18:23 ` Lars Ingebrigtsen
2022-08-09 19:18   ` Juri Linkov
2022-08-09 20:18     ` Stephen Berman
2022-08-10  0:03       ` Jim Porter
2022-08-10  7:39         ` Juri Linkov
2022-08-10  8:08           ` Gregory Heytings
2022-08-10  8:10             ` Juri Linkov
2022-08-10  8:24               ` Gregory Heytings
2022-08-10 15:17                 ` Drew Adams
2022-08-10  7:55         ` Stephen Berman
2022-08-10  8:07           ` Juri Linkov
2022-08-12 12:50             ` Lars Ingebrigtsen
2022-08-12 12:49           ` Lars Ingebrigtsen
2022-08-12 12:51         ` Lars Ingebrigtsen
2022-08-10  7:36       ` Juri Linkov
2022-08-10  8:19         ` Stephen Berman [this message]
2022-08-10 18:45           ` Juri Linkov
2022-08-10 18:58             ` Stephen Berman
2022-08-11  6:44               ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r11owlx4.fsf@gmx.net \
    --to=stephen.berman@gmx.net \
    --cc=57082@debbugs.gnu.org \
    --cc=juri@linkov.net \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.