From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#50869: 28.0.50; tramp: void-function tramp-file-name-method--cmacro Date: Sat, 03 Sep 2022 12:07:43 +0200 Message-ID: <87r10shits.fsf@gnus.org> References: <87tuhzcrje.fsf@gmx.de> <87pmlydvd4.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27299"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: shuguang79@qq.com, Stefan Monnier , 50869@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 03 12:08:13 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oUQ4T-00070i-A1 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 03 Sep 2022 12:08:13 +0200 Original-Received: from localhost ([::1]:33466 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oUQ4R-0000mJ-KM for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 03 Sep 2022 06:08:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58750) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oUQ4J-0000mB-A8 for bug-gnu-emacs@gnu.org; Sat, 03 Sep 2022 06:08:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52306) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oUQ4I-0003D0-Pt for bug-gnu-emacs@gnu.org; Sat, 03 Sep 2022 06:08:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oUQ4I-0003iQ-Dx for bug-gnu-emacs@gnu.org; Sat, 03 Sep 2022 06:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 03 Sep 2022 10:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50869 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 50869-submit@debbugs.gnu.org id=B50869.166219967614268 (code B ref 50869); Sat, 03 Sep 2022 10:08:02 +0000 Original-Received: (at 50869) by debbugs.gnu.org; 3 Sep 2022 10:07:56 +0000 Original-Received: from localhost ([127.0.0.1]:41005 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oUQ4C-0003i4-5L for submit@debbugs.gnu.org; Sat, 03 Sep 2022 06:07:56 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:45780) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oUQ4B-0003hp-0y for 50869@debbugs.gnu.org; Sat, 03 Sep 2022 06:07:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=9VFJk5hLuTRvDcHEII3T+RIBpOKsS1H1FFen/503+Gc=; b=Fpfs7LaYtrM39UKRkFWkFiM+Ju h9I7vvh2WsKkP0bt2VH1Ezts9GT8AYAM03KSwQxeAykvAqeZlhdt1n/vxG5MrzSS69NZwASBslNg+ z9exF//+Xn2JFDvpbEkBvTk3bWHYMU2bzRG0LPWef38PDYmB9YVDHOLZBBScCpYzVlfI=; Original-Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oUQ41-0006Lm-8d; Sat, 03 Sep 2022 12:07:47 +0200 In-Reply-To: (Stefan Monnier via's message of "Fri, 02 Sep 2022 14:52:27 -0400") Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAG1BMVEWjYJnVRnfUW6S5 PE/SiFNPNkbNprfn19v////QDqkyAAAAAWJLR0QIht6VegAAAAd0SU1FB+YJAwktDtsv08cAAAFz SURBVDjLldO9boMwEADgCxLJbKOSNTYqO5B0rhQegDZ1Z6sSZkUdzOv3sLExhKjKjXzcjzEHO0J4 UtVXvgpAINW5vlL/6CQaISILdV3PkAnh4LwAzHGlEK7lRo+kwig2oDJB7yCxUDwN1cYBCVs1cEAR GOfKxCIjK1muBhs6AJ6V+eBjmZF35qHsFhkIR/t2u4aP1FdaQ+ehDCApjnNG9ACG3wBeglIeGCPk dRsolkqVP7l2pTjFYmnnwWdw/LoEM1S3gHG4EWKl9oseZmpG03hvuuhB9tEMnKbSdtda9J8B8Hzq oXsh70D9A+2jUi08BT32eAhTD+pAG9CuOd4HDTKUEtDMF0WIhW6QCD6DVJfbm/0/Va9w/zhMgMv4 pe0BZRcj/EQWcBGKd4jHbW0Q8DufAHaUmSYXYaKR8Q1yZc8x/g4OcCZsoGTuDphUDsRNfI+1JuAM pmhFc8BJEPJww05g7hEhXC8DByUBHAQEOBngwH9ep/uqWyemngAAACV0RVh0ZGF0ZTpjcmVhdGUA MjAyMi0wOS0wM1QwOTo0NToxNCswMDowMDzHEP4AAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjItMDkt MDNUMDk6NDU6MTQrMDA6MDBNmqhCAAAAAElFTkSuQmCC X-Now-Playing: The Cure's _Three Imaginary Boys (1)_: "Fire In Cairo" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:241384 Archived-At: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: > The main point is that putting the `cl-defstruct` into the > `tramp-loaddefs.el` is really ugly and I think it's asking for trouble. The cl-defstruct is in there because a couple of defsubsts (that use the struct) are also in the tramp-loaddefs.el file. So if we remove the defstruct, we also have to adjust the defsubsts. > In contrast the OP's "errors" aren't actual errors, they're just > messages indicating that some optimization could not be applied. > We should really change the wording to clarify that they're warnings. > > (see first hunk in patch below). Looks good. > - We could make `cl-defstruct` use `define-symbol-prop` rather than > `put`, as in the third hunk of the patch below. Makes sense to me.