From: Lars Ingebrigtsen <larsi@gnus.org>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: shuguang79@qq.com, Stefan Monnier <monnier@iro.umontreal.ca>,
50869@debbugs.gnu.org
Subject: bug#50869: 28.0.50; tramp: void-function tramp-file-name-method--cmacro
Date: Sat, 03 Sep 2022 12:07:43 +0200 [thread overview]
Message-ID: <87r10shits.fsf@gnus.org> (raw)
In-Reply-To: <jwvczcd4ohz.fsf-monnier+emacs@gnu.org> (Stefan Monnier via's message of "Fri, 02 Sep 2022 14:52:27 -0400")
Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of
text editors" <bug-gnu-emacs@gnu.org> writes:
> The main point is that putting the `cl-defstruct` into the
> `tramp-loaddefs.el` is really ugly and I think it's asking for trouble.
The cl-defstruct is in there because a couple of defsubsts (that use the
struct) are also in the tramp-loaddefs.el file. So if we remove the
defstruct, we also have to adjust the defsubsts.
> In contrast the OP's "errors" aren't actual errors, they're just
> messages indicating that some optimization could not be applied.
> We should really change the wording to clarify that they're warnings.
>
> (see first hunk in patch below).
Looks good.
> - We could make `cl-defstruct` use `define-symbol-prop` rather than
> `put`, as in the third hunk of the patch below.
Makes sense to me.
next prev parent reply other threads:[~2022-09-03 10:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-28 15:15 bug#50869: 28.0.50; tramp: void-function tramp-file-name-method--cmacro Shuguang Sun via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-02 16:36 ` Michael Albinus
2022-03-17 14:39 ` Michael Albinus
2022-04-02 21:09 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-04-03 15:44 ` Michael Albinus
2022-09-02 18:52 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-09-03 10:07 ` Lars Ingebrigtsen [this message]
2022-09-03 19:08 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-09-04 14:53 ` Michael Albinus
2022-09-04 16:44 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-09-04 17:27 ` Michael Albinus
2022-09-04 18:03 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-09-02 11:43 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r10shits.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=50869@debbugs.gnu.org \
--cc=michael.albinus@gmx.de \
--cc=monnier@iro.umontreal.ca \
--cc=shuguang79@qq.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.