From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#58844: 29.0.50; Font lock features for js/ts-mode Date: Fri, 28 Oct 2022 21:59:39 +0200 Message-ID: <87r0yrd8ic.fsf@thornhill.no> References: <87ilk3rbp5.fsf@thornhill.no> <9D349316-6AA2-4A5C-8010-110100F3EDB5@gmail.com> Reply-To: Theodor Thornhill Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38068"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58844@debbugs.gnu.org To: Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 28 22:00:09 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ooVWT-0009er-1i for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 28 Oct 2022 22:00:09 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ooVWO-0000V6-1n; Fri, 28 Oct 2022 16:00:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ooVWM-0000Uc-Vd for bug-gnu-emacs@gnu.org; Fri, 28 Oct 2022 16:00:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ooVWM-0001Kp-NH for bug-gnu-emacs@gnu.org; Fri, 28 Oct 2022 16:00:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ooVWM-0002z5-Iu for bug-gnu-emacs@gnu.org; Fri, 28 Oct 2022 16:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Theodor Thornhill Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 28 Oct 2022 20:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58844 X-GNU-PR-Package: emacs X-Debbugs-Original-Cc: Bug Report Emacs Original-Received: via spool by submit@debbugs.gnu.org id=B.166698719211432 (code B ref -1); Fri, 28 Oct 2022 20:00:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 28 Oct 2022 19:59:52 +0000 Original-Received: from localhost ([127.0.0.1]:34362 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ooVWC-0002yJ-8q for submit@debbugs.gnu.org; Fri, 28 Oct 2022 15:59:52 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:53568) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ooVW7-0002y7-So for submit@debbugs.gnu.org; Fri, 28 Oct 2022 15:59:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ooVW7-000892-N2 for bug-gnu-emacs@gnu.org; Fri, 28 Oct 2022 15:59:47 -0400 Original-Received: from out0.migadu.com ([94.23.1.103]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ooVW4-0001IJ-Jz for bug-gnu-emacs@gnu.org; Fri, 28 Oct 2022 15:59:46 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1666987180; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=USLUJi1fpQIKMlco63xL8ELAAlMboPOWZI9gpYxyNQ8=; b=klp5+IU+QrG4OpztsZWZtTUBLI3VR12yXtK5moXQg3TEBeUrCaD6tt/9tkroWAsZWUfghY LJVExXKAcfpVLXU3Ne34+xqsLd6m/Bl8PctCWE5AJdG1PZk+3PTW8h2Uco0eNHKlOlzyPG fBtewCU1RrY4gKaGEK9+Y1dl53U6ZCrbgyCX0/0KfzJ+ER2mSmcaPeOObgLuDsTApSimjW dENaxc93plNHqnQNK1xNv2AS6OczaOB87hL8cwKfMp26/jE+MzHI0cZxSURku1iv8evD1n gg1GycxN695NmHEVlxAgKDjilnRdqICHb7xQoiX1nAm5gf1zYi9t1s1phig9xQ== In-Reply-To: <9D349316-6AA2-4A5C-8010-110100F3EDB5@gmail.com> X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=94.23.1.103; envelope-from=theo@thornhill.no; helo=out0.migadu.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246456 Archived-At: Yuan Fu writes: >> On Oct 28, 2022, at 12:27 PM, Theodor Thornhill wrot= e: >>=20 >> Hi Yuan! >>=20 >> I've added more font lock features to the js and ts modes. I think they >> can serve as a suitable starting point for the features, and serve as >> inspiration to other modes, until we settle on a standard here. >>=20 >> Thanks, >>=20 >> Theo >>=20 >> <0001-Add-in-new-font-lock-features-in-js-ts-mode.patch> > > Thanks! Minor bikeshed: I think singular is slightly better. Ie, > comment instead of comments. No need to modify your patch, if you > agree I can change them myself. Also treesit-font-lock-feature-list > should contain three sublist, each representing a decoration level, > that=E2=80=99s how we get two types of customization in the same time. I = can > fix that too. > Sure, just go ahead! > While we=E2=80=99re at it, are there specific reasons why you write many = indent rules in two lines, like this: > > ((parent-is "ternary_expression") > parent-bol ,ts-mode-indent-offset) > > ? > > I think they should be in one line for clarity and space efficiency. Sure! The only reason was that you asked me to cram it into short lines, hehe ;-) Do you want another patch for that? BTW, disregard the other bug. That's the same one... --=20 Thanks, Theo