From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#58839: [Patch] Re: bug#58839: 29.0.50; project-kill-buffer fails when Eglot is running Date: Wed, 02 Nov 2022 09:13:10 +0000 Message-ID: <87r0ylafdl.fsf@posteo.net> References: <87sfj8umwb.fsf@posteo.net> <87zgdfwkle.fsf@gmail.com> <8e31a89d-e35e-6dd0-a8e3-f0b9684c8bfa@yandex.ru> <87v8o3wgq1.fsf@gmail.com> <87ilk2x1si.fsf@gmail.com> <871qqq7l9p.fsf@posteo.net> <87eduqwekz.fsf@gmail.com> <87wn8invbx.fsf@posteo.net> <877d0iw8iq.fsf@gmail.com> <837d0hhlke.fsf@gnu.org> <46ff0065-5645-ef1e-2621-242fb6a73f98@yandex.ru> <87v8o0uxn5.fsf@gmail.com> <787a4362-7ff5-7dbb-9118-16e4bee5f328@yandex.ru> <87edunvhf2.fsf@gmail.com> <6d4d9e72-1bae-4d64-b7c1-c2b9c11e396f@yandex.ru> <6c9811d7-ad05-2d2d-0c34-9b4c1fa09305@yandex.ru> <87a659u7vo.fsf@gmail.com> <8735b1bvnz.fsf@posteo.net> <87mt99spsk.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39892"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , manuel.uberti@inventati.org, 58839@debbugs.gnu.org, Dmitry Gutov To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 02 10:14:29 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oq9pM-000A8u-Oc for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 02 Nov 2022 10:14:28 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oq9ox-0002uE-Lw; Wed, 02 Nov 2022 05:14:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oq9ow-0002tr-VC for bug-gnu-emacs@gnu.org; Wed, 02 Nov 2022 05:14:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oq9ow-0001g1-B3 for bug-gnu-emacs@gnu.org; Wed, 02 Nov 2022 05:14:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oq9ov-0003eX-Ty for bug-gnu-emacs@gnu.org; Wed, 02 Nov 2022 05:14:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Nov 2022 09:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58839 X-GNU-PR-Package: emacs Original-Received: via spool by 58839-submit@debbugs.gnu.org id=B58839.166738040213981 (code B ref 58839); Wed, 02 Nov 2022 09:14:01 +0000 Original-Received: (at 58839) by debbugs.gnu.org; 2 Nov 2022 09:13:22 +0000 Original-Received: from localhost ([127.0.0.1]:44927 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oq9oH-0003dR-Vd for submit@debbugs.gnu.org; Wed, 02 Nov 2022 05:13:22 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:46817) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oq9oG-0003dD-2v for 58839@debbugs.gnu.org; Wed, 02 Nov 2022 05:13:20 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 5ECED240029 for <58839@debbugs.gnu.org>; Wed, 2 Nov 2022 10:13:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1667380394; bh=GTE+qtj3jpAdAmC0k1Am+bbj+3c9F/InoY0V4DVdBR4=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=BBB1t00VfwcuKkAM90aPmHxr7DRmir1eY2jmjaLJ8QUgJYdkf4nn6usRY7huoMags zrhQ/WtMEPk/zkw5RwMXbR+J193rNXnN4wCo7QcCX/UTlQI4rSUZyGXIN1rKlGY3aK ttN+Ay7y75sRadQLITD2u/bWtJM1Z/094oJjCLcjB7XQwM3GvP5wJJuOyZKtpjC1ZE VMxnhb3thRerlq6kbsxKLdAV02hz1IaENaQI5WFa6HPUyHC99Ni4DpBHl89XoTat7t vrCyVtC/GBn3cST0JvZ7qE3/g8bLnp1mcFetTIVBAW8obNou82jI6/gCfFylwyQGw7 /lfcwXWI2JUPg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4N2LlV4LVRz9rxV; Wed, 2 Nov 2022 10:13:10 +0100 (CET) In-Reply-To: <87mt99spsk.fsf@gmail.com> ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Wed, 02 Nov 2022 08:50:51 +0000") Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246854 Archived-At: Jo=C3=A3o T=C3=A1vora writes: > Philip Kaludercic writes: > >>> Not sure. This started has a report of hidden buffer being incorrectly >>> killed by project.el.=20=20 >> >> The issue that was reported was that Eglot/jsonrpc raised an error that >> broke `project-kill-buffer'. This could have also all been solved by >> wrapping a `with-demoted-errors' around `kill-buffer'. > > No. It couldn't. The error is there to show you among other things > that the LSP connection isn't being shut down correctly, which is not > something to paper over. And even if you did paper over the error, you > would break eglot-autoshutdown. I've explained that at least 3 times > already in the beginning of this discussion. That was not my concern, my concern was that project-kill-buffer broke. I continue to not see a reason why project.el should be considered broken because of this, and not jsonrpc/eglot. To be fair, I am not as familiar with LSP as you are, so there might be a technical reason why this is the case, but without something like that, you appear to be privileging an arbitrary perspective, supposedly because you are the maintainer of these packages. This is probably best solved by reading code. Can you point me to a few functions/section/etc. that would help me clarify the situation. >>> Three people here have suggested an opt-in approach for the true >>> positives. Now your strategy seems to be "OK: let all these false >>> positives remain nonsensically associated with a project in >>> project-buffers but let's have global databases of exceptions for >>> specific operations, using a (largely redundant) mini-language for >>> buffer-matching". >> >> For the record, I am still not convinced 100% either way. > > I just said that becasue you at one point did suggested the > opt-in approach=20 > > I have to admit that I am more and more inclined to make the list a > opt-in thing, where we explicitly mark those major modes that are tied > to a project. The key word here is "more and more inclined". > But of course it's OK to change one's mind back and forth. I haven't made up my mind, I am just trying to understand all perspectives, and get a better overview over the issue.