From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package: use-package Date: Thu, 03 Nov 2022 17:15:15 +0000 Message-ID: <87r0ykufh8.fsf@posteo.net> References: <87lep4jeeb.fsf@gmail.com> <87bkq0gfc9.fsf@posteo.net> <87v8o80xs1.fsf@gmail.com> <87h6zqgc3s.fsf@gmail.com> <87v8o52mkn.fsf@gmail.com> <87v8o5w2c1.fsf@posteo.net> <877d0kbkfm.fsf@gmail.com> <875yg4144y.fsf@gmail.com> <87h6zmj451.fsf@gmail.com> <5EE58F68-8B9E-4DE6-BA20-3A88FFDA6528@posteo.net> <871qqkjwjj.fsf@gmail.com> <87o7to2dfy.fsf@gmail.com> <87y1ssugaf.fsf@posteo.net> <875yfw6kbx.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16723"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Monnier , John Wiegley , emacs-devel To: Payas Relekar Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Nov 03 18:16:22 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oqdpF-00045n-Ve for ged-emacs-devel@m.gmane-mx.org; Thu, 03 Nov 2022 18:16:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oqdoR-0006zC-0B; Thu, 03 Nov 2022 13:15:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqdoO-0006ys-PX for emacs-devel@gnu.org; Thu, 03 Nov 2022 13:15:28 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqdoI-00016l-CJ for emacs-devel@gnu.org; Thu, 03 Nov 2022 13:15:28 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 52AF424002A for ; Thu, 3 Nov 2022 18:15:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1667495718; bh=xw1wn5khXKeJ49rnr7L+/4fbrr4/wmAehIvTj8UnlR0=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=JrhXa/f2fE0Wcu0Nla3tsy99H4j4kfBowt129DaghpYrJRCh1yLqHwmawNjF2UsAr LsbgGvn97ZKyB/5p6oT3L8EyragZQtjeKF97EwPgcAifPXzge8gTiWmBtSVmMmOK1W cMpRZ5eyfG5c6Om8U18q7Eei2LeaTHV8l76DHGcDP2EjifHYawZ4v0p33k0GwAxKf2 p8vdlbCoTjMHeOfUe2lhQRKc3Qa5nUaJqaBb2hxGav7dDP0ZV4aMJIqxxn82VMMtwa joF4kGFSXYWNhCYMBAnp4VdtmOXXsxcui+8ZWV+XEv3Z8u7hNDHxdasZCvk30sJiT9 9QpBvd7QMpkig== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4N39PH15fRz6tmP; Thu, 3 Nov 2022 18:15:15 +0100 (CET) In-Reply-To: <875yfw6kbx.fsf@gmail.com> (Payas Relekar's message of "Thu, 03 Nov 2022 22:29:56 +0530") Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "Emacs-devel" Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:299083 Archived-At: Payas Relekar writes: > Philip Kaludercic writes: > >> Payas Relekar writes: >> >>> My understanding is that we only need to add copyrights to the file >>> because entire repo is cloned to GNU machines. But even after adding >>> copyright headers, IMO adding doc/* to :ignored-files is the right thing >>> to do as it does not serve users directly. >> >> I can imagine that replacing "doc/*" with "doc/" might help, as >> `elpaa--copyright-files' doesn't appear to do any globing, instead just >> tries to find the file using `member' (ie. using a string comparison >> and not even `file-equal-p'). > > Do you mean in .elpaignore? Because doc/ is not added to :ignored-files > right now. Ah, I forgot that. In that case elpa-admin.el only checks the file when creating the package, but it isn't used to exclude files from the copyright check. I don't know if there is a reason for this. >>> ======== Building tarball archive-devel/use-package-2.4.4.0.20221103.163652.tar... >>> Build error for archive-devel/use-package-2.4.4.0.20221103.163652.tar: (error "Error-indicating exit code in elpaa--call-sandboxed: >>> bwrap: execvp makeinfo: No such file or directory >>> ") >> >> This is suspicious, where is makeinfo located? Perhaps you can find out >> more if you set the environmental variable "ELPA_DEBUG"? > > I did not set this variable. What should its value be? Any non-empty value. Feel free to take a peek into elpa-admin.el, you'll find the following line in there: (getenv "ELPA_DEBUG") The documentation says "Value is nil if VARIABLE is undefined in the environment. Otherwise, value is a string.". >>> In toplevel form: >>> packages/use-package/doc/setup-ox-hugo.el:192:51: Warning: reference to free variable `ox-hugo-default-lisp-directory' >>> packages/use-package/doc/setup-ox-hugo.el:215:21: Warning: reference to free variable `org-emphasis-regexp-components' >>> packages/use-package/doc/setup-ox-hugo.el:222:33: Warning: Unused lexical argument `file' >>> packages/use-package/doc/setup-ox-hugo.el:224:4: Error: `add-to-list' can't use lexical var `ob-lang-alist'; use `push' or `cl-pushnew' >>> packages/use-package/doc/setup-ox-hugo.el:224:4: Error: `add-to-list' can't use lexical var `ob-lang-alist'; use `push' or `cl-pushnew' >>> packages/use-package/doc/setup-ox-hugo.el:230:56: Warning: Unused lexical argument `body' >>> packages/use-package/doc/setup-ox-hugo.el:238:11: Warning: assignment to free variable `org-confirm-babel-evaluate' >>> packages/use-package/doc/setup-ox-hugo.el:241:11: Warning: assignment to free variable `org-export-headline-levels' >>> packages/use-package/doc/setup-ox-hugo.el:242:19: Warning: reference to free variable `org-export-exclude-tags' >>> packages/use-package/doc/setup-ox-hugo.el:242:19: Warning: assignment to free variable `org-export-exclude-tags' >>> >>> In end of data: >>> packages/use-package/doc/setup-ox-hugo.el:238:40: Warning: the function `ox-hugo-org-confirm-babel-evaluate-fn' is not known to be defined. >>> packages/use-package/doc/setup-ox-hugo.el:218:4: Warning: the function `org-set-emph-re' is not known to be defined. >>> packages/use-package/doc/setup-ox-hugo.el:208:4: Warning: the function `org-hugo-export-wim-to-md' is not known to be defined. >>> packages/use-package/doc/setup-ox-hugo.el:75:49: Warning: the function `vc-git-root' is not known to be defined. >>> make: *** [GNUmakefile:119: packages/use-package/doc/setup-ox-hugo.elc] Error 1 >> >> The ignored files are just not included into the tarball (see >> `elpaa--make-one-tarball-1' in elpa-admin.el), but they are still byte >> compiled AFAIK. > > That feels like waste of CPU cycles. Probably... >> I will once more argue that it might be easier to remove these files >> from the repository entirely. > > As much as I agree, that would be John's call. John, what do you say? With use-package added to ELPA, the documentation would automatically be made available on elpa.gnu.org, so there might not be a need for a special website. > He does maintain separate > webpage for use-package keywords, but I'll say Github already renders > README well enough (and also uses ox-hugo under the hood IIRC). GitHub uses ox-hugo? That would be news to me. Either way, I believe that now that a texinfo manual has been written (right?), the requirements have changed. > John, WDYT? > > --