From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#59897: 29.0.60; csharp-ts-mode: variable-name fontified as method when invoking method with generic type-argument. Date: Thu, 08 Dec 2022 12:12:17 +0100 Message-ID: <87r0xa9mjy.fsf@thornhill.no> References: <76edd79f-6da1-4c28-b20e-5eb4d9a819b2@app.fastmail.com> <87zgby9pax.fsf@thornhill.no> <8fdc4d5d-17ac-3a06-d602-637df9fe1be1@secure.kjonigsen.net> Reply-To: Theodor Thornhill Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14398"; mail-complaints-to="usenet@ciao.gmane.io" Cc: casouri@gmail.com, 59897@debbugs.gnu.org To: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= , Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 08 12:13:09 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p3Epx-0003Zj-4N for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 08 Dec 2022 12:13:09 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p3Ept-000744-Py; Thu, 08 Dec 2022 06:13:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p3Epq-00073q-KF for bug-gnu-emacs@gnu.org; Thu, 08 Dec 2022 06:13:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p3Epq-00046A-5m for bug-gnu-emacs@gnu.org; Thu, 08 Dec 2022 06:13:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p3Epq-0000U6-0U for bug-gnu-emacs@gnu.org; Thu, 08 Dec 2022 06:13:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Theodor Thornhill Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 08 Dec 2022 11:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59897 X-GNU-PR-Package: emacs Original-Received: via spool by 59897-submit@debbugs.gnu.org id=B59897.16704979421855 (code B ref 59897); Thu, 08 Dec 2022 11:13:01 +0000 Original-Received: (at 59897) by debbugs.gnu.org; 8 Dec 2022 11:12:22 +0000 Original-Received: from localhost ([127.0.0.1]:56112 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3EpB-0000Tr-Qy for submit@debbugs.gnu.org; Thu, 08 Dec 2022 06:12:22 -0500 Original-Received: from out-28.mta0.migadu.com ([91.218.175.28]:55355) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3Ep9-0000Tl-H0 for 59897@debbugs.gnu.org; Thu, 08 Dec 2022 06:12:20 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1670497938; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tqtkfpjB4ahPsILdQiOBu5gkxvSOmi2MSzCmWd2QQlo=; b=VlcspuCy5cY1Oc5fO245e4rtmCVteIoUA31vefQBVjoS+978+4zMUgjXe8JC4GgUrIz1fI vLp7ebG/OWtb7fWeihynQp9B+HPei32IfxTU+7amb67BZDN4rh9H5sa6cr8U1gLhAxptv3 Iy06HoH8r+ItfL5NFM7xbfL4w8BF8xqyLCQr0QmUEnhGbaWlu5s5XKyt7230re2tATCTjd y7BO1l+zdj7B2DwLlGaguRstS9osFmkkLOLVUMFfGwZeTLWnDNi0TegHmzzipXvCbSzEZs Th7KrclU83D/BmWitcW1J75vVF7EhpWVI6u2AR3h4qvPsxWx8IOBhvlot/Do2A== In-Reply-To: <8fdc4d5d-17ac-3a06-d602-637df9fe1be1@secure.kjonigsen.net> X-Migadu-Flow: FLOW_OUT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250273 Archived-At: Jostein Kj=C3=B8nigsen writes: > On 08.12.2022 11:12, Theodor Thornhill wrote: >> Jostein Kj=C3=B8nigsen writes: >> >>> When I use the new csharp-ts-mode, method fontification is usually accu= rate with only 1 exception which I have >>> encountered so far: >>> >>> When calling methods on objects, and that method accepts a generic type= -argument. You typically see this in >>> Startup.cs-like files in ASP.Net Core projects: >>> >>> services.AddSomeExtensionWithoutTypeArguments(); >>> services.AddSomeExtensionWithTypeArguments(); >>> >>> In the above cases we see that fontification of "services" differs. >>> >>> For the first line, services is fontified using font-lock-variable-name= -face (correct), but in the latter case services >>> is fontified using font-lock-function-name-face (incorrect). >>> >>> In both cases I expected services to be fontified using font-lock-varia= ble-name-face. >>> >> Can you test this patch, Jostein, and if you're happy, please install, >> Yuan :-) > > I beat you by 3 minutes, but I'll be a gentleman and test none the less :D > > You test mine, and we can see which one we prefer? Sure! Both seems to work from what I can tell :-) I'll let you be the judge! Theo