From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#61053: 29.0.60; typescript-ts-mode does not correctly highlight function-valued variables. [PATCH] Date: Wed, 25 Jan 2023 13:06:16 +0100 Message-ID: <87r0vi95tz.fsf@thornhill.no> References: Reply-To: Theodor Thornhill Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10899"; mail-complaints-to="usenet@ciao.gmane.io" Cc: jostein@kjonigsen.net, 61053@debbugs.gnu.org To: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 25 13:08:03 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pKeZO-0002bD-Em for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 25 Jan 2023 13:08:02 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pKeYh-0006S2-Cz; Wed, 25 Jan 2023 07:07:19 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKeYV-0006NJ-94 for bug-gnu-emacs@gnu.org; Wed, 25 Jan 2023 07:07:08 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pKeYQ-00068j-L4 for bug-gnu-emacs@gnu.org; Wed, 25 Jan 2023 07:07:05 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pKeYQ-0000qn-8g for bug-gnu-emacs@gnu.org; Wed, 25 Jan 2023 07:07:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Theodor Thornhill Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Jan 2023 12:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61053 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 61053-submit@debbugs.gnu.org id=B61053.16746483853195 (code B ref 61053); Wed, 25 Jan 2023 12:07:02 +0000 Original-Received: (at 61053) by debbugs.gnu.org; 25 Jan 2023 12:06:25 +0000 Original-Received: from localhost ([127.0.0.1]:58500 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKeXo-0000pT-Qy for submit@debbugs.gnu.org; Wed, 25 Jan 2023 07:06:25 -0500 Original-Received: from out0.migadu.com ([94.23.1.103]:33968) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKeXk-0000p8-Ls for 61053@debbugs.gnu.org; Wed, 25 Jan 2023 07:06:22 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1674648378; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o67+eihlWVZ5Ojo1eMVYw4sDp+mQ0PjdAOCHpS8GVk4=; b=KLp71lWUs+vfaWIrypmNhlAynIlx08lDuohkFayVMrwzOY6LWBBSq0gcrY9YTbPsfTdl4J 8xqMohpiZUfMVku9HlXeHdMuxKsQqXbnOBCSscXuAtyaEEGkNUStFrP4aqvCXVo6GoW79z TfivfKcpgsuk2kULC4MI1WjUXNtg7do1iP9WSFndBZ60TKPyEQpF1/N+VHxPPrjnDTWM1a 4iFszKCrCd5y3qGAXEF+wNL5TUDb0CeEXnTPsSnd1X2ROt82hJWl1mD/kUxGVoMP4vnyNc SpB5sFLXT7gC+RyRV2ibkG4H1XzgFGMVRZkWusmkeXAlt0g/JN6Trf72xJXtWg== In-Reply-To: ("Jostein =?UTF-8?Q?Kj=C3=B8nigsen?="'s message of "Wed, 25 Jan 2023 10:41:23 +0100") X-Migadu-Flow: FLOW_OUT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254112 Archived-At: Jostein Kj=C3=B8nigsen writes: > When working with codebases where people define functions by assigned arr= ow-expressions to local variables, > typescript-ts-mode (and tsx-ts-mode) currently does not highlight them as= function declarations. > > // this works > function demoFunction() { > } > > // this doesnt > const demoFunction =3D () =3D> { > }; > > We actually have a selector for this, but it is not getting triggered, be= cause of what looks like ordering issues. > > We also have override :t for almost every single feature in this mode, ma= king it hard to know how selectors gets > applied. > > Attached is a patch whic: > > 1. reorders selectors to correctly highlight function-declaration (requir= ed change, but not sufficient) > 2. disables override everywhere, except for declaration, in order to keep= fontification correct. > > So far I haven't been able to observe any ill side-effects from this chan= ge, but it might be worth double-checking. > Thanks, Jostein! Looks like it works on my end aswell. Applied and pushed, so closing this. Keep them coming :) Theo