From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: 29.0.60; keymap-local-set and keymap-global-set became less strict Date: Tue, 31 Jan 2023 16:02:21 +0100 Message-ID: <87r0vaoigy.fsf@gmail.com> References: <5876987d-2479-f512-5767-218c8c16a909@daniel-mendler.de> <875ycngyji.fsf@gnus.org> <87zg9zvzuc.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5087"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen , Daniel Mendler , emacs-devel@gnu.org, Eli Zaretskii To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jan 31 16:02:53 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pMs9s-0000vh-N8 for ged-emacs-devel@m.gmane-mx.org; Tue, 31 Jan 2023 16:02:52 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pMs9V-0000Ue-GE; Tue, 31 Jan 2023 10:02:29 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMs9T-0000Qa-CM for emacs-devel@gnu.org; Tue, 31 Jan 2023 10:02:27 -0500 Original-Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pMs9R-0001F7-8H; Tue, 31 Jan 2023 10:02:27 -0500 Original-Received: by mail-wm1-x32c.google.com with SMTP id hn2-20020a05600ca38200b003dc5cb96d46so3710840wmb.4; Tue, 31 Jan 2023 07:02:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=mPWtFGw/OFMsKY38Fsoy8uyXmjTpcu76CzlxLA2V0Wo=; b=BWjGRtOO7YS63BFCsDlSrIcSwO2FuKYOZqJwEmOappc9mwvehK7grdVBaamoQzrl8n bjPZ2HcWq1popUcbnBQuYzP/1e1vS/d1z/e+PPGpKABm2AVs0lhTlz0bm+fvYJraAKIy 5pt2wJ4U8Sdya6Z4UjGGQOP0CiqBPqdY2tD+qBVKKJ1LEoaGVkDNyZPEUmnG4u+zybtw 4lcXsigSaqzZ8yALy/+1hSI66VrnLtBsJVV/JADNvqgYu2pP8HgTh7GIpefWxkSihqb8 8kV6A/KyQXKrRNriw77EHx3VmybxohlU39xz6ZAcASyNNqNLvm5POkMURPY337sUEVEi aeuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mPWtFGw/OFMsKY38Fsoy8uyXmjTpcu76CzlxLA2V0Wo=; b=HKlSadx4KHT0X56Qh/Eow6+6lbby3tMGuq2ffbKHKAYdes7QtJvHt29F2DJyr0fO0f qrzCTuUatyomNZr9Dk8DP+jw6q3SjyjBMvFsahpQmAG9EsHtFAPVT1AUtFKpX2C1rwTE pSzJTADqgO1nwoaJo3vp+xOqe/fpxKAmR4M/XlhxX7kNoS7GzyQVdVBmdwkE81m5Zy/T zz1IkFmGHOpOcapM/3z9UfP7ARViS1rnvJehtwLURDrsDmOjXMEKXURoJJtGq7hgeGIN 3/80oeHpaTkuaxHPfQMBDJN0njuNCHl6yAE2FBREF30OcoNb+lDjv4WfcNqNQ/V56Ilt 9gyQ== X-Gm-Message-State: AFqh2krPWK5ZezWNGiJFIclO3vFxvQgiyDKrSa/rbZagoyfaXF6La8S4 E+zjQI6UgyYYD0AMHiaS0pQaK7ZO+1Y= X-Google-Smtp-Source: AMrXdXuIoTTnoHcAPo3hKiYNBoTIcgTrBl2L+d/hnMCiByXyax2weLUxhnQfjqvZLxq8IKhoZodwng== X-Received: by 2002:a05:600c:3c86:b0:3da:2a59:8a4f with SMTP id bg6-20020a05600c3c8600b003da2a598a4fmr54626103wmb.38.1675177342881; Tue, 31 Jan 2023 07:02:22 -0800 (PST) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id g10-20020a05600c310a00b003dc4480df80sm12747109wmo.34.2023.01.31.07.02.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Jan 2023 07:02:22 -0800 (PST) In-Reply-To: (Stefan Monnier's message of "Tue, 31 Jan 2023 09:30:04 -0500") Received-SPF: pass client-ip=2a00:1450:4864:20::32c; envelope-from=rpluim@gmail.com; helo=mail-wm1-x32c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:302833 Archived-At: >>>>> On Tue, 31 Jan 2023 09:30:04 -0500, Stefan Monnier said: >> --- i/lisp/keymap.el >> +++ w/lisp/keymap.el >> @@ -76,9 +76,14 @@ keymap-global-set >> that local binding will continue to shadow any global binding >> that you make with this function." >> (declare (compiler-macro (lambda (form) (keymap--compile-check key) = form))) >> - (interactive "KSet key globally:\nCSet key %s globally to command= : ") >> - (unless (stringp key) >> - (setq key (key-description key))) >> + (interactive >> + (let* ((menu-prompting nil) >> + (cursor-in-echo-area t) >> + (key (key-description (read-key-sequence-vector "Set key = globally:" nil t)))) >> + (list key >> + (let ((cursor-in-echo-area nil)) >> + (read-command (format "Set key %s to command: " >> + key)))))) >> (keymap-set (current-global-map) key command)) >>=20 >> (defun keymap-local-set (key command) >> @@ -91,12 +96,17 @@ keymap-local-set >> The binding goes in the current buffer's local map, which in most >> cases is shared with all other buffers in the same major mode." >> (declare (compiler-macro (lambda (form) (keymap--compile-check key) = form))) >> - (interactive "KSet key locally:\nCSet key %s locally to command: = ") >> + (interactive >> + (let* ((menu-prompting nil) >> + (cursor-in-echo-area t) >> + (key (key-description (read-key-sequence-vector "Set key = locally:" nil t)))) >> + (list key >> + (let ((cursor-in-echo-area nil)) >> + (read-command (format "Set key %s to command: " >> + key)))))) Stefan> Please put that code in a separate function so as to avoid Stefan> this duplication. MoooooM, Stefan is making me clean up *before* I=CA=BCve finished! =F0=9F= =98=80 Robert --=20