From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id mCWOHZ4ZAmS0fgAAbAwnHQ (envelope-from ) for ; Fri, 03 Mar 2023 17:00:30 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id oAWhHZ4ZAmRiWAAA9RJhRA (envelope-from ) for ; Fri, 03 Mar 2023 17:00:30 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 162162F83A for ; Fri, 3 Mar 2023 17:00:30 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=aIPLIyTE; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1677859230; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=hVoIVaiMRepA8bGoDKByaxtL02mFdWOd3R6sKowkHZE=; b=DZUoP4U5p9/BDTa4mbMpR1Jx6n0VX0OD2VHqbRaKLQj09mW4UVjf5fiGCUPZGy0aqHomri 2DzUZOjHvsc2gFRYc0FVgEn3+9C8/ge+qfLXbDWSVLB78NpjLXquD2OCPpcfeVfR3gLBrx IfRilLGbzlAC8pHYcD/Dc4z1GNzmcMTfCucQfp24XhIc35gMtdc0g4BMhZ8f7gfyj7IWhj Di3kMUPUqCBd1Enr01bhRFdNxOxS05bbBgqn2gxclK1Wdo91OPj/dEG+prkjzRJVAlByRc H4Rsj2tfcHPpwDJLaeJYmgxb/KxAfgL1iZgfxCw2L71pPSo5OxRlwd3+9r4EnA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=aIPLIyTE; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Seal: i=1; s=key1; d=yhetil.org; t=1677859230; a=rsa-sha256; cv=none; b=NUXF34arNZgz4YpqMXEV0txJLdC6VzhpdDeIs2BlVu3Y95nVco0Yp928FhSPq5piSU3HGM igAfFOsN1ZFFbDreCyXRRPpFs3YOUGKn7FMtn+Tu/HiEckyNYE7AmVfGEsfIRNBsptWl6q eFFv0XQimoAcN8K3zW6pE/0PusZhAD0EwPbZg8j/WO6fi47YYHdQ2aRMRVcMQzU36IMoVJ zJ06atx7br0jutlo0uYPz3K4q0nwcB+hagdVSUbFWP+QFq2GiC3YCmyuhfAQgoWtZD88oq LJ6e6gLmwQN0uWMnA/P4XbMRB9S/FyylWQ/m/DCxMahqmTWE1NsfkUmxoHcfPw== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pY7oj-0000un-SC; Fri, 03 Mar 2023 10:59:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pY7oh-0000ud-FD for emacs-orgmode@gnu.org; Fri, 03 Mar 2023 10:59:32 -0500 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pY7of-0002m8-4X for emacs-orgmode@gnu.org; Fri, 03 Mar 2023 10:59:31 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 8E1CE240A51 for ; Fri, 3 Mar 2023 16:59:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1677859166; bh=5wk+nYuAlkTCmFoiAvkwgKI1lj4t/l9EJDVgqDXER0U=; h=From:To:Cc:Subject:Date:From; b=aIPLIyTEZWijLqyXeNin4PmsMS/HfRM7lCYOg329ovMalnN1rhJpGyTPhUUwCndZ4 xqz0PigSqmb/2iiKY06Jo1jycKpSU86SFUCZIApTivxj7U8Jr2DFGNDMfxkwshdoEi ogHY1J30iG+X1dxiiVKF/JqRNSD9/CSu8iQq+klslY5p4cTj0dRaRVFpRrse4TZCHQ RD5sIh90w58PMnuHgo84jCa4Qy9pI+ZQo0dfmfncU4YP5MzryDZVxzD6jEku9pbYob qy7bHoZilw+zbEVe1UHdWTGvSuESWTj9kOcuI26mC9ksXuGunuvbZYX7a5i2nb4zR2 DqGmR6sy5bdHA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4PSt2Q0KKFz9rxL; Fri, 3 Mar 2023 16:59:26 +0100 (CET) From: Ihor Radchenko To: Max Nikulin , Rudolf =?utf-8?Q?Adamkovi=C4=8D?= Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] org-clock: Add a trailing space to the mode line string In-Reply-To: References: <20230302141443.7842-1-salutis@me.com> Date: Fri, 03 Mar 2023 16:00:14 +0000 Message-ID: <87r0u54ygh.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: X-Migadu-Spam-Score: -5.99 X-Spam-Score: -5.99 X-Migadu-Scanner: scn0.migadu.com X-Migadu-Queue-Id: 162162F83A List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-TUID: Lu7rTOOsyWpE Max Nikulin writes: > On 02/03/2023 21:14, Rudolf Adamkovi=C4=8D wrote: >> +++ b/lisp/org-clock.el >> @@ -728,9 +728,9 @@ If not, show simply the clocked time like 01:50." >> 'org-mode-line-clock-overrun >> 'org-mode-line-clock))) >> (effort-str (org-duration-from-minutes effort-in-minutes))) >> - (format (propertize " [%s/%s] (%s)" 'face 'org-mode-line-clock) >> + (format (propertize " [%s/%s] (%s) " 'face 'org-mode-line-clock) > > Previous discussion of spaces in mode-line: > > Ihor Radchenko to emacs-orgmode=E2=80=A6 Re: Weird gap in agenda mode-lin= e. Sun,=20 > 14 Nov 2021 15:52:31 +0800.=20 > https://list.orgmode.org/87k0hbdvi8.fsf@localhost > > It seems agenda components use leading spaces but no trailing ones. I am= =20 > not familiar with mode line formatting, so it may be a false alarm. It is because they are a part of mode string. Leading space is a convention for minor modes. M-x display-time-mode does the opposite - trailing space. Rudolf, I am OK with the patch, but could you please add a comment explaining why trailing space, so that people do not wonder in future? --=20 Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at