all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@posteo.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 62048@debbugs.gnu.org
Subject: bug#62048: 30.0.50; Non-nil `line-spacing' takes precendence over 'line-height t text property
Date: Sat, 11 Mar 2023 11:10:10 +0000	[thread overview]
Message-ID: <87r0tvwnl9.fsf@localhost> (raw)
In-Reply-To: <83zg8m15n5.fsf@gnu.org>

Eli Zaretskii <eliz@gnu.org> writes:

>> Observed: top of the image is displayed
>> Expected: bottom of the image is partially revealed
>
> I don't understand the expectation.  Scrolling by vscroll only happens
> when before the scroll some part of the image is visible, which is not
> what happens here.
>
> If you want to change that, feel free to hack on the code in
> simple.el, but there was no intent to cover this particular use case,
> and the code is already quite complicated (to say the least).
> ...
> You should always keep in mind that Emacs has no idea about what's
> beyond the window, for display purposes.  There's no way of saying
> whether a given 'display property whose value is an image spec will be
> taller than the window, except by actually displaying that image (or
> at least simulating the display internally).  So you expect something
> that it is far from easy to do.
>
> Scrolling commands were never meant to allow smooth scrolling through
> tall screen lines.

What if the code instead tries to vscroll standard line height first and
only then decide if we want to scroll further, displaying tall line?

> What do you want to customize, and in what terms?

I was referring to

>> 	      (if (and (< arg 0)
>> 		       (< (point) (window-start))
>> 		       (> lh winh))
>> 		  (set-window-vscroll
>> 		   nil
>> 		   (- lh dlh) t)))

May we allow users to customize ~(> lh winh)~ condition?
By providing a custom setting that will determine the threshold for
partial scroll: `line-move-height-threshold'. The default value will be
'window making lines taller than window height to trigger partial
scroll. Alternative values could be a subset of pixel specs, like (NUM)
or (X . UNIT).

Also, on the initial report. Is it possible to increase default
buffer-wise line-spacing via text property? (AFAIU, decreasing is
impossible).

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>





  reply	other threads:[~2023-03-11 11:10 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-08 12:18 bug#62048: 30.0.50; Non-nil `line-spacing' takes precendence over 'line-height t text property Ihor Radchenko
2023-03-08 17:31 ` Eli Zaretskii
2023-03-08 18:26   ` Ihor Radchenko
2023-03-08 19:50     ` Eli Zaretskii
2023-03-08 20:39       ` Ihor Radchenko
2023-03-09  6:54         ` Eli Zaretskii
2023-03-09  9:13           ` Ihor Radchenko
2023-03-09  9:47             ` Eli Zaretskii
2023-03-09 10:55               ` Ihor Radchenko
2023-03-09 12:16                 ` Eli Zaretskii
2023-03-11 11:10                   ` Ihor Radchenko [this message]
2023-03-11 12:28                     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r0tvwnl9.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=62048@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.