[BUG] ob-js "SyntaxError: Unexpected end of input" when code block ends with comment

[BUG] ob-js "SyntaxError: Unexpected end of input" when code block ends with comment

[sgherdao--- via General discussions about Org-mode.]

[-- Attachment #1: Type: text/plain, Size: 2105 bytes --]

Hello,

I would like to report a bug, I am using the following versions

GNU Emacs 28.2
Org mode version 9.6.1
Node v19.9.0


The following code snippet fails to execute

#+begin_src js
console.log("Hello Friends!");
// -> logs "Hello Friends"
#+end_src

I encounter the following error message:

#+begin_src text
/tmp/js-script-dn2Wrp:2
// -> logs "Hello Friends"}()));

SyntaxError: Unexpected end of input
    at internalCompileFunction (node:internal/vm:73:18)
    at wrapSafe (node:internal/modules/cjs/loader:1195:20)
    at Module._compile (node:internal/modules/cjs/loader:1239:27)
    at Module._extensions..js (node:internal/modules/cjs/loader:1329:10)
    at Module.load (node:internal/modules/cjs/loader:1133:32)
    at Module._load (node:internal/modules/cjs/loader:972:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:83:12)
    at node:internal/main/run_main_module:23:47
#+end_src


Upon further inspection, I found that the generated JavaScript code in the tmp file contains an unbalanced brace and parentheses, as shown below:


#+begin_src js
require('process').stdout.write(require('util').inspect(function(){console.log("Hello Friends!");
// -> logs "Hello Friends"}()));
#+end_src


Since the last line of the code snippet contains a comment the brace and parens are unbalanced
This seems to point to the way the following variable is defined in ob-js.el


#+begin_src emacs-lisp
(defvar org-babel-js-function-wrapper
  "require('process').stdout.write(require('util').inspect(function(){%s}()));"
  "Javascript code to print value of body.")
#+end_src

As a simple fix, I have added a \n after %s

#+begin_src emacs-lisp
(defvar org-babel-js-function-wrapper
  "require('process').stdout.write(require('util').inspect(function(){%s\n}()));"
  "Javascript code to print value of body.")
#+end_src


Please let me know if you need any additional information or if there's anything else I can do to help resolve this issue.


Best regards,
--
Salah


[-- Attachment #2: Type: text/html, Size: 4003 bytes --]

Re: [BUG] ob-js "SyntaxError: Unexpected end of input" when code block ends with comment

[Ihor Radchenko]

sgherdao--- via "General discussions about Org-mode."
<emacs-orgmode@gnu.org> writes:

> The following code snippet fails to execute
>
> #+begin_src js
> console.log("Hello Friends!");
> // -> logs "Hello Friends"
> #+end_src
>
> I encounter the following error message:
>
> #+begin_src text
> /tmp/js-script-dn2Wrp:2
> // -> logs "Hello Friends"}()));
>
> SyntaxError: Unexpected end of input
> ...
> As a simple fix, I have added a \n after %s
>
> #+begin_src emacs-lisp
> (defvar org-babel-js-function-wrapper
>   "require('process').stdout.write(require('util').inspect(function(){%s\n}()));"
>   "Javascript code to print value of body.")
> #+end_src

Thanks for reporting and providing a fix!
Fixed, on bugfix.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=7d8a9324f

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: [BUG] ob-js "SyntaxError: Unexpected end of input" when code block ends with comment

[sgherdao--- via General discussions about Org-mode.]

[-- Attachment #1: Type: text/plain, Size: 1245 bytes --]

Happy to help and thanks for fixing it so quickly:)
Best regards,
--
Salah 



Apr 17, 2023 at 12:10 by yantar92@posteo.net:

> sgherdao--- via "General discussions about Org-mode."
> <emacs-orgmode@gnu.org> writes:
>
>> The following code snippet fails to execute
>>
>> #+begin_src js
>> console.log("Hello Friends!");
>> // -> logs "Hello Friends"
>> #+end_src
>>
>> I encounter the following error message:
>>
>> #+begin_src text
>> /tmp/js-script-dn2Wrp:2
>> // -> logs "Hello Friends"}()));
>>
>> SyntaxError: Unexpected end of input
>> ...
>> As a simple fix, I have added a \n after %s
>>
>> #+begin_src emacs-lisp
>> (defvar org-babel-js-function-wrapper
>>   "require('process').stdout.write(require('util').inspect(function(){%s\n}()));"
>>   "Javascript code to print value of body.")
>> #+end_src
>>
>
> Thanks for reporting and providing a fix!
> Fixed, on bugfix.
> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=7d8a9324f
>
> -- 
> Ihor Radchenko // yantar92,
> Org mode contributor,
> Learn more about Org mode at <https://orgmode.org/>.
> Support Org development at <https://liberapay.com/org-mode>,
> or support my work at <https://liberapay.com/yantar92>
>


[-- Attachment #2: Type: text/html, Size: 2067 bytes --]