From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.devel Subject: Re: Is it valid to call isearch-filter-predicate outside isearch? Date: Wed, 31 May 2023 12:56:16 +0000 Message-ID: <87r0qwk6bz.fsf@localhost> References: <875y8nks9t.fsf@localhost> <86pm6sb5g8.fsf@mail.linkov.net> <87ttvsn77s.fsf@localhost> <83edmwfz6p.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6682"; mail-complaints-to="usenet@ciao.gmane.io" Cc: juri@linkov.net, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed May 31 14:52:54 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q4LJu-0001Wn-0G for ged-emacs-devel@m.gmane-mx.org; Wed, 31 May 2023 14:52:54 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q4LJG-0005gY-1C; Wed, 31 May 2023 08:52:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q4LJC-0005g2-FI for emacs-devel@gnu.org; Wed, 31 May 2023 08:52:10 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q4LJ8-0006CA-Ar for emacs-devel@gnu.org; Wed, 31 May 2023 08:52:08 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id AC1BF240027 for ; Wed, 31 May 2023 14:52:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1685537524; bh=B/DP4FCUlGl1GtwXcEV8xPGS/QkSiqHXUPun9YZZdn0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=eG9iuGaNdL+aaj7aKAAZbS7p9b+q6lwrNFKZTgPRFNALK/LACo8jmNf+tHkQfGVaA tf1XG9ZDL8NBiZLHYOtFqc2kABZzZNUmp6Rtf23qQPwU8699m7+aRytO75DUjZ9wEO cCqSZSXdxQduYGUjDZ+zZgLr7BfHpd/YmbEwbQH5o8ulE62VKio+aLnmnQOsx2+2Y2 1tjjA66uxxvq/wBOVw025Swn8irV0OCaRQPBHcy+5S65t85LXjcnJlW5HofU6kocAx RUozz8sKEKnidnIJXvL69aXmIhLrMDbZ38HOMARam/S2Bm1i5ZqF/RuXpi7XWiagD9 x4YdNhgFZbrjw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4QWTg81mpXz6tvk; Wed, 31 May 2023 14:52:04 +0200 (CEST) In-Reply-To: <83edmwfz6p.fsf@gnu.org> Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:306441 Archived-At: Eli Zaretskii writes: >> It would be nice if the docstring of `isearch-filter-predicate' >> mentioned that it might be called outside isearch-mode. > > I don't really understand what you are asking here to document. From > reading the discussion, it sounds like you set > isearch-filter-predicate to a function that relies on some > (unidentified) isearch hooks to undo its side effects? And you did > that without studying all of the existing callers of > isearch-filter-predicate? Not sure how documentation could have > solved this for you. I expected `isearch-filter-predicate' to be only used by isearch in isearch-mode. And thus I expected `isearch-mode-end-hook' to be called later. Isn't it a natural expectation? > In general, a predicate is not expected to have side effects, it is > expected to return a boolean value and leave everything else intact. > > (I also don't understand what does isearch-range-invisible have to do > with this.) `isearch-range-invisible' can modify `isearch-opened-overlays' and `isearch-hidden' by side effect. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at