From: Philip Kaludercic <philipk@posteo.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 64242@debbugs.gnu.org, Daniel Semyonov <daniel@dsemy.com>
Subject: bug#64242: [PATCH] Fix VC package build when there is no docs dir
Date: Fri, 23 Jun 2023 07:35:06 +0000 [thread overview]
Message-ID: <87r0q2r5qt.fsf@posteo.net> (raw)
In-Reply-To: <83zg4q1woh.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 23 Jun 2023 10:10:06 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Daniel Semyonov <daniel@dsemy.com>
>> Cc: 64242@debbugs.gnu.org
>> Date: Fri, 23 Jun 2023 09:32:01 +0300
>>
>> >>>>> Eli Zaretskii writes:
>>
>> > What do you mean by "isn't a directory"? FILE is supposed to be a
>> > documentation file, not a directory, see the doc string of this
>> > function. Do you mean that FILE is a relative file name so that
>> > file-name-directory returns nil for it? If so, I think the
>> > correct fix would be to reverse the order:
>>
>> > (docs-directory (file-name-directory (expand-file-name file)))
>>
>> Yeah, you're completely right, this was a misunderstanding on my part;
>> my fix just happened to also work so I made some incorrect assumptions.
>>
>> After some further testing, this seems to happen for packages for which
>> the doc file is in the base directory of the package (which causes
>> 'file-name-directory' to return nil as the doc file name is relative to
>> the package dir).
>>
>> I attached an updated patch.
>>
>> > Can you show a recipe to reproduce this problem, preferably
>> > starting from "emacs -Q"?
>>
>> 1. $ emacs -Q
>> 2. M-x package-vc-install RET eat RET
>> 3. A few seconds later,
>> "package-vc--unpack-1: Wrong type argument: stringp, nil"
>>
>> > And finally, this issue exists on the emacs-29 release branch as
>> > well, doesn't it?
>>
>> I haven't tested it, but I don't see a reason it wont.
>
> Philip, any comments or objections to installing this on the emacs-29
> branch?
I have none. There were just come complains last time, because we made
the change too soon, so I believe the consensus was to wait for a bit
longer and then it was just forgotten.
> Thanks.
next prev parent reply other threads:[~2023-06-23 7:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-23 5:45 bug#64242: [PATCH] Fix VC package build when there is no docs dir Daniel Semyonov via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-23 6:02 ` Eli Zaretskii
2023-06-23 6:32 ` Daniel Semyonov via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-23 7:10 ` Eli Zaretskii
2023-06-23 7:35 ` Philip Kaludercic [this message]
2023-06-24 10:24 ` Philip Kaludercic
2023-06-24 10:43 ` Eli Zaretskii
2023-06-24 15:34 ` Philip Kaludercic
2023-06-24 17:07 ` Eli Zaretskii
2023-06-25 21:41 ` Philip Kaludercic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0q2r5qt.fsf@posteo.net \
--to=philipk@posteo.net \
--cc=64242@debbugs.gnu.org \
--cc=daniel@dsemy.com \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.