From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] notifications: Don't expand-file-name app-icon. Date: Wed, 26 Jul 2023 09:05:04 +0200 Message-ID: <87r0ov40gv.fsf@gmx.de> References: <877cqpsnct.fsf@trop.in> <83fs5dsd0g.fsf@gnu.org> <87zg3kk3jw.fsf@trop.in> <837cqoqjy7.fsf@gnu.org> <379c4b8a-db49-06b3-f313-91e550c8c14c@gutov.dev> <87y1j4jego.fsf@trop.in> <83jzuoozn0.fsf@gnu.org> <5a944e55-1c49-35d0-e554-eaf7ca42df7e@gutov.dev> <837cqnq48p.fsf@gnu.org> <87v8e74xm2.fsf@gmx.de> <831qgvpzpu.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1566"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: dmitry@gutov.dev, andrew@trop.in, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jul 26 09:06:19 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qOYbB-000AaI-6H for ged-emacs-devel@m.gmane-mx.org; Wed, 26 Jul 2023 09:06:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qOYaA-00055h-4f; Wed, 26 Jul 2023 03:05:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qOYa8-00055O-Oz for emacs-devel@gnu.org; Wed, 26 Jul 2023 03:05:12 -0400 Original-Received: from mout.gmx.net ([212.227.15.19]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qOYa7-00089Y-2J; Wed, 26 Jul 2023 03:05:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1690355105; x=1690959905; i=michael.albinus@gmx.de; bh=1/ithr7UgJBXcp0x5ikxIyX+NSjf2J4RKQvGgND0ACM=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=oh2IvZmjDT8gf6sDb7FC6ztIKAVo7gMSUWq4ug0pkBZ1BJnffAHlW/RyL4+wpXzYknRMc1v RK4jsHh9pE7gACeVzbNmNccaS1EYVaBakq9Rf7fxcrkLH73/UEVw3nCEhrMGmtuGTGx43dk5/ AtpKtwocxDgUCXjSyeCf8+tQHwpg+y9iaQmEMInhVYx55Ymzd74li0kNGXxQJy1nmKLU9YgzZ 6kygwGCJgjgOOT1pfaGtTiI7++a78EoWrePeYhxVWTtN6RFmFEDH5Vy9BlX1Ag7gvrIxVrrEF BXaTq0jKvf64fixmzxWyjt6bANeciFkEKiT3AjKI88gJuKzozQuw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from gandalf.gmx.de ([185.89.39.27]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MvsEn-1pZTWw2Gu7-00svgA; Wed, 26 Jul 2023 09:05:05 +0200 In-Reply-To: <831qgvpzpu.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 25 Jul 2023 22:18:05 +0300") X-Provags-ID: V03:K1:5Aj8GvJ+A8oqEiMOf5+bbpAKSBfHfmfzzc2Tmo/24wlEBgulF0g W2Jra3n4celSsMWKDN3NxyuUYB8xIeMN20ttYrMxPPN4jZ067luPi8WhdxbB+CXr6BNltDe bMca6kBiu1l2QBZTYZYk9b+PLyuq/FN1f3vPojY+jvuJl6YXwFR4C1HG5RdOhWHJruEGmc+ Ef7Tl1axtzUM2hi6MABOw== UI-OutboundReport: notjunk:1;M01:P0:aGHYryHLbkQ=;aPi4o1sgHBGIwN9qhF7mkKGjmxK AvmSanDXQ0K99spQnr7jlHlJT7pY9RmuXIfB4+7fpnYh6gqx+thne6sKQ+4r3y/0AY59Y3+Au 3AjGVVUtuGiZI7YzhoI8PBlq7E8JWMdMLqPaNg8keS+dfNGSzeJj0XIWHa/rmOhsTuneYyjph 1ROPM8EOrC1tPx31YRiYVPjwKFC5KgxlvZMEIfwJkf22LA2Ksv177RjetwdrjNCJ3vYl4S1Ux 2RY4cK91TLafbpBITBhuTs6GwUKRq3MZHk4c39s2q7Z8VKNbSt2QNCgNjaURpfCPUQrA07+Zo PmPR0KlWHQTbueAXzDVmOcDsG7zGfa0GLxQUoPPHBvk70ftFv5B7rpyZCA8BQPDWHPAfnmvg+ jb2fPERUZMOdpO8/OwgG3QDp6upwFOUmZelEQ/QDuysESbKVUxzDtLb1hnvXBrt5+OR/7GolN BQBAKiTyba7RZHidhrwYSnYXnpmubF9fXGbI8VAnBn2OANXr3Sd3qMQlfDfzOpWO8O4Vl0/YS MCRLquCgEa2HK1EzAbMNV1J8XeF9k76fPaELqvFZe0R4cqzvjKeL8i/FhCxsBTpcqwS5ko3G4 +A0nKM8qh5HoFVRrEJeEWaDWHEPgOCqTrgam/Sv1QwSHgXNRZcDlrdDrMWDN+Eqfvc/KvAf3e woeyhxky+H+xbGGXr3abwnjwO7CewGuObxapRHWQ1VMCcNWR51Gx5/VLDOm1jzKs1z0ag+KIM wpe+P2vGTz5ko1+kwwnJsKBp3qlsgW+r5O8qTBfD36/JAMyGO3tP/3DONDnb6IV22pIAdU7d Received-SPF: pass client-ip=212.227.15.19; envelope-from=michael.albinus@gmx.de; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:308110 Archived-At: Eli Zaretskii writes: Hi Eli, >> >> If it does not, then the current code is already wrong, isn't it? >> > >> > No, it could be working by sheer luck. >> >> As always with relative file names: the caller is responsible to use a >> proper default-directory. What else? > > Wait a minute. The icon's file is not processed by Emacs, right? We > pass it to an external program/library/service, right? We pass it to an external service via a D-Bus call. > If the file is processed by Emacs itself, then Dmitry is right: the > call to expand-file-name is redundant. But if the file is processed > by some software outside Emacs, then it is not redundant, because that > external software will handle non-absolute file names as relative to > the cwd of the Emacs process, not to the default-directory of the > buffer that is current when this code runs. Processing D-Bus calls means, there is no knowledge by the daemon about the cwd of the sender. > My assumption was that it's the latter: we pass the file name to some > external software. If that is not the case, then I wonder why > expand-file-name was there to begin with. There was always a good reason to do so. Best regards, Michael.