From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: package-autosuggest Date: Wed, 30 Aug 2023 19:26:38 +0000 Message-ID: <87r0nks55d.fsf_-_@posteo.net> References: <87il9kksqz.fsf@dfreeman.email> <4874df51-9652-f9fd-0576-9dd6a4cba31a@gutov.dev> <3d5ef276-ce6b-9ff0-0c60-1da6b887b365@gutov.dev> <1070e416-2a13-49e0-90d4-fbc526cd461c@app.fastmail.com> <83ttskia84.fsf@gnu.org> <97c96b72-ebba-4853-98d2-86e3ba8bbc05@app.fastmail.com> <83sf84i9ix.fsf@gnu.org> <837cpfhzdm.fsf@gnu.org> <83zg2agjp8.fsf@gnu.org> <87ttshk3ns.fsf@posteo.net> <83il8whjig.fsf@gnu.org> <87fs40oiie.fsf@posteo.net> <838r9shgtz.fsf@gnu.org> <871qfkogy7.fsf@posteo.net> <835y4whd0m.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18684"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca, stefankangas@gmail.com, yandros@gmail.com, bozhidar@batsov.dev, dmitry@gutov.dev, rms@gnu.org, danny@dfreeman.email, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Aug 30 21:27:40 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qbQqp-0004d6-Iq for ged-emacs-devel@m.gmane-mx.org; Wed, 30 Aug 2023 21:27:39 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qbQq2-0000sV-4F; Wed, 30 Aug 2023 15:26:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbQq0-0000sN-3b for emacs-devel@gnu.org; Wed, 30 Aug 2023 15:26:48 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbQpu-0004M1-Tj for emacs-devel@gnu.org; Wed, 30 Aug 2023 15:26:47 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id DE174240029 for ; Wed, 30 Aug 2023 21:26:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1693423600; bh=LPw1SBKUoPKcuzzVvFJ/ODc3kBMBS1e1KPy/J28PbMM=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=Snk1f90zBmMpx67ppnFp9WYIbHeGm2ZyvbM4/KjrodJ+ArTxcIXrjCYnzkLk+UUl+ NwZ+fjuqNMFqsOm1Z+GcJW54lzlhWY9BejPen1pLcXXYleCJbhL8B64XhRCb/wHyml 6Opnsvvso/l7n5V5nW5b4083QIQJUXAYRxT1hxjBcgAOUEq0UQksV7Y/78bYPxw6cJ ae5f2fSGLkfbUenkig1s3Dn8eC2YrfxU1cK4GDoLDBUSPpAhlqmWWhuOxKgfmfoP4S oHbDAuvVtZGPkU8jH9uXkzFVzPEgcWdaOjdmmSwYPqbNCxVFzQaqQC3IrEZP/MsOQq leErLdmhspDiw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RbZ6R2DrMz9rxQ; Wed, 30 Aug 2023 21:26:39 +0200 (CEST) In-Reply-To: <835y4whd0m.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 30 Aug 2023 16:32:09 +0300") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:309553 Archived-At: --=-=-= Content-Type: text/plain Eli Zaretskii writes: >> From: Philip Kaludercic >> Cc: monnier@iro.umontreal.ca, stefankangas@gmail.com, yandros@gmail.com, >> bozhidar@batsov.dev, dmitry@gutov.dev, rms@gnu.org, >> danny@dfreeman.email, emacs-devel@gnu.org, manuel.uberti@inventati.org >> Date: Wed, 30 Aug 2023 12:25:20 +0000 >> >> Are there any other examples, where we would want to have minor modes >> for specific file types? These sorts of entries would probably have to >> be added manually. > > I don't know, maybe someone else has an idea. > >> I am glad to see that there is interest in this proposal. I can try and >> create an example of how this could work, and push it to a feature >> branch for further review, some time soon. > > I think this could be useful, yes. Here is a quick and rough draft of how this feature could look like: --=-=-= Content-Type: text/plain Content-Disposition: inline diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el index e1172d69bf0..723900318c5 100644 --- a/lisp/emacs-lisp/package.el +++ b/lisp/emacs-lisp/package.el @@ -4534,6 +4534,116 @@ package-get-version (or (lm-header "package-version") (lm-header "version"))))))))) + +;;;; Autosuggest + +(defvar package-autosuggest-database + '((sml-mode auto-mode-alist "\\.sml\\'") + (lua-mode auto-mode-alist "\\.lua\\'" ) + (ada-mode auto-mode-alist "\\.ada\\'") + ;; ... + ;; + ;; this is just for testing, in practice I think this data should + ;; be generated and bundled with Emacs, and would ideally be + ;; loaded in at compile-time. When the "archive-contents" file + ;; format is updated, we can include more information in there + ;; that would be added to this database. + ) + "Database of hints for packages to suggest installing.") + +(define-minor-mode package-autosuggest-mode + "Enable the automatic suggestion and installation of packages." + :init-value 'message :global t + (funcall (if package-autosuggest-mode #'add-hook #'remove-hook) + 'after-change-major-mode-hook + #'package--autosuggest-after-change-mode)) + +(defun package--suggestion-applies-p (pkg-sug) + "Check if a suggestion PKG-SUG is applicable to the current buffer." + (pcase pkg-sug + (`(,(pred package-installed-p) . _) nil) + ((or `(,_ auto-mode-alist ,ext _) + `(,_ auto-mode-alist ,ext)) + (and (string-match-p ext (buffer-name)) t)) + ((or `(,_ magic-mode-alist ,mag _) + `(,_ magic-mode-alist ,mag)) + (save-restriction + (widen) + (save-excursion + (goto-char (point-min)) + (looking-at-p mag)))) + ((or `(,_ interpreter-mode-alist ,magic _) + `(,_ interpreter-mode-alist ,magic)) + (save-restriction + (widen) + (save-excursion + (goto-char (point-min)) + (and (looking-at auto-mode-interpreter-regexp) + (string-match-p + (concat "\\`" (file-name-nondirectory (match-string 2)) "\\'") + magic))))))) + +(defun package--autosuggest-find-candidates () + "Return a list of packages that might be interesting the current buffer." + (and package-autosuggest-mode + (let (suggetions) + (dolist (sug package-autosuggest-database) + (when (package--suggestion-applies-p sug) + (push sug suggetions))) + suggetions))) + +(defun package--autosuggest-install-and-enable (pkg-sug) + "Install and enable a package suggestion PKG-ENT. +PKG-SUG has the same form as an element of +`package-autosuggest-database'." + (package-install (car pkg-sug)) + (with-demoted-errors "Failed to enable: %S" + (dolist (buf (buffer-list)) + (with-current-buffer buf + (when (and (eq major-mode 'fundamental-mode) (buffer-file-name) + (package--suggestion-applies-p pkg-sug)) + (funcall-interactively (or (cadddr pkg-sug) (car pkg-sug)))))))) + +(defvar package--autosuggest-suggested '() + "List of packages that have already been suggested.") + +(defun package--autosuggest-after-change-mode () + "Hook function to suggest packages for installation." + (when-let ((avail (seq-difference (package--autosuggest-find-candidates) + package--autosuggest-suggested)) + (pkgs (mapconcat #'symbol-name + (delete-dups (mapcar #'car avail)) + ", "))) + (pcase package-autosuggest-mode + ('always + (when (yes-or-no-p (format "Install suggested packages (%s)?" pkg)) + (mapc #'package--autosuggest-install-and-enable avail))) + ('once + (when (yes-or-no-p (format "Install suggested packages (%s)?" pkg)) + (mapc #'package--autosuggest-install-and-enable avail)) + (setq package--autosuggest-suggested (append avail package--autosuggest-suggested))) + ('message + (message + (substitute-command-keys + (format "Found suggested packages: %s. Install using \\[package-autosuggest]" + pkgs))))))) + +(defun package-autosuggest () + "Prompt the user for suggested packages." + (interactive) + (let* ((avail (or (package--autosuggest-find-candidates) + (user-error "No suggestions found"))) + (pkgs (completing-read-multiple + "Install suggested packages: " avail + nil t + (mapconcat #'symbol-name + (delete-dups (mapcar #'car avail)) + ","))) + (choice (concat "\\`" (regexp-opt pkgs) "\\'"))) + (dolist (ent avail) + (when (string-match-p choice (symbol-name (car ent))) + (package--autosuggest-install-and-enable ent))))) + ;;;; Quickstart: precompute activation actions for faster start up. --=-=-= Content-Type: text/plain The documentation is obviously lacking and incomplete, I just wanted to have a POC to discuss the idea. I am not sure if the default option 'message is still too aggressive, as opinions differ on how and who should print messages in the echo area. --=-=-=--