From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jonas Bernoulli Newsgroups: gmane.emacs.devel Subject: Adding with-editor to Emacs? Date: Fri, 01 Sep 2023 16:38:02 +0200 Message-ID: <87r0nidkmt.fsf@bernoul.li> References: <85msy98sni.fsf@elpa.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12839"; mail-complaints-to="usenet@ciao.gmane.io" Cc: rms@gnu.org To: emacs-devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Sep 01 17:23:27 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qc5za-00034Q-6h for ged-emacs-devel@m.gmane-mx.org; Fri, 01 Sep 2023 17:23:26 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qc5yw-0003QA-If; Fri, 01 Sep 2023 11:22:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qc5Hr-0007Qh-Rt for emacs-devel@gnu.org; Fri, 01 Sep 2023 10:38:15 -0400 Original-Received: from mail.hostpark.net ([212.243.197.30]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qc5Ho-0006OF-Kq; Fri, 01 Sep 2023 10:38:15 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id C262F164DD; Fri, 1 Sep 2023 16:38:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=bernoul.li; h= content-type:content-type:mime-version:message-id:date:date :references:in-reply-to:subject:subject:from:from; s=sel2011a; t=1693579085; bh=wHNZxN/ArIn3NQsiTnFkHHaH+SHTsmxXDrh1uXzMS8k=; b= yyIqg4OlCrkY0xpA85hgo67Q+jBiJP54YHlea2cVrcdDp8FJ1ygs2H2SnA1c9zcc ZsN5Q47QSp2+o/e4J41rQ4MYd9rBgh/KsRE4WTWVVH10HU288E5L09Kwi6so2vYz HqT0W3q3khvT8rxDDTfqsxRa/558oLSD56U11V3YYJE= X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Original-Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail0.hostpark.net [127.0.0.1]) (amavisd-new, port 10224) with ESMTP id aUBKlbRt8aWP; Fri, 1 Sep 2023 16:38:05 +0200 (CEST) Original-Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 7F3FE164B4; Fri, 1 Sep 2023 16:38:05 +0200 (CEST) In-Reply-To: Received-SPF: pass client-ip=212.243.197.30; envelope-from=jonas@bernoul.li; helo=mail.hostpark.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Fri, 01 Sep 2023 11:22:44 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:309811 Archived-At: Richard Stallman writes: > Are you involved in developing this? Yes, I am the primary author. Contributions by other people are pretty minor, or by people who have already done the copyright paperwork, so that should not be a problem. > It seems to me that this would fit best in emacsclient and its > associated Lisp code -- that having it as a separate package > is extra baggage. > > WDYT? Adding this to Emacs would make sense. We would have to determine to what extend existing code should be updated to do what this package does and what parts should remain in a package/library in its own right. For example, it would make sense to deprecate variable `server-window' with a new `server-window-alist', even if the rest of with-editor.el remained a separate library, or even outside of Emacs. (The new variable would give packages more control over how their windows should be displayed, if they have special needs, while still allowing users to customize the default, or even to override the packages' wishes.) I think the next step is to ask Eli and others, how they would want to integrate the library / the functionality it provides. An obstacle in getting this done quickly, is that I am getting requests to do work in areas that I wasn't planning on touching any time soon, with a higher than usual frequency. So the process of integrating this into Emacs could be somewhat slow, depending on how much we diverge from just merging this as-is in the form of a separate library/package. > having it as a separate package is extra baggage. Maybe. As far as adding `server-window-alist' goes, that would certainly be a win. But other than that, this package is basically "done" in its current form. Work is only really required when someone found yet another way to package Emacs, without thinking too much about emacsclient, if at all. So I must point out that the primary effect for my personally will be extra work, and not just in the short term. Cheers, Jonas