From: Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 64791@debbugs.gnu.org, Stefan Kangas <stefankangas@gmail.com>
Subject: bug#64791: 30.0.50; [PATCH] Fix dired mismatch on some filenames
Date: Mon, 04 Sep 2023 10:05:19 +0200 [thread overview]
Message-ID: <87r0netlc0.fsf@ledu-giraud.fr> (raw)
In-Reply-To: <83wmx75aad.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 03 Sep 2023 22:25:30 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Stefan Kangas <stefankangas@gmail.com>
>> Date: Sun, 3 Sep 2023 11:54:07 -0700
>> Cc: manuel@ledu-giraud.fr, 64791@debbugs.gnu.org
>>
>> Eli Zaretskii <eliz@gnu.org> writes:
>>
>> > What about making insert-directory-program a defcustom, so that people
>> > who have GNU ls under a name other than "ls" could customize that?
>>
>> We could do that. It wouldn't help my case unfortunately, as I'm using
>> the same config on my GNU/Linux machines as well, so I have to do the
>> whole `executable-find' thing anyway.
>>
>> What do you think of something along these lines, which seems to work at
>> least on macOS and OpenBSD? If you agree, we could investigate if it
>> works on FreeBSD and NetBSD too. I *think* it will, but it's worth
>> checking to make sure.
>>
>> diff --git a/lisp/files.el b/lisp/files.el
>> index 4188615e490..88c4ecadc9a 100644
>> --- a/lisp/files.el
>> +++ b/lisp/files.el
>> @@ -7723,7 +7723,11 @@ shell-quote-wildcard-pattern
>> pattern))))
>>
>>
>> -(defvar insert-directory-program (purecopy "ls")
>> +(defvar insert-directory-program
>> + (if (and (memq system-type '(berkeley-unix darwin))
>> + (executable-find "gls"))
>> + (purecopy "gls")
>> + (purecopy "ls"))
>> "Absolute or relative name of the `ls'-like program.
>> This is used by `insert-directory' and `dired-insert-directory'
>> \(thus, also by `dired').")
>
> If we believe "gls" is the only popular name, I guess that's good
> enough.
Hi,
I don't know if this count as a test but it seems that both FreeBSD and
NetBSD also called it "gls" in their respective packages:
https://cgit.freebsd.org/ports/tree/sysutils/coreutils/pkg-plist
http://cvsweb.netbsd.org/bsdweb.cgi/pkgsrc/sysutils/coreutils/PLIST?rev=1.22&content-type=text/x-cvsweb-markup
But, I have to say that I still don't understand why you would not also
consider applying my patch.
--
Manuel Giraud
next prev parent reply other threads:[~2023-09-04 8:05 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-22 13:22 bug#64791: 30.0.50; [PATCH] Fix dired mismatch on some filenames Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-22 13:50 ` Eli Zaretskii
2023-07-22 14:46 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-22 15:24 ` Eli Zaretskii
2023-09-03 11:34 ` Stefan Kangas
2023-09-03 11:44 ` Eli Zaretskii
2023-09-03 14:04 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-03 18:18 ` Stefan Kangas
2023-09-03 18:24 ` Eli Zaretskii
2023-09-03 18:54 ` Stefan Kangas
2023-09-03 19:25 ` Eli Zaretskii
2023-09-04 7:57 ` Stefan Kangas
2023-09-04 8:05 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-09-04 8:22 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-04 8:36 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-04 19:22 ` Stefan Kangas
2023-09-05 0:20 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-05 21:57 ` Stefan Kangas
2023-09-04 12:17 ` Eli Zaretskii
2023-09-05 22:27 ` Stefan Kangas
2023-09-05 22:43 ` Stefan Kangas
2023-09-06 11:28 ` Eli Zaretskii
2023-09-24 12:34 ` Stefan Kangas
2023-09-24 15:32 ` Eli Zaretskii
2023-09-25 9:39 ` Stefan Kangas
2023-09-24 15:41 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-24 15:56 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0netlc0.fsf@ledu-giraud.fr \
--to=bug-gnu-emacs@gnu.org \
--cc=64791@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=manuel@ledu-giraud.fr \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.