From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#65882: 29.1; rcirc doesn't rejoin channels automatically on reconnecting Date: Thu, 21 Sep 2023 16:27:10 +0000 Message-ID: <87r0mrwkyp.fsf@posteo.net> References: <87bke85hsb.fsf@gmail.com> <87a5tobby9.fsf@debian-hx90.lan> <871qf0atqs.fsf@debian-hx90.lan> <878r97ooxs.fsf@posteo.net> <87a5tf3714.fsf@debian-hx90.lan> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14273"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 65882-done@debbugs.gnu.org, Ryan Yeske , Stefan Kangas , Leo Liu To: Manphiz Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 21 18:28:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qjMXN-0003TM-Pw for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 21 Sep 2023 18:28:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qjMWv-0002vb-R2; Thu, 21 Sep 2023 12:27:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qjMWu-0002vC-2p for bug-gnu-emacs@gnu.org; Thu, 21 Sep 2023 12:27:52 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qjMWt-0002l7-QV for bug-gnu-emacs@gnu.org; Thu, 21 Sep 2023 12:27:51 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qjMX3-0001jE-Rn for bug-gnu-emacs@gnu.org; Thu, 21 Sep 2023 12:28:01 -0400 Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Sep 2023 16:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 65882 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 65882@debbugs.gnu.org, philipk@posteo.net, manphiz@gmail.com Original-Received: via spool by 65882-done@debbugs.gnu.org id=D65882.16953136536603 (code D ref 65882); Thu, 21 Sep 2023 16:28:01 +0000 Original-Received: (at 65882-done) by debbugs.gnu.org; 21 Sep 2023 16:27:33 +0000 Original-Received: from localhost ([127.0.0.1]:34704 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qjMWb-0001iQ-3Z for submit@debbugs.gnu.org; Thu, 21 Sep 2023 12:27:33 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:36563) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qjMWW-0001i9-Rp for 65882-done@debbugs.gnu.org; Thu, 21 Sep 2023 12:27:31 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 3B17C240028 for <65882-done@debbugs.gnu.org>; Thu, 21 Sep 2023 18:27:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1695313632; bh=VWOyuTIAT8pmOPo9c4e9xcOmsPZJmmJEKhy5XjRp1X0=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=jrzsP5hFbqnbo/t7tLmMLRaxwrRskn+IIF8RHd0xDOUiuja2zbbouNcLKcOA0Hag+ hrJjwcaofD70hkqG4mIsB9xKKYO45+CXW/bsGTpapJfhSd7ZgMSx990PJvNWIEdDLk biYY2X9pbF0KXKfswK26kPBAecF/Z18kWyvDvviXcS2dpKtWTePAnTN5gfwhwK9PE6 6x6RCFQTMpSITfukw3WNeNTSG/oPctXhKu3itZvVDkT2VBphpCNscUMAcVX+unuOt3 H7JVx1xpWyJg2FO+OHsf7dL+59Pb+ZnT9u6Zbag2gIAt9qTiEuHPb5FTGMzThk8OYK OH4P5VQxyly3g== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Rs15C04nHz9rxG; Thu, 21 Sep 2023 18:27:10 +0200 (CEST) In-Reply-To: <87a5tf3714.fsf@debian-hx90.lan> (manphiz@gmail.com's message of "Thu, 21 Sep 2023 08:00:55 -0700") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:271003 Archived-At: Manphiz writes: > Philip Kaludercic writes: > >> The change makes sense, but I'll want to try it out to make sure we are >> doing the right thing. Unless I write something here, ping me in a few >> days. These kinds of auto-reconnect bugs can be annoying to debug in >> real-life situations. >> > > Friendly ping. I haven't noticed any issues, and the change makes sense. I'll apply it to master. Thanks! >> Manphiz writes: >> >>> Stefan Kangas writes: >>> >>>> severity 65882 + minor >>>> thanks >>>> >>>> Manphiz writes: >>>> >>>>> I noticed that you lowered the severity of this bug from "normal" to >>>>> "wishlist". AIUI rcirc provides a way to automatically join channels >>>>> upon connecting to a server and currently this is not working as >>>>> intended, so IMHO it should be considered a bug instead of a feature >>>>> request (a wishlist). >>>> >>>> Thanks, so I bumped it to minor. I hope that makes more sense. >>>> >>> >>> Thanks! >>> >>>>> (If you are using severity as a means to manage bug triage priority >>>>> I'm OK with that.) >>>> >>>> My impression is that almost no one pays attention to bug severities, so >>>> I wouldn't make too much of it. Bug reports that come with a patch, >>>> like yours did, tend to get more visibility though. >>>> >>> >>> Ah got it. It's my first time filing bug here so not very familiar with >>> the convention. Looks like tagging patch was a good move :) >> >> So this patch would be applied without a copyright assignment, right? >> >>>>> Personally, as the patch is sufficiently trivial, I would hope it won't >>>>> take too much work for a review. But I would understand if dealing with >>>>> rcirc-user-authenticated is more involved than it looks like and should >>>>> be handled with care. >>>> >>>> I've copied in the rcirc maintainers. Let's see if they have any >>>> comments first. >>> >>> Great! Thanks again!